Disroot-Ansible
/
cryptpad
11
0
Fork 0
Code Pull Requests 2 Projects Releases Activity

Bump to cryptpad 4.4.0 #4

Merged
meaz merged 3 commits from cryptpad4.4.0 into master 2021-04-27 20:53:30 +02:00
Conversation 3 Commits 3 Files Changed 2 +13 -1
meaz commented 2021-04-21 00:36:34 +02:00
Owner
Copy Link

In the template, there are a few differences that I found compared to the official one:

  • server_name should be server_name your-main-domain.com your-sandbox-domain.com; but our template gives server_name your-main-domain.com;

  • add_header Strict-Transport-Security "max-age=31536000; includeSubDomains" is missing in our template.

  • Also, this part

#location ^~ /datastore/ {
        #add_header Cache-Control max-age=0;
        #try_files $uri =404;
    #}

is described like this:

    # This block provides an alternative means of loading content
    # otherwise only served via websocket. This is solely for debugging purposes,
    # and is thus not allowed by default.

However, this is uncommented on our template. I don't know if that was intended...

@muppeth should I change all those in the template?

In the template, there are a few differences that I found compared to the official one: - `server_name` should be `server_name your-main-domain.com your-sandbox-domain.com;` but our template gives `server_name your-main-domain.com;` - `add_header Strict-Transport-Security "max-age=31536000; includeSubDomains"` is missing in our template. - Also, this part ``` #location ^~ /datastore/ { #add_header Cache-Control max-age=0; #try_files $uri =404; #} ``` is described like this: ``` # This block provides an alternative means of loading content # otherwise only served via websocket. This is solely for debugging purposes, # and is thus not allowed by default. ``` However, this is uncommented on our template. I don't know if that was intended... @muppeth should I change all those in the template?
muppeth was assigned by meaz 2021-04-21 00:36:34 +02:00
antilopa was assigned by meaz 2021-04-21 00:36:34 +02:00
meaz added 2 commits 2021-04-21 00:36:36 +02:00
muppeth commented 2021-04-25 08:51:37 +02:00
Owner
Copy Link

I will do the needed adjustments (for the location). Server name wise it's not really needed since we have a proxy on top of it, but for defaults I could adjust those too.

I will do the needed adjustments (for the location). Server name wise it's not really needed since we have a proxy on top of it, but for defaults I could adjust those too.
muppeth commented 2021-04-25 08:56:02 +02:00
Owner
Copy Link

@meaz Pending PR for nginx template fix Disroot-Ansible/nginx#10

@meaz Pending PR for nginx template fix https://git.disroot.org/Disroot-Ansible/nginx/pulls/10
antilopa approved these changes 2021-04-25 23:09:29 +02:00
muppeth reviewed 2021-04-26 08:53:58 +02:00
templates/config/config.js.j2
@ -47,1 +47,4 @@
*
* Note: you may provide multiple origins for the purpose of accessing
* a development instance via different URLs, like so:
* httpUnsafeOrigin: 'http://127.0.0.1:3000/ http://localhost:3000/',
muppeth commented 2021-04-26 08:53:58 +02:00
Owner
Copy Link

Shouldn't we change this into a variable?

Shouldn't we change this into a variable?
muppeth marked this conversation as resolved
muppeth approved these changes 2021-04-26 08:55:59 +02:00
muppeth left a comment
Owner
Copy Link

![](https://www.meme-arsenal.com/memes/33452ec06b2e9753165efc89eca230e2.jpg)
meaz added 1 commit 2021-04-26 11:44:11 +02:00
meaz commented 2021-04-26 11:49:58 +02:00
Author
Owner
Copy Link

@antilopa you should try again now with @muppeth branch on nginx role.

@antilopa you should try again now with @muppeth branch on nginx role.
muppeth approved these changes 2021-04-27 05:54:28 +02:00
muppeth left a comment
Owner
Copy Link

![](https://memegenerator.net/img/instances/64363503/ron-swanson-approves.jpg)
antilopa approved these changes 2021-04-27 20:50:10 +02:00
meaz merged commit 9f26089423 into master 2021-04-27 20:53:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
muppeth
antilopa
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
muppeth
antilopa
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-Ansible/cryptpad#4
No description provided.
Delete Branch "cryptpad4.4.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?