Disroot-Ansible
/
dashboard
10
0
Fork 0
Code Pull Requests Projects Releases Activity

Better responsiveness #3

Merged
meaz merged 6 commits from responsiveness into main 2021-07-14 10:10:15 +02:00
Conversation 6 Commits 6 Files Changed 6 +138 -59
meaz commented 2021-05-15 11:27:12 +02:00
Owner
Copy Link
  • Better layout (I think ;)
  • Better responsiveness, espacially in mobile view.
* Better layout (I think ;) * Better responsiveness, espacially in mobile view.
meaz self-assigned this 2021-05-15 11:27:12 +02:00
meaz added 2 commits 2021-05-15 11:27:14 +02:00
meaz added 1 commit 2021-05-16 06:55:19 +02:00
meaz changed title from [WIP] Better responsiveness to Better responsiveness 2021-05-16 06:56:50 +02:00
antilopa was assigned by meaz 2021-05-16 06:57:05 +02:00
antilopa commented 2021-05-16 13:51:42 +02:00
Owner
Copy Link

Not a fan of the lighter background behind the icons. I rather choose a calm background image that doesn't disturb the readabilty. Using the Disroot icons in the circles will also seperate the icons from the background nicely.

I think it will be nice to change the grid on mobile view so icons are not so cramped togather. So 4 columns on wider screens and 3 colums on narrow screens. but super nice that it is now responsive!

Not a fan of the lighter background behind the icons. I rather choose a calm background image that doesn't disturb the readabilty. Using the Disroot icons in the circles will also seperate the icons from the background nicely. I think it will be nice to change the grid on mobile view so icons are not so cramped togather. So 4 columns on wider screens and 3 colums on narrow screens. but super nice that it is now responsive!
meaz commented 2021-05-17 16:32:26 +02:00
Author
Owner
Copy Link

With this PR, it is now 4 on wider screens, 3 on tablets, and 2 on mobile.

As for the logos, I thought about it. However, it means to change the role so that instead of using Font-Awesome, it uses logos. Are you fine with that? Or do we keep like two differents tasks, so that you can choose if you want to deploy with font-awesome or if you want to use your own logos?

With this PR, it is now 4 on wider screens, 3 on tablets, and 2 on mobile. As for the logos, I thought about it. However, it means to change the role so that instead of using Font-Awesome, it uses logos. Are you fine with that? Or do we keep like two differents tasks, so that you can choose if you want to deploy with font-awesome or if you want to use your own logos?
antilopa commented 2021-05-20 08:44:56 +02:00
Owner
Copy Link

That's a good point. You should leave the FA fonts as default and add an option to use custom icons, that would be nice.

I still think it looks better without the lighter box around and that icons on mobile devices are unnecessarily to big. I will commit my changes here, see what you think.

That's a good point. You should leave the FA fonts as default and add an option to use custom icons, that would be nice. I still think it looks better without the lighter box around and that icons on mobile devices are unnecessarily to big. I will commit my changes here, see what you think.
antilopa added 1 commit 2021-05-20 08:49:25 +02:00
antilopa added 1 commit 2021-05-20 08:58:35 +02:00
meaz commented 2021-05-21 11:39:46 +02:00
Author
Owner
Copy Link

I don't like to much this hover link color, it makes things hard to read.

I don't like to much this hover link color, it makes things hard to read.
muppeth commented 2021-05-21 12:32:06 +02:00
Owner
Copy Link

Yeah it does make things hard to read. Perhaps we could do something less invasive (just makeit darker grey or something). but for the new dashboard (when we use the same icons as on the webiste), the beetroot circle could on hover become grey?

Yeah it does make things hard to read. Perhaps we could do something less invasive (just makeit darker grey or something). but for the new dashboard (when we use the same icons as on the webiste), the beetroot circle could on hover become grey?
👍 1
meaz added 1 commit 2021-05-21 13:05:59 +02:00
meaz commented 2021-05-21 13:12:39 +02:00
Author
Owner
Copy Link

@antilopa I've changed the role a bit to add icons as we decided. I've created a branch on host_vars so that you can test those.

@antilopa I've changed the role a bit to add icons as we decided. I've created a branch on host_vars so that you can test those.
muppeth approved these changes 2021-07-01 23:59:02 +02:00
meaz merged commit 396e9d0a74 into main 2021-07-14 10:10:15 +02:00
meaz referenced this issue from a commit 2021-07-14 10:10:15 +02:00
Better responsiveness (#3)
Sign in to join this conversation.
Reviewers
No reviewers
muppeth
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
meaz
antilopa
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-Ansible/dashboard#3
No description provided.
Delete Branch "responsiveness"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?