Disroot-Ansible
/
etherpad
10
0
Fork 0
Code Pull Requests 1 Projects Releases 2 Activity

Fix of modules task #6

Closed
meaz wants to merge 13 commits from modules into master
pull from: modules
merge into: Disroot-Ansible:master
Conversation 1 Commits 13 Files Changed 8 +154 -83
meaz commented 2022-03-03 16:04:36 +01:00
Owner
Copy Link

give ownership of path "{{ etherpad_app_dir }}" to etherpad user.
Also reenable ep_delete_after_delay as it is fixed upstream

give ownership of path "{{ etherpad_app_dir }}" to etherpad user. Also reenable ep_delete_after_delay as it is fixed upstream
muppeth was assigned by meaz 2022-03-03 16:04:36 +01:00
meaz self-assigned this 2022-03-03 16:04:36 +01:00
antilopa was assigned by meaz 2022-03-03 16:04:36 +01:00
muppeth reviewed 2022-03-04 11:13:30 +01:00
tasks/modules.yml Outdated
@ -13,0 +17,4 @@
group: "{{ etherpad_group }}"
recurse: yes
state: directory
muppeth commented 2022-03-04 11:13:30 +01:00
Owner
Copy Link

Wouldn't it be better to do it like this? (havent test it though)

- name: '[Modules] - Install modules'
  npm:
    name: "{{ item.name }}"
    path: "{{ etherpad_app_dir }}"
    state: latest
    become: yes
    become_user: '{{ etherpad_username }}'
    args:
      chdir: '{{ searx_app_dir }}'
  with_items: "{{ etherpad_plugins }}"
  when: item.install|lower == 'true'
  notify:
    restart etherpad

- name: '[Modules] - Uninstall modules'
  npm:
    name: "{{ item.name }}"
    path: "{{ etherpad_app_dir }}"
    state: absent
    become: yes
    become_user: '{{ etherpad_username }}'
    args:
      chdir: '{{ searx_app_dir }}'
  with_items: "{{ etherpad_plugins }}"
  when: item.install|lower == 'false'
  notify:
    restart etherpad
Wouldn't it be better to do it like this? (havent test it though) ``` - name: '[Modules] - Install modules' npm: name: "{{ item.name }}" path: "{{ etherpad_app_dir }}" state: latest become: yes become_user: '{{ etherpad_username }}' args: chdir: '{{ searx_app_dir }}' with_items: "{{ etherpad_plugins }}" when: item.install|lower == 'true' notify: restart etherpad - name: '[Modules] - Uninstall modules' npm: name: "{{ item.name }}" path: "{{ etherpad_app_dir }}" state: absent become: yes become_user: '{{ etherpad_username }}' args: chdir: '{{ searx_app_dir }}' with_items: "{{ etherpad_plugins }}" when: item.install|lower == 'false' notify: restart etherpad ```
meaz commented 2022-03-04 15:52:58 +01:00
Author
Owner
Copy Link

Done (without the args part!)

I tested on vagrant, works fine (but it worked on vagrant without this addition! It messed up only when used on prod)

Done (without the args part!) I tested on vagrant, works fine (but it worked on vagrant without this addition! It messed up only when used on prod)
muppeth commented 2022-06-21 08:51:09 +02:00
Owner
Copy Link

closing as there is another PR fixing it.

closing as there is another PR fixing it.
muppeth closed this pull request 2022-06-21 08:51:09 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
muppeth
meaz
antilopa
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-Ansible/etherpad#6
No description provided.
Delete Branch "modules"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?