Disroot-Ansible/nginx
11
1
Fork 0
Code Pull requests Projects Releases 1 Activity

tor #38

Merged
meaz merged 10 commits from tor into master 2023-01-17 15:25:12 +01:00
Conversation 5 Commits 10 Files changed 9 +320 -3
meaz commented 2023-01-04 22:03:59 +01:00
Owner
Copy link
No description provided.
muppeth was assigned by meaz 2023-01-04 22:03:59 +01:00
meaz self-assigned this 2023-01-04 22:03:59 +01:00
meaz added 8 commits 2023-01-04 22:04:01 +01:00 
Signed-off-by: muppeth <muppeth@disroot.org>
muppeth commented 2023-01-12 00:35:39 +01:00
Owner
Copy link

I actually used tor and onion vars intentionally. TOR for everything related to running tor server and onion for vhosts to make it more clear and consistent.

I actually used tor and onion vars intentionally. TOR for everything related to running tor server and onion for vhosts to make it more clear and consistent.
meaz commented 2023-01-12 17:55:49 +01:00
Author
Owner
Copy link

sorry, it is only one week old, but I mind has been erased! What are you talking about @muppeth ? Did I messed up with something? If so, sorry, and don't hesitate to set it back as it should be...

sorry, it is only one week old, but I mind has been erased! What are you talking about @muppeth ? Did I messed up with something? If so, sorry, and don't hesitate to set it back as it should be...
muppeth commented 2023-01-12 21:55:20 +01:00
Owner
Copy link

No worries. There is nothing messed up just a comment about your commit where you changed set_onion to set_tor.

The reason I used different naming was because the two things are different and for consistency and clarity I used different naming eg.

  • "enable_tor" - is about setting up TOR server
  • "set_onion" - is about setting up an onion address / vhost in nginx.

I am not really attached to the naming either but wanted to point out the reason I used it that way. If you think it's confusing and we should just stick to namig everything tor it's fine with me.

No worries. There is nothing messed up just a comment about your [commit](https://git.disroot.org/Disroot-Ansible/nginx/commit/579397f7c498e6f4670fff2b391172dc65973f6c) where you changed set_onion to set_tor. The reason I used different naming was because the two things are different and for consistency and clarity I used different naming eg. - `"enable_tor"` - is about setting up TOR server - `"set_onion"` - is about setting up an onion address / vhost in nginx. I am not really attached to the naming either but wanted to point out the reason I used it that way. If you think it's confusing and we should just stick to namig everything tor it's fine with me.
meaz added 1 commit 2023-01-14 07:18:18 +01:00
meaz changed title from WIP: tor to tor 2023-01-14 07:18:32 +01:00
meaz commented 2023-01-14 07:19:35 +01:00
Author
Owner
Copy link

@muppeth then I think I prefer naming everyting tor ;)

@muppeth then I think I prefer naming everyting tor ;)
muppeth commented 2023-01-14 10:54:34 +01:00
Owner
Copy link

OK. I will do last check and we can probably merge. I will prepare also everything for setting it in prod on upcoming deployment.

OK. I will do last check and we can probably merge. I will prepare also everything for setting it in prod on upcoming deployment.
muppeth added 1 commit 2023-01-17 15:24:22 +01:00
muppeth approved these changes 2023-01-17 15:24:28 +01:00
meaz merged commit 6c96fe5180 into master 2023-01-17 15:25:12 +01:00
meaz deleted branch tor 2023-01-17 15:25:13 +01:00
meaz referenced this pull request from a commit 2023-01-17 15:25:13 +01:00
tor (#38)
Sign in to join this conversation.
Reviewers
No reviewers
muppeth
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
muppeth
meaz
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-Ansible/nginx#38
No description provided.
Delete branch "tor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?