Disroot-Ansible
/
nginx
11
1
Fork 0
Code Pull Requests 4 Projects Releases Activity

Vhosts creation change #63

Merged
muppeth merged 3 commits from cert_check into staging 2024-03-07 11:07:21 +01:00
Conversation 0 Commits 3 Files Changed 1 +78 -9
muppeth commented 2024-02-24 01:06:46 +01:00
Owner
Copy Link

Changed the way vhosts are created. This is to prevent situation where https vhosts are created without corresponding certificate which is causing error. Solution to that is to check if ssl cert exists for vhost before creating them.

Suggested approach is to create vhost called '01.letsencrypt' or 01.domain.ltd using letsencrypt template. This will allow new certificates to be created for upcoming vhosts and once certs are created, nginx will be able to create vhosts and not error out. (so first run letsencrypt and then nginx).

Currently vhost creation and enabling is done separate for HTTP and HTTPS vhosts. Not the best solution, but works for now.

Changed the way vhosts are created. This is to prevent situation where https vhosts are created without corresponding certificate which is causing error. Solution to that is to check if ssl cert exists for vhost before creating them. Suggested approach is to create vhost called '01.letsencrypt' or `01.domain.ltd` using `letsencrypt` template. This will allow new certificates to be created for upcoming vhosts and once certs are created, nginx will be able to create vhosts and not error out. (so first run letsencrypt and then nginx). Currently vhost creation and enabling is done separate for HTTP and HTTPS vhosts. Not the best solution, but works for now.
muppeth added 2 commits 2024-02-24 01:06:47 +01:00
meaz approved these changes 2024-02-25 11:23:09 +01:00
muppeth added 1 commit 2024-03-07 11:05:31 +01:00
muppeth merged commit 002e1183fc into staging 2024-03-07 11:07:21 +01:00
muppeth deleted branch cert_check 2024-03-07 11:07:21 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
meaz
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-Ansible/nginx#63
No description provided.
Delete Branch "cert_check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?