1.0 - Improved vhost creation and headers #68
Loading…
Reference in a new issue
No description provided.
Delete branch "staging"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Ton of changes. Mainly:
@ -44,0 +87,4 @@
when:
- item.state is defined
- item.state == 'disable'
- item.state == 'delete'
Isn't this equal to
... and item.state == 'disable' and item.state == 'delete'
(that can never be true)?yes, but I guess that this is for readability :)
Yes. At some point when working on stuff I thought of splitting it per line to avoid having long ass lines. That said I will change the 'version' to below 1.0. I think we could "release" 1.0 when we have a proper documentation in place and we review the entire role and steamline/cleanup as much as we can as things got a bit complex in here.
For the other cases - where multiple conditions linked by logical and were rearranged as a list - it was clear that it was a style change, for readability.
However, my question was strictly for this case, in which the initial chain of conditions had a logical or operator, and by switching from a single-line set of conditions to a list (one per line) you are actually changing the logic (since now all the conditions must be true).
I did considered a possible deliberate change (i.e. the original
when
statement was wrong and you fixed it) but it does not make sense, sinceitem.state
cannot be'disable'
and'delete'
simultaneously.You are totally right. I did not notice you pointed to specific task at first and I missed the fact that indeed there was an OR condition there. Thanks again for find this stuff correcting our sloppy work.