Disroot-Ansible
/
prosody
10
0
Fork 0
Code Pull Requests Projects Releases Activity

add 3 new mods #11

Closed
meaz wants to merge 3 commits from prosody_mod into master
pull from: prosody_mod
merge into: Disroot-Ansible:master
Conversation 2 Commits 3 Files Changed 2 +30
meaz commented 2021-07-29 14:35:37 +02:00
Owner
Copy Link
No description provided.
muppeth was assigned by meaz 2021-07-29 14:35:37 +02:00
antilopa was assigned by meaz 2021-07-29 14:35:37 +02:00
meaz added 1 commit 2021-07-29 14:35:39 +02:00
meaz added 1 commit 2021-07-30 09:27:15 +02:00
muppeth commented 2021-08-01 09:33:48 +02:00
Owner
Copy Link

I think we need to investigate this better to see whether this should be set enabled as default and whether we should just keep the variables same as the ones provided as very much defaults on prosody's wiki.
I personally think those should not be set enabled by default because they are very specific to a use-case (webhook works if you use bots, and the secret should not be the one used by prosody's example), and bidi also requires you to have stun and turn server which shouldn't be requirenment in this role because it requires you to install third party service and that service, depending on the architecture might either not be able to be installed or needs to be installed on another server.

I would suggest to indeed put them into host_vars but set them to default disabled and change the webhook secret to something other then the example from prosody.

I think we need to investigate this better to see whether this should be set enabled as default and whether we should just keep the variables same as the ones provided as very much defaults on prosody's wiki. I personally think those should not be set enabled by default because they are very specific to a use-case (webhook works if you use bots, and the secret should not be the one used by prosody's example), and bidi also requires you to have stun and turn server which shouldn't be requirenment in this role because it requires you to install third party service and that service, depending on the architecture might either not be able to be installed or needs to be installed on another server. I would suggest to indeed put them into host_vars but set them to default disabled and change the webhook secret to something other then the example from prosody.
meaz added 1 commit 2021-12-28 11:25:50 +01:00
muppeth commented 2022-01-06 22:38:30 +01:00
Owner
Copy Link

Shall we break this into two seperate issues. Slack webhooks we could turn into feature request and the other modules create seperate pull request for?

Shall we break this into two seperate issues. Slack webhooks we could turn into feature request and the other modules create seperate pull request for?
meaz closed this pull request 2022-03-01 21:04:03 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
muppeth
antilopa
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-Ansible/prosody#11
No description provided.
Delete Branch "prosody_mod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?