Disroot-themes/grav-theme-disroot
Disroot-themes
/
grav-theme-disroot
7
2
Fork 0
Code Pull Requests Releases Activity

improve mobile rendering of donations and footer #75

Merged
avg_joe merged 6 commits from improve-mobile-rendering into main 2023-11-20 22:40:22 +01:00
Conversation 12 Commits 6 Files Changed 6 +94 -40
avg_joe commented 2023-11-05 23:54:54 +01:00
Owner
Copy Link

please check thoroughly. be caution noob work :)

please check thoroughly. be caution noob work :)
avg_joe added 1 commit 2023-11-05 23:54:55 +01:00
avg_joe changed title from improve mobile rendering of donations and footer to WIP: improve mobile rendering of donations and footer 2023-11-05 23:55:03 +01:00
avg_joe requested review from meaz 2023-11-05 23:55:14 +01:00
avg_joe requested review from antilopa 2023-11-05 23:55:14 +01:00
avg_joe changed title from WIP: improve mobile rendering of donations and footer to improve mobile rendering of donations and footer 2023-11-05 23:59:53 +01:00
avg_joe added 2 commits 2023-11-06 00:04:23 +01:00
avg_joe commented 2023-11-06 14:49:53 +01:00
Author
Owner
Copy Link

i think the disroot symbol buttom left was intended to point to contact. i wonder if it can be implemted the same way as mastodon and rss symbol to the right. but i didn't understand how they work. to try myself.

i think the disroot symbol buttom left was intended to point to contact. i wonder if it can be implemted the same way as mastodon and rss symbol to the right. but i didn't understand how they work. to try myself.
avg_joe commented 2023-11-06 19:11:20 +01:00
Author
Owner
Copy Link

ok, i understand now where the rss and masto icon come from. it seems to be possible to add custom icons to awesome font. not sure it's worth the effort though. https://dev.to/astagi/add-custom-icons-to-font-awesome-4m67

ok, i understand now where the rss and masto icon come from. it seems to be possible to add custom icons to awesome font. not sure it's worth the effort though. https://dev.to/astagi/add-custom-icons-to-font-awesome-4m67
avg_joe commented 2023-11-13 17:17:58 +01:00
Author
Owner
Copy Link

@antilopa @meaz short reminder that this waits to be reviewed

@antilopa @meaz short reminder that this waits to be reviewed
meaz reviewed 2023-11-15 12:16:51 +01:00
templates/partials/footer.html.twig Outdated
@ -1,5 +1,7 @@
<footer>
<div id="footer-logo" ><a href="{{ base_url }}/contact"></a></div>
meaz commented 2023-11-15 12:16:51 +01:00
Owner
Copy Link

@antilopa what was the point of this line? coz it looks like useless to me...

@antilopa what was the point of this line? coz it looks like useless to me...
meaz commented 2023-11-15 12:18:33 +01:00
Owner
Copy Link

nevermind I found the second I posted the message!

nevermind I found the second I posted the message!
meaz marked this conversation as resolved
meaz commented 2023-11-15 12:29:07 +01:00
Owner
Copy Link

@antilopa @avg_joe what would you think about removing the <div id="footer-logo" > part?
we already have the D logo in the nav bar:
Capture d’écran du 2023-11-15 12-27-42.png

@antilopa @avg_joe what would you think about removing the ` <div id="footer-logo" >` part? we already have the D logo in the nav bar: ![Capture d’écran du 2023-11-15 12-27-42.png](/attachments/f7333ce3-2dd8-4935-b9a7-3ae18a4c56cc)
Capture d’écran du 2023-11-15 12-27-42.png
54 KiB
avg_joe commented 2023-11-15 14:55:51 +01:00
Author
Owner
Copy Link

no opinion actually. but i was thinking about the copyleft entry during me work. it has no link, meaning (ccx? gpl? what for?), takes a lot of space, could be replaced by a symbol ...

no opinion actually. but i was thinking about the copyleft entry during me work. it has no link, meaning (ccx? gpl? what for?), takes a lot of space, could be replaced by a symbol ...
👍 1
avg_joe commented 2023-11-15 22:27:56 +01:00
Author
Owner
Copy Link

https://forkaweso.me/Fork-Awesome/icons/
there's no copyleft icon
there are creative commons icons
there is no MIT icon
themes are licenses under MIT
https://git.disroot.org/Disroot-themes/grav-theme-disroot/src/branch/main/LICENSE
website under nta license
https://git.disroot.org/Disroot/Website
hahahaha
but i guess probably some cc license as it's about content. H2 is licended under CC-BY-SA

https://forkaweso.me/Fork-Awesome/icons/ there's no copyleft icon there are creative commons icons there is no MIT icon themes are licenses under MIT https://git.disroot.org/Disroot-themes/grav-theme-disroot/src/branch/main/LICENSE website under nta license https://git.disroot.org/Disroot/Website hahahaha but i guess probably some cc license as it's about content. H2 is licended under CC-BY-SA
avg_joe commented 2023-11-17 17:39:26 +01:00
Author
Owner
Copy Link

i need a hint, i don't find it myself.
where in the theme/css stuff is the mobile view. there is some changes like the nav-bar, or links to masto/rss gone.

i need a hint, i don't find it myself. where in the theme/css stuff is the mobile view. there is some changes like the nav-bar, or links to masto/rss gone.
meaz commented 2023-11-17 21:52:06 +01:00
Owner
Copy Link

In media-queries.css @avg_joe

In media-queries.css @avg_joe
avg_joe added 1 commit 2023-11-18 21:17:47 +01:00
avg_joe added 1 commit 2023-11-18 22:14:51 +01:00
meaz approved these changes 2023-11-18 22:44:59 +01:00
meaz left a comment
Owner
Copy Link

I approve, but I would appreciate if you could have a look also @antilopa

I approve, but I would appreciate if you could have a look also @antilopa
antilopa commented 2023-11-20 11:42:08 +01:00
Owner
Copy Link

I think it looks fine but we could perhaps make it more in line with the other icons,color-wise. like this:
image

What do you think? if you like it i can push the image to this branch.

I think it looks fine but we could perhaps make it more in line with the other icons,color-wise. like this: ![image](/attachments/5feed1e9-d9be-48a3-906d-113201cc9d1b) What do you think? if you like it i can push the image to this branch.
image.png
18 KiB
avg_joe commented 2023-11-20 14:13:18 +01:00
Author
Owner
Copy Link

@antilopa nice one! one thing to do would be adding license info to https://git.disroot.org/Disroot/Website#license and if we agree on cc-by-sa

@antilopa nice one! one thing to do would be adding license info to https://git.disroot.org/Disroot/Website#license and if we agree on cc-by-sa
antilopa added 1 commit 2023-11-20 16:38:31 +01:00
avg_joe commented 2023-11-20 19:56:18 +01:00
Author
Owner
Copy Link

Disroot/Website#460

@antilopa @meaz so this is ready to be merged?

https://git.disroot.org/Disroot/Website/pulls/460 @antilopa @meaz so this is ready to be merged?
meaz commented 2023-11-20 20:21:50 +01:00
Owner
Copy Link

yes @avg_joe

yes @avg_joe
avg_joe merged commit 8527e6a677 into main 2023-11-20 22:40:22 +01:00
avg_joe deleted branch improve-mobile-rendering 2023-11-20 22:40:22 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
antilopa
meaz
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-themes/grav-theme-disroot#75
No description provided.
Delete Branch "improve-mobile-rendering"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?