Disroot-themes/grav-theme-disrootblog
6
3
Fork 2
Code Pull requests Releases Activity

Make blog footer look the same as the one from main theme (grav-theme-disroot) #12

Merged
meaz merged 3 commits from floss4good/Disroot-themes__grav-theme-disrootblog:main into main 2024-02-07 19:12:27 +01:00
Conversation 4 Commits 3 Files changed 5 +95 -41
floss4good commented 2024-02-06 01:58:18 +01:00
Contributor
Copy link
  • Should fix issue 763
  • For some window sizes, at least on Firefox, I can see a small difference regarding the vertical position of the icons; this should be further investigated.
  • Currently the copyleft icon (by-sa.png) is loaded from the main theme; should be decided if it must be added also in this repository.
  • Since the white D logo (d-white.png) was removed from the footer and it is not used elsewhere, it can be removed from the repository as well as any linked CSS (I have already commented out the related CSS).
    • BTW: The same applies for grav-theme-disroot repository.
- Should fix [issue 763](/Disroot/Disroot-Project/issues/763) - For some window sizes, at least on Firefox, I can see a small difference regarding the vertical position of the icons; this should be further investigated. - Currently the copyleft icon (by-sa.png) is loaded from the main theme; should be decided if it must be added also in this repository. - Since the white D logo (d-white.png) was removed from the footer and it is not used elsewhere, it can be removed from the repository as well as any linked CSS (I have already commented out the related CSS). - BTW: The same applies for grav-theme-disroot repository.
floss4good added 2 commits 2024-02-06 01:58:19 +01:00 
Refs: /Disroot-themes/grav-theme-disroot/pulls/75/
meaz commented 2024-02-06 22:23:00 +01:00
Owner
Copy link

For some window sizes, at least on Firefox, I can see a small difference regarding the vertical position of the icons; this should be further investigated.

That will be fine for now, unless you want to spend some extra time on this.

Currently the copyleft icon (by-sa.png) is loaded from the main theme; should be decided if it must be added also in this repository.
For sure it needs to be added here. Can you take care of this?

Since the white D logo (d-white.png) was removed from the footer and it is not used elsewhere, it can be removed from the repository as well as any linked CSS (I have already commented out the related CSS).
Let's keep it for now, until we are sure we won't use it anymore.

You marked your PR as WIP. Should I wait before merging then (well, at least for the by-sa.png)

Thanks a lot for the work.

> For some window sizes, at least on Firefox, I can see a small difference regarding the vertical position of the icons; this should be further investigated. That will be fine for now, unless you want to spend some extra time on this. > Currently the copyleft icon (by-sa.png) is loaded from the main theme; should be decided if it must be added also in this repository. For sure it needs to be added here. Can you take care of this? > Since the white D logo (d-white.png) was removed from the footer and it is not used elsewhere, it can be removed from the repository as well as any linked CSS (I have already commented out the related CSS). Let's keep it for now, until we are sure we won't use it anymore. You marked your PR as WIP. Should I wait before merging then (well, at least for the by-sa.png) Thanks a lot for the work.
floss4good commented 2024-02-06 23:39:00 +01:00
Author
Contributor
Copy link

I can take care of by-sa.png file later today (it is already Wednesday here).

That will be fine for now, unless you want to spend some extra time on this.

I also consider it is enough for now (also taking into account that you are planning to change the website or at least the themes).

I can take care of `by-sa.png` file later today (it is already Wednesday here). --- > That will be fine for now, unless you want to spend some extra time on this. I also consider it is enough for now (also taking into account that you are planning to change the website or at least the themes).
floss4good added 1 commit 2024-02-07 16:10:33 +01:00
floss4good changed title from WIP: Make blog footer look the same as the one from main theme (grav-theme-disroot) to Make blog footer look the same as the one from main theme (grav-theme-disroot) 2024-02-07 16:13:35 +01:00
floss4good commented 2024-02-07 16:18:21 +01:00
Author
Contributor
Copy link

I have added the by-sa.png file also in this repository.
You can now review this PR.

I have added the `by-sa.png` file also in this repository. You can now review this PR.
meaz commented 2024-02-07 19:12:21 +01:00
Owner
Copy link

Perfect! Thanks a lot!

Perfect! Thanks a lot!
meaz merged commit 5bb5932bdd into main 2024-02-07 19:12:27 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-themes/grav-theme-disrootblog#12
No description provided.
Delete branch "floss4good/Disroot-themes__grav-theme-disrootblog:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?