Disroot-themes/roundcube_themes
7
1
Fork 0
Code Pull requests Releases 3 Activity

Separate all custom changes (#15) #16

Merged
meaz merged 2 commits from staging into main 2024-08-09 19:06:14 +02:00
Conversation 2 Commits 2 Files changed 13 +25 -300
meaz commented 2024-08-05 08:38:04 +02:00
Owner
Copy link

All changes where already separated, but what I did is:

  • check all of those
  • remove dublicate with some '@import' (for example @import "_colors"; was set in _dark.less and in _style.less which is not needed as it is already set in _variables.less
  • remove _darkc.less as I don't see why it even existed!
  • remove all vars in _variables_less as those where already set in variables.less
  • update the min files accordingly

Reviewed-on: #15
Reviewed-by: muppeth <muppeth@no-reply@disroot.org>
Co-authored-by: meaz meaz@disroot.org
Co-committed-by: meaz meaz@disroot.org

All changes where already separated, but what I did is: - check all of those - remove dublicate with some '@import' (for example `@import "_colors";` was set in `_dark.less` and in `_style.less` which is not needed as it is already set in `_variables.less` - remove `_darkc.less` as I don't see why it even existed! - remove all vars in `_variables_less` as those where already set in `variables.less` - update the min files accordingly Reviewed-on: https://git.disroot.org/Disroot-themes/roundcube_themes/pulls/15 Reviewed-by: muppeth <muppeth@no-reply@disroot.org> Co-authored-by: meaz <meaz@disroot.org> Co-committed-by: meaz <meaz@disroot.org>
muppeth was assigned by meaz 2024-08-05 08:38:04 +02:00
meaz added 1 commit 2024-08-05 08:38:05 +02:00 
All changes where already separated, but what I did is:
- check all of those
- remove dublicate with some  '@import' (for example `@import "_colors";` was set in `_dark.less` and in `_style.less` which is not needed as it is already set in `_variables.less`
- remove `_darkc.less` as I don't see why it even existed!
- remove all vars in `_variables_less` as those where already set in `variables.less`
- update the min files accordingly

Reviewed-on: #15
Reviewed-by: muppeth <muppeth@no-reply@disroot.org>
Co-authored-by: meaz <meaz@disroot.org>
Co-committed-by: meaz <meaz@disroot.org>
meaz changed title from Separate all custom changes (#15) to [WIP] Separate all custom changes (#15) 2024-08-05 08:38:25 +02:00
meaz commented 2024-08-05 08:38:40 +02:00
Author
Owner
Copy link

To be merged once deployed on pulga

To be merged once deployed on pulga
muppeth added 1 commit 2024-08-05 09:05:32 +02:00 
Reviewed-on: #17
Reviewed-by: meaz <meaz@no-reply@disroot.org>
Co-authored-by: muppeth <muppeth@disroot.org>
Co-committed-by: muppeth <muppeth@disroot.org>
meaz changed title from [WIP] Separate all custom changes (#15) to Separate all custom changes (#15) 2024-08-09 16:48:41 +02:00
meaz commented 2024-08-09 16:49:01 +02:00
Author
Owner
Copy link

Can I merge this @muppeth ?

Can I merge this @muppeth ?
muppeth approved these changes 2024-08-09 17:41:54 +02:00
meaz merged commit c6ed1e533e into main 2024-08-09 19:06:14 +02:00
meaz deleted branch staging 2024-08-09 19:06:14 +02:00
meaz referenced this pull request from a commit 2024-08-09 19:06:16 +02:00
Separate all custom changes (#15) (#16)
Sign in to join this conversation.
Reviewers
No reviewers
muppeth
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
muppeth
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-themes/roundcube_themes#16
No description provided.
Delete branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?