Disroot/CHANGELOG
Disroot
/
CHANGELOG
13
8
Fork 2
Code Issues 11 Pull Requests Projects Releases Activity

fix: typo (and indentation) #581

Merged
muppeth merged 1 commits from floss4good/Disroot__CHANGELOG:main into main 2024-03-22 22:14:19 +01:00
Conversation 3 Commits 1 Files Changed 1 +2 -2
floss4good commented 2024-03-22 22:13:21 +01:00
Contributor
Copy Link
No description provided.
floss4good added 1 commit 2024-03-22 22:13:25 +01:00
muppeth approved these changes 2024-03-22 22:14:09 +01:00
muppeth merged commit ff92379016 into main 2024-03-22 22:14:19 +01:00
floss4good commented 2024-03-22 22:41:06 +01:00
Author
Contributor
Copy Link

Hello,
I have a question concerning PRs.
I generally consider as a good practice to first create an issue before submitting a PR.
However, for very small changes - when let's say there is an obvious fix for which there is almost nothing to be discussed (like the current one) - I am skipping the first part, treating this as an exception.
So, the question is: would you prefer me (as an outsider) to always create an issue describing the new bug and only after to offer to submit a PR?

Hello, I have a question concerning PRs. I generally consider as a good practice to first create an issue before submitting a PR. However, for very small changes - when let's say there is an obvious fix for which there is almost nothing to be discussed (like the current one) - I am skipping the first part, treating this as an exception. So, the question is: would you prefer me (as an outsider) to always create an issue describing the new bug and only after to offer to submit a PR?
muppeth commented 2024-03-22 23:44:30 +01:00
Owner
Copy Link

Why? No just submit PR like the one here.

Why? No just submit PR like the one here.
👍 1
Shadowstreik commented 2024-03-23 00:30:39 +01:00
First-time contributor
Copy Link

Why? No just submit PR like the one here.

I have to remember that. chuckle

> Why? No just submit PR like the one here. I have to remember that. *chuckle*
Sign in to join this conversation.
Reviewers
No reviewers
muppeth
Labels
Clear labels   
Done

This has been done

  
New

New update reported

  
Ready for production

Ready to be deployed

  
Staging phase

Service deployed to staging server being tested

  
WIP

Work in progress by sysadmin

No Label
Done
New
Ready for production
Staging phase
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/CHANGELOG#581
No description provided.
Delete Branch "floss4good/Disroot__CHANGELOG:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?