Lufi hangs when uploading a file after removing a file #854

New Issue

Open

opened 2024-03-20 13:53:07 +01:00 by glab · 2 comments

glab commented

2024-03-20 13:53:07 +01:00

In some situations Lufi can hang when uploading a file. While it is easy to work around this issue once you know about it, it can cause confusion to users.

Easy way to reproduce the problem:

Load or reload the page (https://upload.disroot.org/);
Press the button to select a file using the file browser (maybe dragging files works too);
Select a file of size above 760KiB to be uploaded;
After the file is uploaded, press the red X that shows on the right to remove the file;
Re-upload the same file again.

Notes

The second file does not need to be the original one. Any file of non-smaller size will do.

If the file that is uploaded and then removed is smaller than the 760KiB size, then this problem will trigger only when trying to replace it with a larger file. Actually, it seems that the second file needs to be about the same size or larger than the original file, though I have not tested this exhaustively.

Thoughts (may be misdirecting):

It seems to me that, when eliminating a file that had been uploaded, some state, associated with that slot, is not reset properly. Applying the old state to the new file causes the problem we see if the old state does not "fit" the new file (something to to with the file size? space allocation?).

In some situations Lufi can hang when uploading a file. While it is easy to work around this issue once you know about it, it can cause confusion to users. ### Easy way to reproduce the problem: 1. Load or reload the page (https://upload.disroot.org/); 2. Press the button to select a file using the file browser (maybe dragging files works too); 3. Select a file of size above 760KiB to be uploaded; 4. After the file is uploaded, press the red X that shows on the right to remove the file; 5. Re-upload the same file again. ### Notes The second file does not need to be the original one. Any file of non-smaller size will do. If the file that is uploaded and then removed is smaller than the 760KiB size, then this problem will trigger only when trying to replace it with a larger file. Actually, it seems that the _second_ file needs to be about the same size or larger than the original file, though I have not tested this exhaustively. ### Thoughts (may be misdirecting): It seems to me that, when eliminating a file that had been uploaded, some state, associated with that slot, is not reset properly. Applying the old state to the new file causes the problem we see if the old state does not "fit" the new file (something to to with the file size? space allocation?).