Disroot/Disroot-ToS
7
0
Fork 1
Code Issues Pull requests Releases Wiki Activity

add-IT-ToS-translation-+-Community-Coexicesnte-DE #13

Merged
avg_joe merged 4 commits from add-IT-ToS-translation-+-Community-Coexicesnte-DE into main 2024-06-09 15:26:02 +02:00
Conversation 6 Commits 4 Files changed 3 +315 -66
avg_joe commented 2024-05-12 22:52:47 +02:00
Owner
Copy link

approvals needed.

approvals needed.
antilopa was assigned by avg_joe 2024-05-12 22:52:47 +02:00
fede was assigned by avg_joe 2024-05-12 22:52:47 +02:00
meaz was assigned by avg_joe 2024-05-12 22:52:47 +02:00
muppeth was assigned by avg_joe 2024-05-12 22:52:47 +02:00
avg_joe added 3 commits 2024-05-12 22:52:48 +02:00
meaz approved these changes 2024-05-13 15:31:19 +02:00
Dismissed
fede approved these changes 2024-05-13 18:30:50 +02:00
floss4good reviewed 2024-05-14 23:39:29 +02:00
changelog Outdated
@ -5,3 +7,3 @@
- V1.2.1 better define commercial activities
changes: https://git.disroot.org/Disroot/Disroot-ToS/pulls/10
changes: https://git.disroot.org/Disroot/Disroot-ToS/pulls/
floss4good commented 2024-05-14 23:39:29 +02:00
First-time contributor
Copy link

What is the purpose of this change?
Keeping a link pointing to the list of open pull requests seems quite unclear/useless in this context from my point of view.

What is the purpose of this change? Keeping a link pointing to the list of open pull requests seems quite unclear/useless in this context from my point of view.
avg_joe commented 2024-05-17 14:32:31 +02:00
Author
Owner
Copy link

before the link was pointing to a specific pull, so i wanted to point to all of em. but i see it defaults to open ones. thanks for noticing. could change to https://git.disroot.org/Disroot/Disroot-ToS/pulls?q=&state=closed

before the link was pointing to a specific pull, so i wanted to point to all of em. but i see it defaults to open ones. thanks for noticing. could change to https://git.disroot.org/Disroot/Disroot-ToS/pulls?q=&state=closed
floss4good commented 2024-05-17 15:35:44 +02:00
First-time contributor
Copy link

It was pointing to a specific PR - #10, that implemented the changes discussed within issue #9 - because the link was included as part of the description for a specific version V1.2.1 better define commercial activities. Therefore, from my point of view, it makes sense to be a specific link (pointing either to the PR or to the issue). In the same time, I admit that inviting users to check such git changes / discussions is not that user friendly, but rather suitable for more technical people.

In other words, I think that completely removing the URL can also be an approach, also taking into account that /tos page already includes a link for checking the changes history within the git repository:

You can follow the history of changes on this document on our git repository here or the changelog

It was pointing to a specific PR - #10, that implemented the changes discussed within issue #9 - because the link was included as part of the description for a specific version _V1.2.1 better define commercial activities_. Therefore, from my point of view, it makes sense to be a specific link (pointing either to the PR or to the issue). In the same time, I admit that inviting users to check such git changes / discussions is not that user friendly, but rather suitable for more technical people. In other words, I think that completely removing the URL can also be an approach, also taking into account that [/tos](https://disroot.org/en/tos) page already includes a link for checking the changes history within the git repository: > You can follow the history of changes on this document on our git repository [here](https://git.disroot.org/Disroot/Disroot-ToS/commits/branch/main) or the [changelog](https://git.disroot.org/Disroot/Disroot-ToS/src/branch/main/changelog)
avg_joe commented 2024-05-17 19:21:15 +02:00
Author
Owner
Copy link

ah i see, i thought its meant to point to all changes. makes sense what yoy say, gonna change back and add link to pull of latest changes. thanks for pointing out!

ah i see, i thought its meant to point to all changes. makes sense what yoy say, gonna change back and add link to pull of latest changes. thanks for pointing out!
floss4good commented 2024-05-17 23:24:03 +02:00
First-time contributor
Copy link

You're welcome; I'm glad if I was helpful.

You're welcome; I'm glad if I was helpful.
avg_joe added 1 commit 2024-05-19 22:42:54 +02:00
avg_joe requested review from meaz 2024-05-19 22:49:08 +02:00
avg_joe requested review from fede 2024-05-19 22:49:11 +02:00
avg_joe commented 2024-05-19 22:50:03 +02:00
Author
Owner
Copy link

@muppeth third approval needed

@muppeth third approval needed
meaz approved these changes 2024-05-21 19:50:49 +02:00
avg_joe commented 2024-06-06 22:45:32 +02:00
Author
Owner
Copy link

@Disroot/Owners two more approvals needed

@Disroot/Owners two more approvals needed
avg_joe closed this pull request 2024-06-06 22:45:32 +02:00
avg_joe reopened this pull request 2024-06-06 22:45:44 +02:00
muppeth approved these changes 2024-06-09 15:15:08 +02:00
antilopa approved these changes 2024-06-09 15:17:37 +02:00
avg_joe merged commit 5313debf98 into main 2024-06-09 15:26:02 +02:00
avg_joe deleted branch add-IT-ToS-translation-+-Community-Coexicesnte-DE 2024-06-09 15:26:02 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fede
meaz
muppeth
antilopa
Labels
Clear labels   
1.2

Document version

  
REVIEW

Document needs revision

  
UPDATE
No labels
1.2
REVIEW
UPDATE
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
antilopa
fede
meaz
muppeth
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/Disroot-ToS#13
No description provided.
Delete branch "add-IT-ToS-translation-+-Community-Coexicesnte-DE"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?