Disroot/Website
Disroot
/
Website
14
15
Fork 14
Code Pull Requests 4 Releases Activity

update and cleanup of pages #479

Merged
meaz merged 6 commits from update_cleanup into main 2024-04-25 11:10:42 +02:00
Conversation 5 Commits 6 Files Changed 183 +538 -376
meaz commented 2024-04-23 21:43:59 +02:00
Owner
Copy Link

See Disroot/Disroot-Project#842

See https://git.disroot.org/Disroot/Disroot-Project/issues/842
antilopa was assigned by meaz 2024-04-23 21:43:59 +02:00
avg_joe was assigned by meaz 2024-04-23 21:43:59 +02:00
fede was assigned by meaz 2024-04-23 21:43:59 +02:00
muppeth was assigned by meaz 2024-04-23 21:43:59 +02:00
meaz added 2 commits 2024-04-23 21:44:00 +02:00
floss4good reviewed 2024-04-24 01:15:20 +02:00
pages/03.services/03.nextcloud/modular.de.md Outdated
@ -28,3 +26,3 @@
- _nextcloud-talk
- _nextcloud-sweep
- _nextcloud-checksum
- _nextcloud-cookbook
floss4good commented 2024-04-24 00:28:33 +02:00
Contributor
Copy Link

Shouldn't you include also _nextcloud-cospend?

Shouldn't you include also `_nextcloud-cospend`?
meaz marked this conversation as resolved
pages/03.services/11.search/_search/2col.en.md Outdated
@ -17,3 +17,3 @@
# Anonymous multi search engine platform
Disroot's Search is a search engine like Google, DuckDuckGo, Qwant, powered by **Searx**. What makes it unique from others is that it is a metasearch engine, aggregating the results of other search engines while not storing information about its users.
Disroot's Search is a search engine like Google, DuckDuckGo, Qwant, powered by **Searxng**. What makes it unique from others is that it is a metasearch engine, aggregating the results of other search engines while not storing information about its users.
floss4good commented 2024-04-24 00:39:43 +02:00
Contributor
Copy Link

Official spelling is SearXNG.

And the files from pages/03.services/11.search/_search-tech should also be updated.

Official spelling is `SearXNG`. And the files from pages/03.services/11.search/_search-tech should also be updated.
meaz marked this conversation as resolved
pages/03.services/11.search/_search/2col.en.md
@ -23,3 +23,3 @@
Disroot Search: [https://search.disroot.org](https://search.disroot.org)
Source code: [https://github.com/asciimoo/searx](https://github.com/asciimoo/searx)
Source code: [https://github.com/searxng/searxng](https://github.com/searxng/searxng)
floss4good commented 2024-04-24 00:49:16 +02:00
Contributor
Copy Link

The same should be changed also for DE, ES and FR.

The same should be changed also for DE, ES and FR.
meaz marked this conversation as resolved
floss4good commented 2024-04-24 01:58:28 +02:00
Contributor
Copy Link

Does it make any sense to keep duplicate screenshots per language, like the below mentioned ones, even if there is nothing translated?

  • pages/03.services/10.upload/_lufi-how/de/lufi-drop.png
  • pages/03.services/10.upload/_lufi-how/en/lufi-drop.png
Does it make any sense to keep duplicate screenshots per language, like the below mentioned ones, even if there is nothing translated? - pages/03.services/10.upload/_lufi-how/de/lufi-drop.png - pages/03.services/10.upload/_lufi-how/en/lufi-drop.png
meaz added 1 commit 2024-04-24 09:36:39 +02:00
meaz commented 2024-04-24 09:43:43 +02:00
Author
Owner
Copy Link

Does it make any sense to keep duplicate screenshots per language, like the below mentioned ones, even if there is nothing translated?

  • pages/03.services/10.upload/_lufi-how/de/lufi-drop.png
  • pages/03.services/10.upload/_lufi-how/en/lufi-drop.png

No it doesn't make sense indeed.

Thanks for all the points, I resolved all of them @floss4good

> Does it make any sense to keep duplicate screenshots per language, like the below mentioned ones, even if there is nothing translated? > - pages/03.services/10.upload/_lufi-how/de/lufi-drop.png > - pages/03.services/10.upload/_lufi-how/en/lufi-drop.png No it doesn't make sense indeed. Thanks for all the points, I resolved all of them @floss4good
meaz added 1 commit 2024-04-24 09:44:15 +02:00
floss4good reviewed 2024-04-24 11:09:30 +02:00
pages/03.services/06.cryptpad/_cryptpad-diagram/2col.de.md
@ -0,0 +1,12 @@
---
floss4good commented 2024-04-24 11:05:50 +02:00
Contributor
Copy Link

This addition should probably be followed by an update of the last_modified date from translation banner (for all languages).

This addition should probably be followed by an update of the `last_modified` date from translation banner (for all languages).
meaz marked this conversation as resolved
pages/03.services/06.cryptpad/_cryptpad/2col.de.md Outdated
@ -19,3 +19,3 @@
Disroot Cryptpad: [cryptpad.disroot.org](https://cryptpad.disroot.org)
Disroot CryptPad: [cryptpad.disroot.org](https://cryptpad.disroot.org)
Projekt Website: [https://cryptpad.fr](https://cryptpad.fr)
floss4good commented 2024-04-24 10:36:22 +02:00
Contributor
Copy Link

Also here, please: cryptpad.fr → cryptpad.org

Also here, please: cryptpad.fr → cryptpad.org
meaz marked this conversation as resolved
pages/03.services/06.cryptpad/_cryptpad/2col.en.md Outdated
@ -21,3 +21,3 @@
Project homepage: [https://cryptpad.fr](https://cryptpad.fr)
Project homepage: [https://cryptpad.org](https://cryptpad.org)
Source code: [https://github.com/xwiki-labs/cryptpad](https://github.com/xwiki-labs/cryptpad)
floss4good commented 2024-04-24 10:38:14 +02:00
Contributor
Copy Link

The source code URL is now https://github.com/cryptpad/cryptpad
(same for all languages)

The source code URL is now https://github.com/cryptpad/cryptpad (same for all languages)
meaz marked this conversation as resolved
pages/03.services/06.cryptpad/modular.en.md Outdated
@ -1,23 +0,0 @@
---
floss4good commented 2024-04-24 10:59:01 +02:00
Contributor
Copy Link

I did not tested this branch locally, but I was expected to see the _cryptpad-diagram partial included (for all languages) rather than this file being deleted. Am I missing something?!

I did not tested this branch locally, but I was expected to see the `_cryptpad-diagram` partial included (for all languages) rather than this file being deleted. Am I missing something?!
meaz commented 2024-04-24 22:33:59 +02:00
Author
Owner
Copy Link

my mistake. @fede restored it already.

my mistake. @fede restored it already.
meaz marked this conversation as resolved
pages/03.services/11.search/_search/2col.it.md
@ -18,2 +18,4 @@
Searx è un metamotore, significa che aggrega i risultati di altri motori di ricerca e lo fa senza salvare informazioni sugli utenti.
Disroot's Search è un motore di ricerca come Google, DuckDuckGo e Qwant, alimentato da **SearXNG**. Ciò che lo rende unico rispetto agli altri è che si tratta di un motore di metaricerca, che aggrega i risultati di altri motori di ricerca senza memorizzare alcuna informazione sui suoi utenti.
floss4good commented 2024-04-24 11:01:19 +02:00
Contributor
Copy Link

The last_modified date from translation banner should probably be updated.

The `last_modified` date from translation banner should probably be updated.
meaz marked this conversation as resolved
floss4good commented 2024-04-24 11:16:36 +02:00
Contributor
Copy Link

No it doesn't make sense indeed.

Since pages/03.services/10.upload/_lufi-how/de/lufi-drop.png was deleted, pages/03.services/10.upload/_lufi-how/2col.de.md should now be updated to use the en/lufi-drop.png screenshot.

BTW: there are other similar cases (e.g. pages/03.services/03.nextcloud/_nextcloud-cals/de), but maybe it would be better to handle them into separate PR/s, since this one is getting quite big and hard to review; or just make sure to handle them while working on the new website.

> No it doesn't make sense indeed. Since pages/03.services/10.upload/_lufi-how/de/lufi-drop.png was deleted, pages/03.services/10.upload/_lufi-how/2col.de.md should now be updated to use the en/lufi-drop.png screenshot. BTW: there are other similar cases (e.g. pages/03.services/03.nextcloud/_nextcloud-cals/de), but maybe it would be better to handle them into separate PR/s, since this one is getting quite big and hard to review; or just make sure to handle them while working on the new website.
fede added 1 commit 2024-04-24 14:25:34 +02:00
fede approved these changes 2024-04-24 14:35:51 +02:00
Dismissed
meaz added 1 commit 2024-04-24 22:48:01 +02:00
meaz commented 2024-04-24 22:48:54 +02:00
Author
Owner
Copy Link

BTW: there are other similar cases (e.g. pages/03.services/03.nextcloud/_nextcloud-cals/de), but maybe it would be better to handle them into separate PR/s, since this one is getting quite big and hard to review; or just make sure to handle them while working on the new website.

As I was on it I corrected those also :) So we're good normally. If you don't see anything left I might have overlooked, let me know so that I can merge this @floss4good Thanks again!

> BTW: there are other similar cases (e.g. pages/03.services/03.nextcloud/_nextcloud-cals/de), but maybe it would be better to handle them into separate PR/s, since this one is getting quite big and hard to review; or just make sure to handle them while working on the new website. As I was on it I corrected those also :) So we're good normally. If you don't see anything left I might have overlooked, let me know so that I can merge this @floss4good Thanks again!
fede approved these changes 2024-04-25 00:37:20 +02:00
meaz merged commit ec69c7d177 into main 2024-04-25 11:10:42 +02:00
meaz deleted branch update_cleanup 2024-04-25 11:10:42 +02:00
floss4good commented 2024-04-25 21:33:01 +02:00
Contributor
Copy Link

If you don't see anything left I might have overlooked, let me know so that I can merge this @floss4good Thanks again!

You're welcome, @meaz. And sorry for not being able to check this earlier.
If I have any other suggestion I will open a new issue/PR.

> If you don't see anything left I might have overlooked, let me know so that I can merge this @floss4good Thanks again! You're welcome, @meaz. And sorry for not being able to check this earlier. If I have any other suggestion I will open a new issue/PR.
Sign in to join this conversation.
Reviewers
No reviewers
fede
Labels
Clear labels   
ABOUT

About page related

  
BLOG

Blogpost / Blog page related

  
COMMUNITY

Community page related

  
CONTACT

Contact page related

  
DONATIONS

Donations page related

  
FAQ

FAQ related

  
FIX

   
FORM

Form related

  
REVISION

   
SERVICES

Services page related

  
TRANSLATION

Files/Text translation

  
TYPO

Text errors

  
UPDATE
No Label
ABOUT
BLOG
COMMUNITY
CONTACT
DONATIONS
FAQ
FIX
FORM
REVISION
SERVICES
TRANSLATION
TYPO
UPDATE
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
antilopa
avg_joe
fede
muppeth
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/Website#479
No description provided.
Delete Branch "update_cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?