Disroot/Website
14
17
Fork 16
Code Pull requests 6 Releases Activity

domain linking form #5

Merged
muppeth merged 6 commits from domain-linking-form into master 2019-10-16 19:15:00 +02:00
Conversation 10 Commits 6 Files changed 1 +16 -9
fede commented 2019-10-12 00:19:59 +02:00
Owner
Copy link
No description provided.
antilopa was assigned by fede 2019-10-12 00:19:59 +02:00
muppeth was assigned by fede 2019-10-12 00:19:59 +02:00
meaz was assigned by fede 2019-10-12 00:19:59 +02:00
fede self-assigned this 2019-10-12 00:19:59 +02:00
maryjane was assigned by fede 2019-10-12 00:19:59 +02:00
fede added the
REVISION
FORM
 labels 2019-10-12 00:19:59 +02:00
meaz commented 2019-10-14 00:26:43 +02:00
Owner
Copy link

For "amount" we should perhaps add a list of currency that users could choose from. I remember in tickets that sometimes we know that a user gave 5, but we don't know if it's in $, € or whatever currency they use.

For "amount" we should perhaps add a list of currency that users could choose from. I remember in tickets that sometimes we know that a user gave 5, but we don't know if it's in $, € or whatever currency they use.
👍 1
meaz commented 2019-10-14 00:28:18 +02:00
Owner
Copy link

Also, for placeholder: 'Name of payment holder or other transfer reference', the text is a bit long, so we don't see it all.

Also, for placeholder: 'Name of payment holder or other transfer reference', the text is a bit long, so we don't see it all.
fede commented 2019-10-14 00:47:05 +02:00
Author
Owner
Copy link

Yes, it is indeed a bit long, though I'm not sure about how to make it short and descriptive enough.

Yes, it is indeed a bit long, though I'm not sure about how to make it short and descriptive enough.
meaz commented 2019-10-14 00:48:46 +02:00
Owner
Copy link

perhaps it ould be set under the title of the box, not in the box. ANd in the ox, we just write "Reference of payment"

perhaps it ould be set under the title of the box, not in the box. ANd in the ox, we just write "Reference of payment"
👍 1
muppeth commented 2019-10-14 00:56:55 +02:00
Owner
Copy link

I just pushed some changes to the form text. Please review.
(screenshot attached)

I just pushed some changes to the form text. Please review. (screenshot attached)
Screenshot from 2019-10-14 00-57-13.png
113 KiB
Screenshot from 2019-10-14 00-57-13.png
👍 1
meaz commented 2019-10-14 01:01:39 +02:00
Owner
Copy link

seems fine to me

seems fine to me
meaz approved these changes 2019-10-14 01:10:25 +02:00
meaz left a comment
Owner
Copy link

perhaps there are a bit too many

perhaps there are a bit too many <br>
fede commented 2019-10-14 14:35:22 +02:00
Author
Owner
Copy link

I think we can merge it.

I think we can merge it.
antilopa commented 2019-10-14 17:12:43 +02:00
Owner
Copy link

I like what you did with the instruction steps muppeth. Let's add on the '2. start donating' the sentence - to see how to donate go to https:disroot.org/donate

I like what you did with the instruction steps muppeth. Let's add on the '2. start donating' the sentence - to see how to donate go to https:disroot.org/donate
muppeth commented 2019-10-14 17:35:22 +02:00
Owner
Copy link

like this? (check latest commit or attachement)

like this? (check latest commit or attachement)
Screenshot from 2019-10-14 17-34-59.png
45 KiB
Screenshot from 2019-10-14 17-34-59.png
👍 2
muppeth commented 2019-10-16 16:27:04 +02:00
Owner
Copy link

Waiting for one more approval before merging to master.

Waiting for one more approval before merging to master.
antilopa approved these changes 2019-10-16 16:31:53 +02:00
muppeth referenced this pull request from a commit 2019-10-16 19:15:00 +02:00
domain linking form (#5)
muppeth closed this pull request 2019-10-16 19:15:00 +02:00
fede referenced this pull request from a commit 2022-06-16 06:08:21 +02:00
Disnews #5
fede referenced this pull request from a commit 2022-06-17 12:02:17 +02:00
Disnews #5
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ABOUT

About page related

  
BLOG

Blogpost / Blog page related

  
COMMUNITY

Community page related

  
CONTACT

Contact page related

  
DONATIONS

Donations page related

  
FAQ

FAQ related

  
FIX

   
FORM

Form related

  
REVISION

   
SERVICES

Services page related

  
TRANSLATION

Files/Text translation

  
TYPO

Text errors

  
UPDATE
No labels
ABOUT
BLOG
COMMUNITY
CONTACT
DONATIONS
FAQ
FIX
FORM
REVISION
SERVICES
TRANSLATION
TYPO
UPDATE
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
antilopa
muppeth
meaz
fede
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/Website#5
No description provided.
Delete branch "domain-linking-form"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?