Disroot
/
gpg-lacre
9
15
Fork 4
Code Issues 29 Pull Requests 1 Releases 2 Wiki Activity

Extract common part of _encrypt_all_payloads_inline and _generate_message_from_payloads #117

New Issue
Closed
opened 2023-02-19 10:27:00 +01:00 by pfm · 1 comment
pfm commented 2023-02-19 10:27:00 +01:00
Collaborator
Copy Link

Functions _encrypt_all_payloads_inline and _generate_message_from_payloads in lacre.core module have very similar flow: they initialise some structure, process messages recursively and return some result.

This recursive algorithm could be extracted and re-used.

Functions `_encrypt_all_payloads_inline` and `_generate_message_from_payloads` in `lacre.core` module have very similar flow: they initialise some structure, process messages recursively and return some result. This recursive algorithm could be extracted and re-used.
pfm added the
CODE
IDEA
 labels 2023-02-19 10:27:00 +01:00
pfm commented 2024-01-05 21:26:15 +01:00
Author
Collaborator
Copy Link

Making this more generic would make code more complex and probably more error prone - closing.

Making this more generic would make code more complex and probably more error prone - closing.
pfm closed this issue 2024-01-05 21:26:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
error-handling
uncoupleFE
fe_theme_st
php_update
muppdev
v0.2.2
v0.2.1
v0.2
v0.2-RC3
v0.2-RC2
v0.2-RC1
PII-2
PII-1
v0.1
v0.1-RC2
v0.1-RC1
failed-tests
Labels
Clear labels   
ANSIBLE

   
BUG

Something that's not working properly

  
CODE

   
DEVELOPMENT

   
DOCUMENTATION

Documentation

  
FEEDBACK

Suggestions and comments

  
FIX

A solution or patch for an issue

  
HOWTOs

Guides and tutorials

  
IDEA

Potential improvements and things to consider when time allows

  
INFRA

   
ISSUE

A problem

  
MAILSERVER

   
TESTS

   
To-Be-Reviewed

We should discuss these issues and decide what to do about them. They are candidates to be closed without further action or their scope might change.

  
WEB

   
WEBSITE

Lacre website related

No Label
ANSIBLE
BUG
CODE
DEVELOPMENT
DOCUMENTATION
FEEDBACK
FIX
HOWTOs
IDEA
INFRA
ISSUE
MAILSERVER
TESTS
To-Be-Reviewed
WEB
WEBSITE
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/gpg-lacre#117
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?