Disroot
/
gpg-lacre
9
15
Fork 4
Code Issues 29 Pull Requests 1 Releases 2 Wiki Activity

Improve logging and configuration #65

Merged
pfm merged 12 commits from logging-and-config into master 2022-05-13 22:01:11 +02:00
Conversation 1 Commits 12 Files Changed 13 +421 -258
pfm commented 2022-04-10 19:43:19 +02:00
Collaborator
Copy Link
  • Use logging Python package instead of custom file-based code.
  • Move configuration to a separate module and make it more coherent.
- Use logging Python package instead of custom file-based code. - Move configuration to a separate module and make it more coherent.
pfm added 4 commits 2022-04-10 19:43:20 +02:00
82c79ead69 Extract config, separate logging, split into smaller functions 
- Move configuration-processing code to a separate module (lacre.config) and
  provide a simple API to access configuration parameters.
- Prepare to use builtin logging module to log diagnostic data.
- Rework the configuration-processing file to make it cleaner.
- Log additional information while processing configuration.
- Reorder functions.
99cb07b015 Use logging module 
- Replace custom logging code with calls to logging module.
- Use logging.config to provide configuration parameters.

To make Lacre's logging more flexible, use fileConfig from logging.config to
set up all parameters.  If the configuration file is missing, use dictConfig
with hardcoded reasonable defaults.
pfm commented 2022-04-10 19:47:29 +02:00
Author
Collaborator
Copy Link

This PR takes care of #50 and #55.

This PR takes care of #50 and #55.
pfm added 1 commit 2022-04-12 21:44:59 +02:00
pfm added 1 commit 2022-04-24 22:31:04 +02:00
pfm force-pushed logging-and-config from f9629c3938 to 9dfc447169 2022-05-06 20:18:04 +02:00 Compare
pfm added 2 commits 2022-05-06 20:41:46 +02:00
pfm added 1 commit 2022-05-11 19:16:53 +02:00
pfm added 1 commit 2022-05-11 19:57:54 +02:00
pfm added 1 commit 2022-05-13 21:28:54 +02:00
11b78ce0fb Adjust log entry levels for severe conditions 
When Lacre is misconfigured or can't proceed, report WARNING or even ERROR
level messages.
pfm added 1 commit 2022-05-13 21:57:56 +02:00
pfm merged commit 5639d8e5b6 into master 2022-05-13 22:01:11 +02:00
pfm deleted branch logging-and-config 2022-05-13 22:01:11 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ANSIBLE

   
BUG

Something that's not working properly

  
CODE

   
DEVELOPMENT

   
DOCUMENTATION

Documentation

  
FEEDBACK

Suggestions and comments

  
FIX

A solution or patch for an issue

  
HOWTOs

Guides and tutorials

  
IDEA

Potential improvements and things to consider when time allows

  
INFRA

   
ISSUE

A problem

  
MAILSERVER

   
TESTS

   
To-Be-Reviewed

We should discuss these issues and decide what to do about them. They are candidates to be closed without further action or their scope might change.

  
WEB

   
WEBSITE

Lacre website related

No Label
ANSIBLE
BUG
CODE
DEVELOPMENT
DOCUMENTATION
FEEDBACK
FIX
HOWTOs
IDEA
INFRA
ISSUE
MAILSERVER
TESTS
To-Be-Reviewed
WEB
WEBSITE
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/gpg-lacre#65
No description provided.
Delete Branch "logging-and-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?