Unable to send emails to addresses with delimiter #87

New Issue

Closed

opened 2022-06-02 23:52:53 +02:00 by muppeth · 1 comment

muppeth commented

2022-06-02 23:52:53 +02:00

Owner

When sending to lacre'ed address using delimiter, email gets bounced back to sender with error:

Diagnostic-Code: x-unix; Traceback (most recent call last):   File
    "/opt/gpg-lacre/gpg-mailgate.py", line 434, in <module>
    sort_recipients(raw_message, from_addr, to_addrs)   File
    "/opt/gpg-lacre/gpg-mailgate.py", line 409, in sort_recipients
    recipients_left = smime_encrypt(raw_message, recipients_left)   File
    "/opt/gpg-lacre/gpg-mailgate.py", line 275, in smime_encrypt
    cert_and_email = get_cert_for_email(addr, cert_path)   File
    "/opt/gpg-lacre/gpg-mailgate.py", line 334, in get_cert_for_email
    return get_cert_for_email(fixed_up_email) TypeError: get_cert_for_email()
    missing 1 required positional argument: 'cert_path'

When sending to lacre'ed address using delimiter, email gets bounced back to sender with error: ``` Diagnostic-Code: x-unix; Traceback (most recent call last): File "/opt/gpg-lacre/gpg-mailgate.py", line 434, in <module> sort_recipients(raw_message, from_addr, to_addrs) File "/opt/gpg-lacre/gpg-mailgate.py", line 409, in sort_recipients recipients_left = smime_encrypt(raw_message, recipients_left) File "/opt/gpg-lacre/gpg-mailgate.py", line 275, in smime_encrypt cert_and_email = get_cert_for_email(addr, cert_path) File "/opt/gpg-lacre/gpg-mailgate.py", line 334, in get_cert_for_email return get_cert_for_email(fixed_up_email) TypeError: get_cert_for_email() missing 1 required positional argument: 'cert_path' ```

muppeth added the

BUG

CODE

labels 2022-06-02 23:52:53 +02:00

muppeth referenced this issue

2022-06-02 23:55:03 +02:00

[User story] - As a user I would like to be able to send new public key after previously sent and confirmed key has been compromised or lost. #85

muppeth referenced this issue

2022-06-02 23:58:57 +02:00

option to skip encryption #74

pfm commented

2022-06-03 00:18:42 +02:00

Collaborator

First findings:

Only S/MIME encryption supports delimiters, OpenPGP/GnuPGP doesn't.
Function get_cert_for_email is called without second argument, which is mandatory.

Suggestion from @muppeth:

i think we should encrypt delimiter emails. otherwise it creates confusion. so perhaps lacre could by defualt strip down +whatever from email and encrypt using users email

First findings: * Only S/MIME encryption supports delimiters, OpenPGP/GnuPGP doesn't. * Function `get_cert_for_email` is called without second argument, which is mandatory. Suggestion from @muppeth: > i think we should encrypt delimiter emails. otherwise it creates confusion. so perhaps lacre could by defualt strip down +whatever from email and encrypt using users email