Disroot/gpg-lacre

Fork 4

Fix unencrypted delivery and key removal #130

Merged

pfm merged 40 commits from 129-key-removal into main

2023-12-02 21:59:15 +01:00

pfm commented

2023-09-21 20:24:24 +02:00

Collaborator

Expected to fix !129.

pfm added 3 commits 2023-09-21 20:24:25 +02:00

Fix unencrypted delivery arguments fccabc083c

When falling back to unencrypted mail delivery, do not pass sender information
to SendFrom.call method.

Ensure correct logging initialisation in webgate-cron 6c114b6dcd

GnuPG: clean up and collect more diagnostic info 624a335a41

- Use regular expressions instead of finding particular characters in gnupg
  output to decide whether confirmation line was found.

- Use tempfile.mkdtemp to create secure temporary directories.

- Record information about the key considered by GnuPG. When missing in
  exception, it means no key was found.

pfm self-assigned this 2023-09-21 20:24:32 +02:00

pfm added 1 commit 2023-09-25 19:44:33 +02:00

Update Alice's key expiry date c570bcd383

pfm added 5 commits 2023-10-23 22:48:26 +02:00

Always use 'python' binary during tests 274bfbaf3b

Add basic support for RDBMS-based keyring 41442e5b59

Fix DatabaseKeyring tests 43f43a4137

Improve asyncio usage e5339d264c

Initialise db connection lazily, use isolated asyncio test case 3dd6913599

pfm added 1 commit 2023-10-27 23:54:06 +02:00

Validate keyring type config parameter on daemon startup 02edb4cc96

pfm added 6 commits 2023-11-15 20:38:29 +01:00

Replace file-based identity store with a dedicated db table 5e108c189a

Don't require watchdog anymore bf677585be

Extract parts of cron script to modules 9bbc86bc53

Introduce new Python modules:

- lacre.notify -- to send notifications from the cron script;

- lacre.dbschema -- to keep database schema definition as code (SQLAlchemy);

- lacre.repositories -- to define key and identity repositories with high
  level APIs that we can then use elsewhere.

Also:

- rework GnuPG.add_key to return fingerprint so we can use it in the cron
  script;

- rename cron-job's logger name, replacing dash with an underscore as logging
  module doesn't like dashes.

Issue an INFO log entry after configuring logging 6ca5db2db3

Also: reformat with spaces instead of tabs.

Use lacre.dbschema definition of identities table 2edd842f90

Remove duplicate logger initialisation a3eb892df9

pfm added 2 commits 2023-11-17 22:56:04 +01:00

Handle gpg-mailgate.py missing params better 7ac928af76

Add docs, improve logging c6b2dbf618

pfm added 4 commits 2023-11-20 22:12:23 +01:00

Don't require less-than and greater-than around the email 4fbae908d6

Keys don't have to be surrounded with less-than and greater-than characters,
so this code could mishandle valid keys.

Refactor calculating execution time 56da7e0cb4

- Implement a context manager logging execution time.
- Use that context manager in daemon's handle_DATA method.

Implement identity repository bfa2643dc7

Also: rename key_id to fingerprint.

Add tests for GnuPG parsing routines 89affde0d5

pfm added 1 commit 2023-11-20 22:28:14 +01:00

Fix table name, unify metadata handling 5efef3c9cb

pfm added 4 commits 2023-11-25 01:14:13 +01:00

Make IdentityRepository a KeyRing 7c2d32bf3c

- Keep only one class to provide access to identities stored in the database.

- Remove old code and its tests.

- Align KeyRing and IdentityRepository APIs.

- Implement a (very) simple unit test for IdentityRepository.

GnuPG module: make key-listing more thorough 72217e38ea

- Flush key-collecting structures each time a new public key entry is found.
  This will avoid adding sub-keys and overwriting main keys with them.

- Use parseaddr from email.utils to parse emails (and drop realname part).

- Record logs produced during unit tests.

- Fix a small bug in test code.

Also: add basic information about available test identities to testing
documentation.

Fix inheritance issues acd33fec1e

- Use accessor methods.
- Avoid data duplication.

Keep secondary keyring for test purposes 4950e0b9c3

pfm added 2 commits 2023-11-25 14:08:06 +01:00

Clean up database access becb39f139

- Don't pass table definitions to repository constructors.

- Keep an internal reference to Engine in lacre.repository.

- Implement KeyConfirmationQueue.count_keys.

Implement lacre.admin CLI tool 1ad0d2df0e

pfm added 3 commits 2023-11-25 15:10:07 +01:00

Don't pass table definition to KeyConfirmationQueue 7fe52ae8b5

Fix crontest config, polish Makefile 9b5c43b769

Add test/lacre.db to gitignore 95c5802c38

pfm added 2 commits 2023-11-25 16:11:25 +01:00

lacre.admin: Implement 'identities' sub-command 626fce5f2c

lacre.repositories: Fix naming after refactoring 97c4f9f14a

pfm commented

2023-11-26 10:34:59 +01:00

Author

Collaborator

This change depends on Lacre/lacre-webgate#11.

pfm added 3 commits 2023-11-26 18:32:31 +01:00

Replace NBSP in doc/admin.md with a regular space aa8c353a05

Make GnuPG.public_keys docstring more complete 0fe5e6b3dc

lacre.admin: Implement identity import, fix identity list b44bd7b150

- Let the user specify a directory, using the one from configuration by
  default.

- If user requested identity list without a specific email, list all.  Drop
  support for '-a' option.

pfm added 2 commits 2023-12-02 21:19:19 +01:00

lacre.admin: Handle database exceptions 0975ce3a69

Change table prefix from 'gpgmw' to 'lacre' 052551072e

pfm added 1 commit 2023-12-02 21:48:31 +01:00

Remove configuration options no longer used ac5dddfa98

pfm merged commit b7713207ab into main

2023-12-02 21:59:15 +01:00

pfm deleted branch 129-key-removal

2023-12-02 21:59:16 +01:00

pfm referenced this pull request from a commit

2023-12-02 21:59:16 +01:00

Merge pull request 'Fix unencrypted delivery and key removal' (#130) from 129-key-removal into main