Disroot/gpg-lacre
8
15
Fork 4
Code Issues 34 Pull requests 1 Releases 3 Wiki Activity

lacre.repositories: Configure SQLAlchemy connection pooling #136

Merged
pfm merged 8 commits from connection-pooling into main 2024-01-04 19:52:04 +01:00
Conversation 0 Commits 8 Files changed 14 +207 -72
pfm commented 2023-12-16 23:35:45 +01:00
Collaborator
Copy link

Provide 3 new configuration parameters in database section:

  • max_connection_age --- number of seconds before an idle connection is
    "recycled", i.e. replaced with a new one;

  • pool_size --- number of simultaneous connections kept in the pool;

  • max_overflow --- maximum number of simultaneous connections we could make to
    the database.

Update sample config, including links to documentation.

Provide 3 new configuration parameters in database section: - max_connection_age --- number of seconds before an idle connection is "recycled", i.e. replaced with a new one; - pool_size --- number of simultaneous connections kept in the pool; - max_overflow --- maximum number of simultaneous connections we could make to the database. Update sample config, including links to documentation.
pfm added 1 commit 2023-12-16 23:35:46 +01:00 
Provide 3 new configuration parameters in database section:

- max_connection_age --- number of seconds before an idle connection is
  "recycled", i.e. replaced with a new one;

- pool_size --- number of simultaneous connections kept in the pool;

- max_overflow --- maximum number of simultaneous connections we could make to
  the database.

Update sample config, including links to documentation.
pfm added 1 commit 2023-12-17 14:07:18 +01:00 
- Provide a new reuqired parameter: [database]pooling_mode and use it during
  SQLAlchemy engine initialisation.

- Update tests and configuration (including sample configuration).

- Adjust repository unit test to load config during setup.

- Pass an engine instance to repository constructors instead of connections.
  Engine keeps a connection pool and we rely on it.
pfm added 1 commit 2023-12-17 14:13:12 +01:00
pfm added 1 commit 2023-12-17 20:43:44 +01:00 
Also: use PGPStyle in lacre.core.
pfm added 1 commit 2023-12-19 09:03:07 +01:00
pfm added 1 commit 2023-12-19 18:21:23 +01:00
pfm added 1 commit 2023-12-20 23:03:40 +01:00 
- Don't re-configure lacre.notify logger.
- Issue more DEBUG logs when deleting keys.
pfm added 1 commit 2024-01-04 19:45:43 +01:00
pfm merged commit 748fd00957 into main 2024-01-04 19:52:04 +01:00
pfm deleted branch connection-pooling 2024-01-04 19:52:04 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ANSIBLE

   
BUG

Something that's not working properly

  
CODE

   
DEVELOPMENT

   
DOCUMENTATION

Documentation

  
FEEDBACK

Suggestions and comments

  
FIX

A solution or patch for an issue

  
HOWTOs

Guides and tutorials

  
IDEA

Potential improvements and things to consider when time allows

  
INFRA

   
ISSUE

A problem

  
MAILSERVER

   
TESTS

   
To-Be-Reviewed

We should discuss these issues and decide what to do about them. They are candidates to be closed without further action or their scope might change.

  
WEB

   
WEBSITE

Lacre website related

No labels
ANSIBLE
BUG
CODE
DEVELOPMENT
DOCUMENTATION
FEEDBACK
FIX
HOWTOs
IDEA
INFRA
ISSUE
MAILSERVER
TESTS
To-Be-Reviewed
WEB
WEBSITE
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/gpg-lacre#136
No description provided.
Delete branch "connection-pooling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?