Disroot/gpg-lacre

Fork 4

Improve error handling #152

Merged

pfm merged 14 commits from error-handling into main

2024-08-23 14:30:02 +02:00

pfm commented

2024-05-26 12:21:50 +02:00

Collaborator

Depending on the type of processing error, return either 451 or 554 code to distinguish between transient and permanent errors.

Correct key queue clean-up process to remove keys not confirmed within expected time window.

Also:

Document key life-cycle.
Upgrade SQLAlchemy to 2.x (see #151).

Depending on the type of processing error, return either 451 or 554 code to distinguish between transient and permanent errors. Correct key queue clean-up process to remove keys not confirmed within expected time window. Also: - Document key life-cycle. - Upgrade SQLAlchemy to 2.x (see #151).

pfm added 10 commits 2024-05-26 12:21:51 +02:00

Fix a typo in bouncing, wrap UnicodeEncodeError in custom exception b67a2744cd

Improve error-handling and error-reporting deb0d32aa1

1. Log the full traceback only once for each error (when we bounce the
message).

2. Use 451 response code on processing failure.

3. Disable decoding message contents as we operate on raw data anyway.

Improve delivery error-handling 6754ca065d

- Introduce exceptions to be raised upon transient and permanent delivery
failures, as specified by SMTP RFC.  Depending on type of failure, return
either 451 or 554 reply code.

- When serialising a message, treat ValueError as a serialisation issue (and
try again to deliver in cleartext).

Document key lifecycle ad85c5dc0d

When cleaning up after cron-job, remove expired queue items 4c1853dd8a

- Implement KeyConfirmationQueue.delete_expired_queue_items to delete items
older than a given number of hours.

- Introduce configuration parameter to specify maximum number of hours.  It
defaults to 1 hour.

- Update documentation to explain that we never assign ST_TO_BE_DELETED.

Extract expiry calculation from KeyConfirmationQueue e28d3ecfae

Only expire KeyConfirmationQueue items that haven't been confirmed f24994a2b8

Upgrade SQLAlchemy, enable warning capturing 9ecdb17e42

Add contract tests for headers-only parsing of email messages 21a9021d41

Add header-only parser and minor test improvements bc005161c1

pfm added 2 commits 2024-07-12 10:42:26 +02:00

Improve tests f1211db549

- Always default to 'python' if PYTHON env. var. unset.
- Enable SQLAlchemy warnings in daemon tests.
- Commit changes in schema initialisation script.

Implement LazyMessage, a wrapper for original contents 87d7400070

We want to avoid deserialising message contents, because Python's email module
might produce different representation than the MUA sending original message.
The result would be a transformed message, which could mean broken message in
certain conditions.

pfm added 1 commit 2024-07-12 20:31:06 +02:00

Do not touch original payload in KeepIntact mode 0405172085

pfm commented

2024-07-26 14:49:43 +02:00

Author

Collaborator

This PR also includes changes for #153.

pfm added 1 commit 2024-07-26 15:35:52 +02:00

Update expected cleartext output b07ef35b01

Lacre no longer transforms cleartext payloads.

pfm force-pushed error-handling from b07ef35b01 to ba23eeb8b3

2024-08-23 14:16:56 +02:00

Compare

pfm merged commit 58a7117bb9 into main

2024-08-23 14:30:02 +02:00

pfm deleted branch error-handling

2024-08-23 14:30:02 +02:00

pfm referenced this pull request from a commit

2024-08-23 14:30:04 +02:00

Merge pull request 'Improve error handling' (#152) from error-handling into main

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Disroot/gpg-lacre#152

No description provided.