Disroot-themes/grav-theme-disroot
Disroot-themes
/
grav-theme-disroot
7
2
Fork 0
Code Pull Requests Releases Activity

banner for translation #55

Merged
meaz merged 6 commits from banner_translation into master 2022-03-18 15:38:45 +01:00
Conversation 3 Commits 6 Files Changed 5 +64 -18
meaz commented 2021-12-28 11:20:32 +01:00
Owner
Copy Link

Creates a banner on translated page as requested in Disroot/Disroot-Project#147

To used a banner, you simply need to modify modular.en.md in the website repo, so for example pages/05.community/modular.en.md and add:

translation_banner:
    set: true
    last_modified: December 2021
    language: German

Set: you can disable it, for example on English page.
last_modified: pretty obvious...
language: set the language of the banner text, so here the German version would appear.

See attached preview

What has to be done:

  • Agree on text

  • Agree on design / colors

  • Translate agreed text

While I was working on this, I also found some not related errors that I corrected.

Creates a banner on translated page as requested in https://git.disroot.org/Disroot/Disroot-Project/issues/147 To used a banner, you simply need to modify `modular.en.md` in the website repo, so for example `pages/05.community/modular.en.md` and add: ``` translation_banner: set: true last_modified: December 2021 language: German ``` `Set`: you can disable it, for example on English page. `last_modified`: pretty obvious... `language`: set the language of the banner text, so here the German version would appear. See attached preview What has to be done: - [ ] Agree on text - [ ] Agree on design / colors - [ ] Translate agreed text While I was working on this, I also found some not related errors that I corrected.
preview_banner.png
502 KiB
preview_banner.png
muppeth was assigned by meaz 2021-12-28 11:20:32 +01:00
meaz self-assigned this 2021-12-28 11:20:33 +01:00
fede was assigned by meaz 2021-12-28 11:20:33 +01:00
antilopa was assigned by meaz 2021-12-28 11:20:33 +01:00
avg_joe was assigned by meaz 2021-12-28 11:20:33 +01:00
meaz added 4 commits 2021-12-28 11:20:34 +01:00
meaz commented 2022-01-26 21:52:49 +01:00
Author
Owner
Copy Link

what do you think of this @muppeth @antilopa @avg_joe and @fede ?

what do you think of this @muppeth @antilopa @avg_joe and @fede ?
antilopa commented 2022-01-28 20:54:36 +01:00
Owner
Copy Link

I think the banner in the screenshot looks good, from my point of view, we can implement it

I think the banner in the screenshot looks good, from my point of view, we can implement it
meaz changed title from [WIP] banner for translation to banner for translation 2022-01-31 20:12:43 +01:00
meaz added 1 commit 2022-01-31 20:12:52 +01:00
meaz changed title from banner for translation to [WIP] banner for translation 2022-01-31 20:13:20 +01:00
meaz commented 2022-02-07 06:51:11 +01:00
Author
Owner
Copy Link

@fede @muppeth what do you think? If it is ok for you to, then I'll implement it everywhere.

@fede @muppeth what do you think? If it is ok for you to, then I'll implement it everywhere.
antilopa approved these changes 2022-03-15 17:01:15 +01:00
meaz changed title from [WIP] banner for translation to banner for translation 2022-03-18 15:36:29 +01:00
meaz added 1 commit 2022-03-18 15:36:46 +01:00
meaz merged commit 14264695a8 into master 2022-03-18 15:38:45 +01:00
meaz referenced this issue from a commit 2022-03-18 15:38:45 +01:00
banner for translation (#55)
Sign in to join this conversation.
Reviewers
No reviewers
antilopa
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
muppeth
meaz
fede
antilopa
avg_joe
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-themes/grav-theme-disroot#55
No description provided.
Delete Branch "banner_translation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?