adding a footer for blog section. #1

Merged
meaz merged 2 commits from urbasius/grav-theme-disrootblog:add_rss_button_to_blog into master 2020-11-15 06:26:20 +00:00
Contributor

Not sure about my solution. Is it enough? I did some testing for phones and tablets. I tried to have it pixel perfect like the current disroot.org page. However, I am not happy about {% set base_url = page.parent.url %} in footer.html.twig, so please review it and let's have a discussion.

Not sure about my solution. Is it enough? I did some testing for phones and tablets. I tried to have it pixel perfect like the current disroot.org page. However, I am not happy about {% set base_url = page.parent.url %} in footer.html.twig, so please review it and let's have a discussion.
Owner

Before I can merge it, can you add de, fr, es, it folders from
https://git.disroot.org/Disroot/grav-theme-disroot/src/branch/master/templates

into templates folder ?

Before I can merge it, can you add de, fr, es, it folders from https://git.disroot.org/Disroot/grav-theme-disroot/src/branch/master/templates into templates folder ?
meaz approved these changes 2020-11-01 08:16:01 +00:00
antilopa was assigned by meaz 2020-11-01 08:16:11 +00:00
meaz merged commit 3523d1441c into master 2020-11-15 06:26:19 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-themes/grav-theme-disrootblog#1
No description provided.