Disroot-themes
/
grav-theme-disrootblog
6
2
Fork 2
Code Pull Requests Releases Activity

fix links in footer for all languages #3

Merged
meaz merged 2 commits from footer_internat into master 2021-04-10 09:22:31 +02:00
Conversation 4 Commits 2 Files Changed 6 +27 -87
meaz commented 2021-04-09 09:17:47 +02:00
Owner
Copy Link

add @antilopa 's recent changes to other languages

add @antilopa 's recent changes to other languages
muppeth was assigned by meaz 2021-04-09 09:17:47 +02:00
fede was assigned by meaz 2021-04-09 09:17:47 +02:00
antilopa was assigned by meaz 2021-04-09 09:17:47 +02:00
meaz added 1 commit 2021-04-09 09:17:49 +02:00
meaz commented 2021-04-09 09:18:33 +02:00
Author
Owner
Copy Link

see Disroot/Website#219 (comment)

see https://git.disroot.org/Disroot/Website/issues/219#issuecomment-5281
fede approved these changes 2021-04-09 15:17:59 +02:00
muppeth commented 2021-04-09 15:23:51 +02:00
Owner
Copy Link

Do we actually need different versions per language? Shouldn't just creating templates/partials/footer.html.twig be enough?

Do we actually need different versions per language? Shouldn't just creating `templates/partials/footer.html.twig` be enough?
meaz commented 2021-04-09 19:28:58 +02:00
Author
Owner
Copy Link

As you have some strings in footer.html.twig like "Terms Of Service", the template has to exist in each language you want. Perhaps it is possible to achieve that in another way, but I don't know how. You can check: https://learn.getgrav.org/16/content/multi-language

As you have some strings in footer.html.twig like "Terms Of Service", the template has to exist in each language you want. Perhaps it is possible to achieve that in another way, but I don't know how. You can check: https://learn.getgrav.org/16/content/multi-language
muppeth approved these changes 2021-04-10 00:50:06 +02:00
muppeth left a comment
Owner
Copy Link

Well, as it's not high prio and I won't be able to check this myself (rather use the time for something else) we could approve this but perhaps make an issue in this repo to not forget to check for maybe a nicer fix in the future (we could probably apply it to more stuff).

Well, as it's not high prio and I won't be able to check this myself (rather use the time for something else) we could approve this but perhaps make an issue in this repo to not forget to check for maybe a nicer fix in the future (we could probably apply it to more stuff).
meaz added 1 commit 2021-04-10 09:20:50 +02:00
meaz commented 2021-04-10 09:22:12 +02:00
Author
Owner
Copy Link

I actually find a way ;)

I actually find a way ;)
meaz merged commit cf3d02848f into master 2021-04-10 09:22:31 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fede
muppeth
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
muppeth
fede
antilopa
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-themes/grav-theme-disrootblog#3
No description provided.
Delete Branch "footer_internat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?