From 3364b4738ac20e307c702d341adfa2ed0a298c99 Mon Sep 17 00:00:00 2001 From: M M Arif Date: Fri, 12 Aug 2022 19:04:14 +0500 Subject: [PATCH] Move other listing screens to Material cards view --- .../mian/gitnex/activities/MainActivity.java | 2 +- .../gitnex/adapters/UserAccountsAdapter.java | 2 +- .../mian/gitnex/adapters/WikiListAdapter.java | 2 +- .../mian/gitnex/fragments/DraftsFragment.java | 5 - .../ExplorePublicOrganizationsFragment.java | 3 - .../fragments/ExploreUsersFragment.java | 3 - .../gitnex/fragments/MilestonesFragment.java | 3 - .../fragments/MostVisitedReposFragment.java | 5 - .../fragments/NotificationsFragment.java | 4 - .../mian/gitnex/fragments/WikiFragment.java | 7 - .../layout/custom_user_accounts_dialog.xml | 6 +- app/src/main/res/layout/fragment_drafts.xml | 24 +- .../res/layout/fragment_explore_users.xml | 24 +- .../main/res/layout/fragment_milestones.xml | 24 +- .../res/layout/fragment_notifications.xml | 24 +- .../main/res/layout/fragment_repo_info.xml | 178 +++++------ app/src/main/res/layout/fragment_wiki.xml | 24 +- app/src/main/res/layout/list_drafts.xml | 117 ++++--- app/src/main/res/layout/list_milestones.xml | 286 +++++++++--------- .../res/layout/list_most_visited_repos.xml | 139 +++++---- .../main/res/layout/list_notifications.xml | 145 ++++----- .../main/res/layout/list_user_accounts.xml | 114 ++++--- app/src/main/res/layout/list_wiki.xml | 145 +++++---- 23 files changed, 684 insertions(+), 602 deletions(-) diff --git a/app/src/main/java/org/mian/gitnex/activities/MainActivity.java b/app/src/main/java/org/mian/gitnex/activities/MainActivity.java index bbda8be3..11a61f67 100644 --- a/app/src/main/java/org/mian/gitnex/activities/MainActivity.java +++ b/app/src/main/java/org/mian/gitnex/activities/MainActivity.java @@ -223,7 +223,7 @@ public class MainActivity extends BaseActivity implements NavigationView.OnNavig if(!userAvatarNav.equals("")) { - int avatarRadius = AppUtil.getPixelsFromDensity(ctx, 3); + int avatarRadius = AppUtil.getPixelsFromDensity(ctx, 60); PicassoService.getInstance(ctx).get().load(userAvatarNav).placeholder(R.drawable.loader_animated).transform(new RoundedTransformation(avatarRadius, 0)).resize(160, 160).centerCrop().into(userAvatar); diff --git a/app/src/main/java/org/mian/gitnex/adapters/UserAccountsAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/UserAccountsAdapter.java index 2095609b..8150c016 100644 --- a/app/src/main/java/org/mian/gitnex/adapters/UserAccountsAdapter.java +++ b/app/src/main/java/org/mian/gitnex/adapters/UserAccountsAdapter.java @@ -204,7 +204,7 @@ public class UserAccountsAdapter extends RecyclerView.Adapter new Handler(Looper.getMainLooper()).postDelayed(() -> { diff --git a/app/src/main/java/org/mian/gitnex/fragments/ExplorePublicOrganizationsFragment.java b/app/src/main/java/org/mian/gitnex/fragments/ExplorePublicOrganizationsFragment.java index 5239868b..e0d32f7e 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/ExplorePublicOrganizationsFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/ExplorePublicOrganizationsFragment.java @@ -11,7 +11,6 @@ import android.view.ViewGroup; import androidx.annotation.NonNull; import androidx.annotation.Nullable; import androidx.fragment.app.Fragment; -import androidx.recyclerview.widget.DividerItemDecoration; import androidx.recyclerview.widget.LinearLayoutManager; import org.gitnex.tea4j.v2.models.Organization; import org.mian.gitnex.R; @@ -71,9 +70,7 @@ public class ExplorePublicOrganizationsFragment extends Fragment { } }); - DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(fragmentPublicOrgBinding.recyclerView.getContext(), DividerItemDecoration.VERTICAL); fragmentPublicOrgBinding.recyclerView.setHasFixedSize(true); - fragmentPublicOrgBinding.recyclerView.addItemDecoration(dividerItemDecoration); fragmentPublicOrgBinding.recyclerView.setLayoutManager(new LinearLayoutManager(context)); fragmentPublicOrgBinding.recyclerView.setAdapter(adapter); diff --git a/app/src/main/java/org/mian/gitnex/fragments/ExploreUsersFragment.java b/app/src/main/java/org/mian/gitnex/fragments/ExploreUsersFragment.java index 5a1d97ce..dad7b6ca 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/ExploreUsersFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/ExploreUsersFragment.java @@ -13,7 +13,6 @@ import android.view.ViewGroup; import android.view.inputmethod.EditorInfo; import androidx.annotation.NonNull; import androidx.fragment.app.Fragment; -import androidx.recyclerview.widget.DividerItemDecoration; import androidx.recyclerview.widget.LinearLayoutManager; import org.gitnex.tea4j.v2.models.InlineResponse2001; import org.gitnex.tea4j.v2.models.User; @@ -69,9 +68,7 @@ public class ExploreUsersFragment extends Fragment { } })); - DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(context, DividerItemDecoration.VERTICAL); viewBinding.recyclerViewExploreUsers.setHasFixedSize(true); - viewBinding.recyclerViewExploreUsers.addItemDecoration(dividerItemDecoration); viewBinding.recyclerViewExploreUsers.setLayoutManager(new LinearLayoutManager(context)); viewBinding.recyclerViewExploreUsers.setAdapter(adapter); diff --git a/app/src/main/java/org/mian/gitnex/fragments/MilestonesFragment.java b/app/src/main/java/org/mian/gitnex/fragments/MilestonesFragment.java index f861efe9..69722ffd 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/MilestonesFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/MilestonesFragment.java @@ -15,7 +15,6 @@ import androidx.annotation.NonNull; import androidx.annotation.Nullable; import androidx.fragment.app.Fragment; import androidx.lifecycle.ViewModelProvider; -import androidx.recyclerview.widget.DividerItemDecoration; import androidx.recyclerview.widget.LinearLayoutManager; import org.gitnex.tea4j.v2.models.Milestone; import org.mian.gitnex.R; @@ -71,8 +70,6 @@ public class MilestonesFragment extends Fragment { dataList = new ArrayList<>(); - DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(viewBinding.recyclerView.getContext(), DividerItemDecoration.VERTICAL); - viewBinding.recyclerView.addItemDecoration(dividerItemDecoration); viewBinding.recyclerView.setHasFixedSize(true); viewBinding.recyclerView.setLayoutManager(new LinearLayoutManager(ctx)); diff --git a/app/src/main/java/org/mian/gitnex/fragments/MostVisitedReposFragment.java b/app/src/main/java/org/mian/gitnex/fragments/MostVisitedReposFragment.java index eb32ca1d..bdd1879d 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/MostVisitedReposFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/MostVisitedReposFragment.java @@ -10,7 +10,6 @@ import android.view.ViewGroup; import android.widget.TextView; import androidx.annotation.NonNull; import androidx.fragment.app.Fragment; -import androidx.recyclerview.widget.DividerItemDecoration; import androidx.recyclerview.widget.LinearLayoutManager; import androidx.recyclerview.widget.RecyclerView; import androidx.swiperefreshlayout.widget.SwipeRefreshLayout; @@ -63,10 +62,6 @@ public class MostVisitedReposFragment extends Fragment { mRecyclerView.setHasFixedSize(true); mRecyclerView.setLayoutManager(new LinearLayoutManager(ctx)); - DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(mRecyclerView.getContext(), - DividerItemDecoration.VERTICAL); - mRecyclerView.addItemDecoration(dividerItemDecoration); - adapter = new MostVisitedReposAdapter(mostVisitedReposList); currentActiveAccountId = tinyDb.getInt("currentActiveAccountId"); swipeRefresh.setOnRefreshListener(() -> new Handler(Looper.getMainLooper()).postDelayed(() -> { diff --git a/app/src/main/java/org/mian/gitnex/fragments/NotificationsFragment.java b/app/src/main/java/org/mian/gitnex/fragments/NotificationsFragment.java index 692e92d9..bb1e118a 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/NotificationsFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/NotificationsFragment.java @@ -13,7 +13,6 @@ import android.view.ViewGroup; import androidx.annotation.NonNull; import androidx.annotation.Nullable; import androidx.fragment.app.Fragment; -import androidx.recyclerview.widget.DividerItemDecoration; import androidx.recyclerview.widget.LinearLayoutManager; import androidx.recyclerview.widget.RecyclerView; import org.apache.commons.lang3.StringUtils; @@ -76,12 +75,9 @@ public class NotificationsFragment extends Fragment implements NotificationsAdap LinearLayoutManager linearLayoutManager = new LinearLayoutManager(context); - DividerItemDecoration dividerItemDecoration = new DividerItemDecoration(viewBinding.notifications.getContext(), DividerItemDecoration.VERTICAL); - viewBinding.notifications.setHasFixedSize(true); viewBinding.notifications.setLayoutManager(linearLayoutManager); viewBinding.notifications.setAdapter(notificationsAdapter); - viewBinding.notifications.addItemDecoration(dividerItemDecoration); viewBinding.notifications.addOnScrollListener(new RecyclerView.OnScrollListener() { diff --git a/app/src/main/java/org/mian/gitnex/fragments/WikiFragment.java b/app/src/main/java/org/mian/gitnex/fragments/WikiFragment.java index 4f573c90..cc7fa850 100644 --- a/app/src/main/java/org/mian/gitnex/fragments/WikiFragment.java +++ b/app/src/main/java/org/mian/gitnex/fragments/WikiFragment.java @@ -7,16 +7,12 @@ import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; import androidx.annotation.NonNull; -import androidx.core.content.ContextCompat; import androidx.fragment.app.Fragment; import androidx.lifecycle.ViewModelProvider; import androidx.recyclerview.widget.LinearLayoutManager; -import androidx.recyclerview.widget.RecyclerView; -import org.mian.gitnex.R; import org.mian.gitnex.adapters.WikiListAdapter; import org.mian.gitnex.databinding.FragmentWikiBinding; import org.mian.gitnex.helpers.Constants; -import org.mian.gitnex.helpers.DividerItemDecorator; import org.mian.gitnex.helpers.contexts.RepositoryContext; import org.mian.gitnex.viewmodels.WikiViewModel; @@ -60,9 +56,6 @@ public class WikiFragment extends Fragment { fragmentWikiBinding.recyclerView.setHasFixedSize(true); fragmentWikiBinding.recyclerView.setLayoutManager(new LinearLayoutManager(getContext())); - RecyclerView.ItemDecoration dividerItemDecoration = new DividerItemDecorator(ContextCompat.getDrawable(requireContext(), R.drawable.shape_list_divider)); - fragmentWikiBinding.recyclerView.addItemDecoration(dividerItemDecoration); - fragmentWikiBinding.pullToRefresh.setOnRefreshListener(() -> new Handler(Looper.getMainLooper()).postDelayed(() -> { page = 1; diff --git a/app/src/main/res/layout/custom_user_accounts_dialog.xml b/app/src/main/res/layout/custom_user_accounts_dialog.xml index 311ec30c..fb9a71b2 100644 --- a/app/src/main/res/layout/custom_user_accounts_dialog.xml +++ b/app/src/main/res/layout/custom_user_accounts_dialog.xml @@ -10,14 +10,12 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:padding="16dp"> + android:padding="@dimen/dimen16dp"> + android:layout_height="match_parent" /> diff --git a/app/src/main/res/layout/fragment_drafts.xml b/app/src/main/res/layout/fragment_drafts.xml index 25c2f14d..ae7f80a6 100644 --- a/app/src/main/res/layout/fragment_drafts.xml +++ b/app/src/main/res/layout/fragment_drafts.xml @@ -6,19 +6,25 @@ android:id="@+id/draftsFrame" android:background="?attr/primaryBackgroundColor"> - + android:layout_height="match_parent" + android:background="?attr/primaryBackgroundColor" + android:padding="@dimen/dimen8dp"> - + android:layout_height="wrap_content"> - + + + + + - + android:layout_height="match_parent" + android:background="?attr/primaryBackgroundColor" + android:padding="@dimen/dimen8dp"> - + android:layout_height="match_parent"> - + + + + + diff --git a/app/src/main/res/layout/fragment_milestones.xml b/app/src/main/res/layout/fragment_milestones.xml index ae477874..00a5e3bc 100644 --- a/app/src/main/res/layout/fragment_milestones.xml +++ b/app/src/main/res/layout/fragment_milestones.xml @@ -6,19 +6,25 @@ xmlns:app="http://schemas.android.com/apk/res-auto" tools:context=".activities.RepoDetailActivity"> - + android:layout_height="match_parent" + android:background="?attr/primaryBackgroundColor" + android:padding="@dimen/dimen8dp"> - + android:layout_height="wrap_content"> - + + + + + - + android:layout_height="match_parent" + android:background="?attr/primaryBackgroundColor" + android:padding="@dimen/dimen8dp"> - + android:layout_height="match_parent"> - + + + + + - - - + android:layout_weight="1" + android:background="?android:attr/selectableItemBackgroundBorderless" + android:focusable="true" + android:clickable="true" + android:gravity="center" + android:orientation="vertical"> - + + + + + - + android:layout_weight="1" + android:background="?android:attr/selectableItemBackgroundBorderless" + android:focusable="true" + android:clickable="true" + android:gravity="center" + android:orientation="vertical"> - + - + + + + android:layout_weight="1" + android:background="?android:attr/selectableItemBackgroundBorderless" + android:focusable="true" + android:clickable="true" + android:gravity="center" + android:orientation="vertical"> - + + + + + - + android:layout_weight="1" + android:background="?android:attr/selectableItemBackgroundBorderless" + android:focusable="true" + android:clickable="true" + android:gravity="center" + android:orientation="vertical"> - + - + + - - - - - - - - - diff --git a/app/src/main/res/layout/fragment_wiki.xml b/app/src/main/res/layout/fragment_wiki.xml index 53b50e5e..685b03d1 100644 --- a/app/src/main/res/layout/fragment_wiki.xml +++ b/app/src/main/res/layout/fragment_wiki.xml @@ -6,19 +6,25 @@ xmlns:app="http://schemas.android.com/apk/res-auto" tools:context=".activities.RepoDetailActivity"> - + android:layout_height="match_parent" + android:background="?attr/primaryBackgroundColor" + android:padding="@dimen/dimen8dp"> - + android:layout_height="wrap_content"> - + + + + + - + android:paddingTop="@dimen/dimen4dp" + android:paddingBottom="@dimen/dimen4dp"> - + style="?attr/materialCardViewFilledStyle" + app:cardElevation="@dimen/dimen0dp"> - + android:foreground="?android:attr/selectableItemBackground" + android:background="?attr/materialCardBackgroundColor" + android:padding="@dimen/dimen12dp" + android:orientation="vertical"> - + - + - + - + - + - + + + + + + + + + diff --git a/app/src/main/res/layout/list_milestones.xml b/app/src/main/res/layout/list_milestones.xml index a4bb13ec..aa278012 100644 --- a/app/src/main/res/layout/list_milestones.xml +++ b/app/src/main/res/layout/list_milestones.xml @@ -6,166 +6,174 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:id="@+id/milestoneFrame" - android:background="?attr/primaryBackgroundColor" - android:padding="16dp" - android:orientation="vertical"> + android:paddingTop="@dimen/dimen4dp" + android:paddingBottom="@dimen/dimen4dp"> - + style="?attr/materialCardViewFilledStyle" + app:cardElevation="@dimen/dimen0dp"> + android:foreground="?android:attr/selectableItemBackground" + android:background="?attr/materialCardBackgroundColor" + android:padding="@dimen/dimen12dp" + android:orientation="vertical"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + android:textSize="16sp" /> - + - + + + android:layout_marginTop="10dp" + android:orientation="horizontal"> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + diff --git a/app/src/main/res/layout/list_most_visited_repos.xml b/app/src/main/res/layout/list_most_visited_repos.xml index a1c57fb0..ceb0b83b 100644 --- a/app/src/main/res/layout/list_most_visited_repos.xml +++ b/app/src/main/res/layout/list_most_visited_repos.xml @@ -4,80 +4,97 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?android:attr/selectableItemBackground" - android:focusable="true" android:orientation="vertical" - android:padding="@dimen/dimen16dp"> + android:paddingTop="@dimen/dimen4dp" + android:paddingBottom="@dimen/dimen4dp"> - + style="?attr/materialCardViewFilledStyle" + app:cardElevation="@dimen/dimen0dp"> - - - + android:foreground="?android:attr/selectableItemBackground" + android:background="?attr/materialCardBackgroundColor" + android:padding="@dimen/dimen12dp" + android:orientation="vertical"> - + - + - + - + - + - + - + + + + + + + + + + + diff --git a/app/src/main/res/layout/list_notifications.xml b/app/src/main/res/layout/list_notifications.xml index 522c4108..ad9ffa63 100644 --- a/app/src/main/res/layout/list_notifications.xml +++ b/app/src/main/res/layout/list_notifications.xml @@ -4,100 +4,105 @@ android:id="@+id/frame" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?android:attr/selectableItemBackground" - android:padding="16dp" + android:paddingTop="@dimen/dimen4dp" + android:paddingBottom="@dimen/dimen4dp" android:orientation="horizontal"> - + style="?attr/materialCardViewFilledStyle" + app:cardElevation="@dimen/dimen0dp"> - - - - - - + android:foreground="?android:attr/selectableItemBackground" + android:background="?attr/materialCardBackgroundColor" + android:padding="@dimen/dimen12dp" + android:orientation="horizontal"> - + + + + + + + android:layout_weight="1" + android:orientation="vertical"> - + - + - - - - + - + android:layout_height="match_parent"> + + + + + + - - - + diff --git a/app/src/main/res/layout/list_user_accounts.xml b/app/src/main/res/layout/list_user_accounts.xml index e181c8b0..19ac214f 100644 --- a/app/src/main/res/layout/list_user_accounts.xml +++ b/app/src/main/res/layout/list_user_accounts.xml @@ -1,73 +1,91 @@ + android:paddingTop="@dimen/dimen4dp" + android:paddingBottom="@dimen/dimen4dp"> - - - + style="?attr/materialCardViewFilledStyle" + app:cardElevation="@dimen/dimen0dp"> + android:foreground="?android:attr/selectableItemBackground" + android:background="?attr/materialCardBackgroundColor" + android:padding="@dimen/dimen12dp" + android:orientation="vertical"> - + + + android:orientation="vertical"> - + - + + + + + + + + + + + - - - + diff --git a/app/src/main/res/layout/list_wiki.xml b/app/src/main/res/layout/list_wiki.xml index 346600f3..173ee803 100644 --- a/app/src/main/res/layout/list_wiki.xml +++ b/app/src/main/res/layout/list_wiki.xml @@ -4,81 +4,98 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?android:attr/selectableItemBackground" - android:focusable="true" android:orientation="vertical" - android:padding="16dp"> + android:paddingTop="@dimen/dimen4dp" + android:paddingBottom="@dimen/dimen4dp"> - - - - - - - - - - - - - + style="?attr/materialCardViewFilledStyle" + app:cardElevation="@dimen/dimen0dp"> + android:foreground="?android:attr/selectableItemBackground" + android:background="?attr/materialCardBackgroundColor" + android:padding="@dimen/dimen12dp" + android:orientation="vertical"> - + + + + + + + + + + + + + + + + + + + + + - +