From 23b8301fbf7724b04fdb3b2573af602d0ba7518f Mon Sep 17 00:00:00 2001 From: M M Arif Date: Thu, 15 Apr 2021 17:05:56 +0200 Subject: [PATCH 1/2] Fix repo desc in recyclerview (#896) fixes and clean up Use Authorization.get() minor fixes Fix repo desc in recyclerview Co-authored-by: M M Arif Co-authored-by: opyale Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/896 Reviewed-by: opyale Co-Authored-By: M M Arif Co-Committed-By: M M Arif --- .../java/org/mian/gitnex/activities/MainActivity.java | 1 - .../org/mian/gitnex/activities/RepoDetailActivity.java | 8 +------- .../org/mian/gitnex/activities/RepoForksActivity.java | 2 +- .../java/org/mian/gitnex/adapters/CommitsAdapter.java | 2 -- .../main/java/org/mian/gitnex/adapters/DraftsAdapter.java | 1 + .../mian/gitnex/adapters/ExploreRepositoriesAdapter.java | 6 +++++- .../org/mian/gitnex/adapters/IssueCommentsAdapter.java | 1 - .../java/org/mian/gitnex/adapters/MyReposListAdapter.java | 6 +++++- .../java/org/mian/gitnex/adapters/RepoForksAdapter.java | 6 +++++- .../java/org/mian/gitnex/adapters/ReposListAdapter.java | 6 +++++- .../mian/gitnex/adapters/RepositoriesByOrgAdapter.java | 8 ++++++-- .../org/mian/gitnex/adapters/SearchIssuesAdapter.java | 1 + .../org/mian/gitnex/adapters/StarredReposListAdapter.java | 8 ++++++-- .../org/mian/gitnex/adapters/UserAccountsAdapter.java | 2 ++ 14 files changed, 38 insertions(+), 20 deletions(-) diff --git a/app/src/main/java/org/mian/gitnex/activities/MainActivity.java b/app/src/main/java/org/mian/gitnex/activities/MainActivity.java index 37dc223a..2e6e77e9 100644 --- a/app/src/main/java/org/mian/gitnex/activities/MainActivity.java +++ b/app/src/main/java/org/mian/gitnex/activities/MainActivity.java @@ -231,7 +231,6 @@ public class MainActivity extends BaseActivity implements NavigationView.OnNavig drawer.addDrawerListener(toggle); drawer.addDrawerListener(new DrawerLayout.DrawerListener() { - @Override public void onDrawerOpened(@NonNull View drawerView) { diff --git a/app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java b/app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java index 1022d0e8..31442285 100644 --- a/app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java +++ b/app/src/main/java/org/mian/gitnex/activities/RepoDetailActivity.java @@ -71,9 +71,6 @@ public class RepoDetailActivity extends BaseActivity implements BottomSheetRepoF private FragmentRefreshListenerMilestone fragmentRefreshListenerMilestone; private FragmentRefreshListenerFiles fragmentRefreshListenerFiles; - private String loginUid; - private String instanceToken; - private String repositoryOwner; private String repositoryName; @@ -108,9 +105,6 @@ public class RepoDetailActivity extends BaseActivity implements BottomSheetRepoF Objects.requireNonNull(getSupportActionBar()).setTitle(repositoryName); getSupportActionBar().setDisplayHomeAsUpEnabled(true); - loginUid = tinyDB.getString("loginUid"); - instanceToken = "token " + tinyDB.getString(loginUid + "-token"); - tinyDB.putString("repoIssuesState", "open"); tinyDB.putString("repoPrState", "open"); tinyDB.putString("milestoneState", "open"); @@ -433,7 +427,7 @@ public class RepoDetailActivity extends BaseActivity implements BottomSheetRepoF Call> call = RetrofitClient .getApiInterface(ctx) - .getBranches(instanceToken, repositoryOwner, repositoryName); + .getBranches(Authorization.get(ctx), repositoryOwner, repositoryName); call.enqueue(new Callback>() { diff --git a/app/src/main/java/org/mian/gitnex/activities/RepoForksActivity.java b/app/src/main/java/org/mian/gitnex/activities/RepoForksActivity.java index f16cee4c..0789e96c 100644 --- a/app/src/main/java/org/mian/gitnex/activities/RepoForksActivity.java +++ b/app/src/main/java/org/mian/gitnex/activities/RepoForksActivity.java @@ -45,7 +45,7 @@ public class RepoForksActivity extends BaseActivity { private View.OnClickListener onClickListener; private TextView noData; private ProgressBar progressBar; - private String TAG = "RepositoryForks"; + private final String TAG = "RepositoryForks"; private int resultLimit = Constants.resultLimitOldGiteaInstances; private int pageSize = 1; diff --git a/app/src/main/java/org/mian/gitnex/adapters/CommitsAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/CommitsAdapter.java index 46e58de1..b1729892 100644 --- a/app/src/main/java/org/mian/gitnex/adapters/CommitsAdapter.java +++ b/app/src/main/java/org/mian/gitnex/adapters/CommitsAdapter.java @@ -37,7 +37,6 @@ public class CommitsAdapter extends RecyclerView.Adapter { UserAccountsApi userAccountsApi = BaseApi.getInstance(context, UserAccountsApi.class); + assert userAccountsApi != null; UserAccount userAccount = userAccountsApi.getAccountByName(accountName); if(AppUtil.switchToAccount(context, userAccount)) { From 8741074906c2cdd4df16d3f3434a66a83d09fa23 Mon Sep 17 00:00:00 2001 From: M M Arif Date: Sat, 1 May 2021 00:01:22 +0200 Subject: [PATCH 2/2] UI improvements and update translation file (#900) Co-authored-by: M M Arif Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/900 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: M M Arif Co-committed-by: M M Arif --- .../res/layout/fragment_administration.xml | 2 ++ .../main/res/layout/fragment_repo_info.xml | 26 ++++++++++--------- .../main/res/layout/list_issue_comments.xml | 3 ++- app/src/main/res/layout/list_labels.xml | 3 +-- app/src/main/res/layout/list_milestones.xml | 4 +-- app/src/main/res/layout/nav_header.xml | 4 +-- app/src/main/res/values/strings.xml | 17 +++--------- 7 files changed, 26 insertions(+), 33 deletions(-) diff --git a/app/src/main/res/layout/fragment_administration.xml b/app/src/main/res/layout/fragment_administration.xml index d74afcaf..d7f651aa 100644 --- a/app/src/main/res/layout/fragment_administration.xml +++ b/app/src/main/res/layout/fragment_administration.xml @@ -24,6 +24,7 @@ android:textColor="?attr/primaryTextColor" android:textSize="16sp" android:padding="16dp" + android:background="?android:attr/selectableItemBackground" app:drawableStartCompat="@drawable/ic_people" /> diff --git a/app/src/main/res/layout/fragment_repo_info.xml b/app/src/main/res/layout/fragment_repo_info.xml index fab39968..6d527999 100644 --- a/app/src/main/res/layout/fragment_repo_info.xml +++ b/app/src/main/res/layout/fragment_repo_info.xml @@ -18,6 +18,18 @@ android:layout_width="match_parent" android:layout_height="wrap_content"> + + @@ -57,18 +70,6 @@ android:layout_height="wrap_content" android:orientation="vertical"> - - diff --git a/app/src/main/res/layout/list_issue_comments.xml b/app/src/main/res/layout/list_issue_comments.xml index 425eaed0..9fa24294 100644 --- a/app/src/main/res/layout/list_issue_comments.xml +++ b/app/src/main/res/layout/list_issue_comments.xml @@ -57,7 +57,8 @@ android:layout_height="wrap_content" android:layout_gravity="top" android:layout_weight="0" - android:contentDescription="@string/generalImgContentText" + android:contentDescription="@string/menuContentDesc" + android:background="?android:attr/selectableItemBackgroundBorderless" app:srcCompat="@drawable/ic_dotted_menu_horizontal" /> diff --git a/app/src/main/res/layout/list_labels.xml b/app/src/main/res/layout/list_labels.xml index 496e342f..2f4a35a1 100644 --- a/app/src/main/res/layout/list_labels.xml +++ b/app/src/main/res/layout/list_labels.xml @@ -58,8 +58,7 @@ android:layout_height="wrap_content" android:layout_gravity="center_vertical|end" android:contentDescription="@string/labelMenuContentDesc" - android:paddingStart="10dp" - android:paddingEnd="0dp" + android:background="?android:attr/selectableItemBackgroundBorderless" android:src="@drawable/ic_dotted_menu_horizontal" /> diff --git a/app/src/main/res/layout/list_milestones.xml b/app/src/main/res/layout/list_milestones.xml index ec2ff429..a4bb13ec 100644 --- a/app/src/main/res/layout/list_milestones.xml +++ b/app/src/main/res/layout/list_milestones.xml @@ -156,11 +156,11 @@ diff --git a/app/src/main/res/layout/nav_header.xml b/app/src/main/res/layout/nav_header.xml index d132589a..d3843167 100644 --- a/app/src/main/res/layout/nav_header.xml +++ b/app/src/main/res/layout/nav_header.xml @@ -49,8 +49,8 @@ app:cardBackgroundColor="?attr/primaryBackgroundColor" app:cardCornerRadius="20dp" app:cardElevation="0dp" - app:contentPaddingLeft="5dp" - app:contentPaddingRight="5dp" + app:contentPaddingLeft="8dp" + app:contentPaddingRight="8dp" tools:visibility="visible"> Protocol is required Cannot access network, please check your Internet connection - Yay, We have Internet connection! Repository name is empty Repository name is not valid. [a–z A–Z 0–9 – _] @@ -177,7 +176,7 @@ This function will be removed in the future 😱 - Avatar + Image No milestones found @@ -236,7 +235,7 @@ Pretty Choose Language Choose Time Format - Help us translate GitNex to your language + Translate GitNex via Crodwin Green - Black Code Block Color Code Block Color Selector @@ -249,12 +248,9 @@ Select App Theme Theme Dark - PDF Night Mode - File Viewer Counter Badges Source Code Theme Sublime - Select Source Code Theme Data Cache Size Data Cache Size 50 MB @@ -480,7 +476,7 @@ Copy Issue URL URL copied to clipboard - Copied comment to clipboard + Comment copied to clipboard %1$d\uFF05 completed @@ -638,7 +634,6 @@ Draft was saved automatically. Themes, fonts, badges - PDF mode, source code theme Biometric authentication, SSL certificates, cache Languages Crash reports @@ -730,12 +725,6 @@ Go to App GitNex cannot handle the requested resource, you can open an issue at the project repository as an improvement with providing details of the work. Just launch a default screen for now from the buttons below, it can be changed from settings. - Green on Black - White on Black - Grey on Black - White on Grey - Dark on White - Biometric Authentication Unlock using your biometric credentials No biometric features available on this device