From 3ec469ff197c705356de8b45f8f28526ae7d0f57 Mon Sep 17 00:00:00 2001
From: qwerty287 <qwerty287@noreply.codeberg.org>
Date: Tue, 7 Mar 2023 06:53:02 +0000
Subject: [PATCH] Never lowercase strings (#1256)

Never lowercase translatable strings. This can lead to weird translations otherwise, e.g. in German, you always start nouns with a capital letter. The current implementation turns this into a wrong capitalization.

Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1256
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
---
 .../java/org/mian/gitnex/adapters/IssueCommentsAdapter.java   | 4 ++--
 app/src/main/res/values/strings.xml                           | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
index 418f0e77..7c872b88 100644
--- a/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
+++ b/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
@@ -573,10 +573,10 @@ public class IssueCommentsAdapter extends RecyclerView.Adapter<RecyclerView.View
 				}
 
 				String commitText =
-						context.getResources().getString(R.string.commits).toLowerCase();
+						context.getResources().getString(R.string.commitsText);
 				if (Objects.requireNonNull(commitsShaArray).length() == 1) {
 					commitText =
-							context.getResources().getString(R.string.commitText).toLowerCase();
+							context.getResources().getString(R.string.commitText);
 				}
 
 				String commitString =
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 5642f91c..17f93f0d 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -802,6 +802,7 @@
     <string name="notesAllDeletionMessage">This will delete all of your notes. This action cannot be undone.</string>
 
     <!-- timeline -->
+    <string name="commitsText">commit</string>
     <string name="commitText">commit</string>
     <string name="timelineAddedCommit">%1$s added %2$s %3$s</string>
     <!-- the | is replaced by the label -->