mirror of
https://codeberg.org/gitnex/GitNex.git
synced 2023-12-13 20:50:18 +01:00
7e514041bb
Do not use TinyDB as a cache or a way to send data between activities.
### How is this working
Instead of saving everything into the TinyDB, I created three `Context`s (a `RepositoryContext`, an `IssueContext` and an `AccountContext`). All are used to store things like API or database values/models and additional data, e.g. the `RepositoryContext` also contains information about the current filter state of a repository (issues, pull requests, releases/tags and milestones). These are sent using `Intent`s and `Bundle`s between activities and fragments. Changing a field (e.g. filter state) in any fragment changes it also for the whole repository (or at least it should do so).
Due to the size of the changes (after c9172f85ef, Git says `154 files changed, 3318 insertions(+), 3835 deletions(-)`) **I highly recommend you to create a beta/pre release before releasing a stable version**.
Additional changes:
* after logging out, the account remains in the account list (with a note) and you can log in again (you can't switch to this account)
* repositories and organizations are clickable on user profiles
* deleted two unused classes
Once finished, hopefully
* closes #354
* replaces #897
* fixes #947
* closes #1001
* closes #1015
* marks #876 and #578 as `Wontfix` since they are not necessary at this point
* and all the other TinyDB issues
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1034
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
204 lines
6.4 KiB
Java
204 lines
6.4 KiB
Java
package org.mian.gitnex.activities;
|
|
|
|
import android.annotation.SuppressLint;
|
|
import android.content.Context;
|
|
import android.os.Bundle;
|
|
import android.util.Log;
|
|
import android.view.MotionEvent;
|
|
import android.view.View;
|
|
import android.view.inputmethod.InputMethodManager;
|
|
import android.widget.Button;
|
|
import android.widget.EditText;
|
|
import android.widget.ImageView;
|
|
import androidx.annotation.NonNull;
|
|
import org.gitnex.tea4j.models.UserOrganizations;
|
|
import org.mian.gitnex.R;
|
|
import org.mian.gitnex.clients.RetrofitClient;
|
|
import org.mian.gitnex.databinding.ActivityCreateOrganizationBinding;
|
|
import org.mian.gitnex.fragments.OrganizationsFragment;
|
|
import org.mian.gitnex.helpers.AlertDialogs;
|
|
import org.mian.gitnex.helpers.AppUtil;
|
|
import org.mian.gitnex.helpers.Toasty;
|
|
import retrofit2.Call;
|
|
import retrofit2.Callback;
|
|
|
|
/**
|
|
* Author M M Arif
|
|
*/
|
|
|
|
public class CreateOrganizationActivity extends BaseActivity {
|
|
|
|
public ImageView closeActivity;
|
|
private View.OnClickListener onClickListener;
|
|
private Button createOrganizationButton;
|
|
|
|
private EditText orgName;
|
|
private EditText orgDesc;
|
|
|
|
@SuppressLint("ClickableViewAccessibility")
|
|
@Override
|
|
public void onCreate(Bundle savedInstanceState) {
|
|
|
|
super.onCreate(savedInstanceState);
|
|
|
|
ActivityCreateOrganizationBinding activityCreateOrganizationBinding = ActivityCreateOrganizationBinding.inflate(getLayoutInflater());
|
|
setContentView(activityCreateOrganizationBinding.getRoot());
|
|
|
|
boolean connToInternet = AppUtil.hasNetworkConnection(appCtx);
|
|
|
|
InputMethodManager imm = (InputMethodManager) getSystemService(Context.INPUT_METHOD_SERVICE);
|
|
|
|
closeActivity = activityCreateOrganizationBinding.close;
|
|
orgName = activityCreateOrganizationBinding.newOrganizationName;
|
|
orgDesc = activityCreateOrganizationBinding.newOrganizationDescription;
|
|
|
|
orgName.requestFocus();
|
|
assert imm != null;
|
|
imm.showSoftInput(orgName, InputMethodManager.SHOW_IMPLICIT);
|
|
|
|
orgDesc.setOnTouchListener((touchView, motionEvent) -> {
|
|
|
|
touchView.getParent().requestDisallowInterceptTouchEvent(true);
|
|
|
|
if ((motionEvent.getAction() & MotionEvent.ACTION_UP) != 0 && (motionEvent.getActionMasked() & MotionEvent.ACTION_UP) != 0) {
|
|
|
|
touchView.getParent().requestDisallowInterceptTouchEvent(false);
|
|
}
|
|
return false;
|
|
});
|
|
|
|
initCloseListener();
|
|
closeActivity.setOnClickListener(onClickListener);
|
|
|
|
createOrganizationButton = activityCreateOrganizationBinding.createNewOrganizationButton;
|
|
|
|
if(!connToInternet) {
|
|
|
|
createOrganizationButton.setEnabled(false);
|
|
}
|
|
else {
|
|
|
|
createOrganizationButton.setOnClickListener(createOrgListener);
|
|
}
|
|
|
|
}
|
|
|
|
private void initCloseListener() {
|
|
|
|
onClickListener = view -> finish();
|
|
}
|
|
|
|
private final View.OnClickListener createOrgListener = v -> processNewOrganization();
|
|
|
|
private void processNewOrganization() {
|
|
|
|
boolean connToInternet = AppUtil.hasNetworkConnection(appCtx);
|
|
|
|
String newOrgName = orgName.getText().toString();
|
|
String newOrgDesc = orgDesc.getText().toString();
|
|
|
|
if(!connToInternet) {
|
|
|
|
Toasty.error(ctx, getResources().getString(R.string.checkNetConnection));
|
|
return;
|
|
}
|
|
|
|
if(!newOrgDesc.equals("")) {
|
|
|
|
if (newOrgDesc.length() > 255) {
|
|
|
|
Toasty.warning(ctx, getString(R.string.orgDescError));
|
|
return;
|
|
}
|
|
}
|
|
|
|
if(newOrgName.equals("")) {
|
|
|
|
Toasty.error(ctx, getString(R.string.orgNameErrorEmpty));
|
|
}
|
|
else if(!AppUtil.checkStrings(newOrgName)) {
|
|
|
|
Toasty.warning(ctx, getString(R.string.orgNameErrorInvalid));
|
|
}
|
|
else {
|
|
|
|
disableProcessButton();
|
|
createNewOrganization(getAccount().getAuthorization(), newOrgName, newOrgDesc);
|
|
}
|
|
|
|
}
|
|
|
|
private void createNewOrganization(final String token, String orgName, String orgDesc) {
|
|
|
|
UserOrganizations createOrganization = new UserOrganizations(orgName, null, orgDesc, null, null);
|
|
|
|
Call<UserOrganizations> call = RetrofitClient
|
|
.getApiInterface(ctx)
|
|
.createNewOrganization(token, createOrganization);
|
|
|
|
call.enqueue(new Callback<UserOrganizations>() {
|
|
|
|
@Override
|
|
public void onResponse(@NonNull Call<UserOrganizations> call, @NonNull retrofit2.Response<UserOrganizations> response) {
|
|
|
|
if(response.code() == 201) {
|
|
OrganizationsFragment.orgCreated = true;
|
|
enableProcessButton();
|
|
Toasty.success(ctx, getString(R.string.orgCreated));
|
|
finish();
|
|
}
|
|
else if(response.code() == 401) {
|
|
|
|
enableProcessButton();
|
|
AlertDialogs.authorizationTokenRevokedDialog(ctx, getResources().getString(R.string.alertDialogTokenRevokedTitle),
|
|
getResources().getString(R.string.alertDialogTokenRevokedMessage),
|
|
getResources().getString(R.string.cancelButton),
|
|
getResources().getString(R.string.navLogout));
|
|
}
|
|
else if(response.code() == 409) {
|
|
|
|
enableProcessButton();
|
|
Toasty.warning(ctx, getString(R.string.orgExistsError));
|
|
}
|
|
else if(response.code() == 422) {
|
|
|
|
enableProcessButton();
|
|
Toasty.warning(ctx, getString(R.string.orgExistsError));
|
|
}
|
|
else {
|
|
|
|
if(response.code() == 404) {
|
|
|
|
enableProcessButton();
|
|
Toasty.warning(ctx, getString(R.string.apiNotFound));
|
|
}
|
|
else {
|
|
|
|
enableProcessButton();
|
|
Toasty.error(ctx, getString(R.string.orgCreatedError));
|
|
}
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void onFailure(@NonNull Call<UserOrganizations> call, @NonNull Throwable t) {
|
|
|
|
Log.e("onFailure", t.toString());
|
|
enableProcessButton();
|
|
}
|
|
});
|
|
|
|
}
|
|
|
|
private void disableProcessButton() {
|
|
|
|
createOrganizationButton.setEnabled(false);
|
|
}
|
|
|
|
private void enableProcessButton() {
|
|
|
|
createOrganizationButton.setEnabled(true);
|
|
}
|
|
|
|
}
|