added changed suggested by meaz in #610 issue ticket #5

Merged
muppeth merged 1 commits from 610 into main 2023-12-01 11:53:42 +01:00
Owner
No description provided.
muppeth added 1 commit 2023-08-14 09:48:59 +02:00
meaz reviewed 2023-08-14 18:11:46 +02:00
@ -20,3 +20,3 @@
As you can see you can decide to either save the exported public key to a file or "Copy" the key to your Clipboard. You can do either one, but if you don't plan on uploading your public key directly, it's better to export to a file.
Exported public key can be then uploaded to Lacre.
Exported public key can be then uploaded to Lacre Keyserver.
Owner

"Lacre Keyserver" should be a link to key server website (at least, that is what is done for other sections)

"Lacre Keyserver" should be a link to key server website (at least, that is what is done for other sections)
Author
Owner

Indeed it is linking everywhere. It shouldn't.
I think there is an issue we need to decide what to do with it. Tutorials linking to lacre.io can cause issue where users who dont know what they're doing, will just follow the tutorial and upload their keys to lacre.io instead their instance (eg. disroot.org). Tutorials should not point anywhere therefore but at the same time be helpful and clear for users. I think there are two options:

  1. Check if it's possible for the links/domain to be turn into variable so it's easy to adjust all the links per instance.

  2. Tutorials should not have any links inside and be universal for any instance.

Solution 1. means every lacre instance needs to deploy their own howto grav site. But, texts will have all that advantage that except for the information also point to the right page.
Solution 2. Means that a lacre isntance only needs to point to the tutorials at learn.lacre.io and doesn't need to deploy grav site. But the will be no links so texts should be clear enough what to do.

What do you think @meaz @antilopa @pfm @fede @avg_joe ?

Indeed it is linking everywhere. It shouldn't. I think there is an issue we need to decide what to do with it. Tutorials linking to lacre.io can cause issue where users who dont know what they're doing, will just follow the tutorial and upload their keys to lacre.io instead their instance (eg. disroot.org). Tutorials should not point anywhere therefore but at the same time be helpful and clear for users. I think there are two options: 1. Check if it's possible for the links/domain to be turn into variable so it's easy to adjust all the links per instance. 2. Tutorials should not have any links inside and be universal for any instance. Solution 1. means every lacre instance needs to deploy their own howto grav site. But, texts will have all that advantage that except for the information also point to the right page. Solution 2. Means that a lacre isntance only needs to point to the tutorials at learn.lacre.io and doesn't need to deploy grav site. But the will be no links so texts should be clear enough what to do. What do you think @meaz @antilopa @pfm @fede @avg_joe ?
Owner

I would go for the second option and make sure to always use the same terms to describe a certain location (e.g. "key server portal"). On top of the tutorials we could list those needed variables and point the reader to make sure they have required url's of their instance. Those should be easy to find through the home page of each instance.

I would go for the second option and make sure to always use the same terms to describe a certain location (e.g. "key server portal"). On top of the tutorials we could list those needed variables and point the reader to make sure they have required url's of their instance. Those should be easy to find through the home page of each instance.
Author
Owner

I agree. I would not put any variables on top unless I understood you wrong. Variables cannot be easily changed. Unless you mean explanation of what "Key server portal" is. What I should make sure is that on webgate (the frontend), link to howto in the menu opens it in new tab.

If we agree to this aproach, we should then write down all those decriptions (eg "key server" etc) and adjust all tutorials.

I agree. I would not put any variables on top unless I understood you wrong. Variables cannot be easily changed. Unless you mean explanation of what "Key server portal" is. What I should make sure is that on webgate (the frontend), link to howto in the menu opens it in new tab. If we agree to this aproach, we should then write down all those decriptions (eg "key server" etc) and adjust all tutorials.
First-time contributor

Yes, second option seems a better approach.

Yes, second option seems a better approach.
Owner

agree two on second option

agree two on second option
meaz approved these changes 2023-08-14 18:11:56 +02:00
Owner

is there any reason why this is not merged?

is there any reason why this is not merged?
muppeth merged commit 8d0fbdb5b5 into main 2023-12-01 11:53:42 +01:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Lacre/learn-lacre-pages#5
No description provided.