LoweBowe/MuseScore
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix #291932: Copy-paste breaths & pauses causes bad layout of the first note/rest in following measures

Browse source 
Copying and pasting a breath mark on the last tick of a measure resulted in an empty Breath segment being created in the next measure. This is because the last tick of one measure is equal to the first tick of the next measure, and Score::tick2measure() always returns the second measure in this case. When the Breath mark actually gets added to the score in Score::undoAddElement(), a new segment for it is created in the previous measure. This is the measure in which we should be adding the segment in the first place.
This commit is contained in:
Matt McClinch 2019-08-29 06:22:16 -04:00
parent f0cdc489cd
commit a4a5173e03
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libmscore/paste.cpp
View file

@ -395,6 +395,8 @@ bool Score::pasteStaff(XmlReader& e, Segment* dst, int dstStaff, Fraction scale)
breath->setTrack(e.track()); breath->setTrack(e.track());
Fraction tick = doScale ? (e.tick() - dstTick) * scale + dstTick : e.tick(); Fraction tick = doScale ? (e.tick() - dstTick) * scale + dstTick : e.tick();
Measure* m = tick2measure(tick); Measure* m = tick2measure(tick);
if (m->tick() == tick)
m = m->prevMeasure();
Segment* segment = m->undoGetSegment(SegmentType::Breath, tick); Segment* segment = m->undoGetSegment(SegmentType::Breath, tick);
breath->setParent(segment); breath->setParent(segment);
undoChangeElement(segment->element(e.track()), breath); undoChangeElement(segment->element(e.track()), breath);