LoweBowe/MuseScore
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove unused startEdit* function from libmscore, remove redundant overrides

Browse source
This commit is contained in:
Dmitri Ovodok 2019-12-11 14:45:37 +02:00
parent 8ef77667fd
commit a6f4b33d6d
6 changed files with 3 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libmscore/mscoreview.h
View file

@ -58,8 +58,6 @@ class MuseScoreView {
virtual void setCursor(const QCursor&) {};
virtual void setDropRectangle(const QRectF&) {};
virtual void cmdAddSlur(ChordRest*, ChordRest*, const Slur* /* slurTemplate */) {};
virtual void startEdit() {};
virtual void startEditMode(Element*) {};
virtual void startEdit(Element*, Grip /*startGrip*/) {};
virtual void startNoteEntryMode() {};
virtual void drawBackground(QPainter*, const QRectF&) const = 0;

8
mscore/exampleview.cpp
View file

@ -147,14 +147,6 @@ void ExampleView::cmdAddSlur(Note* /*firstNote*/, Note* /*lastNote*/)
{
}
void ExampleView::startEdit()
{
}
void ExampleView::startEdit(Element*, Grip /*startGrip*/)
{
}
Element* ExampleView::elementNear(QPointF)
{
return 0;

2
mscore/exampleview.h
View file

@ -75,8 +75,6 @@ class ExampleView : public QFrame, public MuseScoreView {
virtual void setCursor(const QCursor&);
virtual void setDropRectangle(const QRectF&);
virtual void cmdAddSlur(Note* firstNote, Note* lastNote);
virtual void startEdit();
virtual void startEdit(Element*, Grip);
virtual Element* elementNear(QPointF);
virtual void drawBackground(QPainter*, const QRectF&) const;
void dragExampleView(QMouseEvent* ev);

16
mscore/pianoroll.cpp
View file

@ -683,22 +683,6 @@ const QTransform& PianorollEditor::matrix() const
return t;
}
//---------------------------------------------------------
// startEdit
//---------------------------------------------------------
void PianorollEditor::startEdit()
{
}
//---------------------------------------------------------
// startEdit
//---------------------------------------------------------
void PianorollEditor::startEdit(Element*, Grip)
{
}
//---------------------------------------------------------
// elementNear
//---------------------------------------------------------

2
mscore/pianoroll.h
View file

@ -108,8 +108,6 @@ class PianorollEditor : public QMainWindow, public MuseScoreView {
virtual QCursor cursor() const override;
virtual void setCursor(const QCursor&) override;
const QTransform& matrix() const;
virtual void startEdit() override;
virtual void startEdit(Element*, Grip) override;
virtual Element* elementNear(QPointF) override;
virtual void drawBackground(QPainter* /*p*/, const QRectF& /*r*/) const override {}

6
mscore/scoreview.h
View file

@ -241,7 +241,7 @@ class ScoreView : public QWidget, public MuseScoreView {
void endFotoDragEdit();
QImage getRectImage(const QRectF& rect, double dpi, bool transparent, bool printMode);
virtual void startEdit();
void startEdit();
void endEdit();
void startDrag();
@ -299,8 +299,8 @@ class ScoreView : public QWidget, public MuseScoreView {
QPixmap* fgPixmap() { return _fgPixmap; }
virtual void startEdit(Element*, Grip) override;
virtual void startEditMode(Element*) override;
void startEdit(Element*, Grip) override;
void startEditMode(Element*);
void moveCursor(const Fraction& tick);
Fraction cursorTick() const;