From ac3e8dbbc4dfbaa6847c8e9bd9256fd7c1bd5663 Mon Sep 17 00:00:00 2001 From: Werner Schweer Date: Mon, 13 Mar 2017 10:24:49 +0100 Subject: [PATCH] fix #180996: bad 2.xx import; compact inspector text panel --- libmscore/check.cpp | 4 +- libmscore/line.cpp | 4 +- libmscore/property.cpp | 3 +- libmscore/read206.cpp | 18 + mscore/inspector/inspector_element.ui | 76 +++- mscore/inspector/inspector_text.ui | 612 ++++++++++++-------------- 6 files changed, 367 insertions(+), 350 deletions(-) diff --git a/libmscore/check.cpp b/libmscore/check.cpp index 38a9a3bb22..a91498fabc 100644 --- a/libmscore/check.cpp +++ b/libmscore/check.cpp @@ -175,10 +175,10 @@ bool Score::sanityCheck(const QString& name) QString error; for (Measure* m = firstMeasure(); m; m = m->nextMeasure()) { Fraction mLen = m->len(); - int endStaff = staves().size(); + int endStaff = staves().size(); for (int staffIdx = 0; staffIdx < endStaff; ++staffIdx) { Rest* fmrest0 = 0; // full measure rest in voice 0 - Fraction voices[VOICES] = {}; + Fraction voices[VOICES]; #ifndef NDEBUG m->setCorrupted(staffIdx, false); #endif diff --git a/libmscore/line.cpp b/libmscore/line.cpp index cf6315ddbb..aa72261a45 100644 --- a/libmscore/line.cpp +++ b/libmscore/line.cpp @@ -1144,9 +1144,7 @@ bool SLine::readProperties(XmlReader& e) _dashGapLen = e.readDouble(); else if (tag == "lineColor") _lineColor = e.readColor(); - else if (Element::readProperties(e)) - ; - else + else if (!Element::readProperties(e)) return false; return true; } diff --git a/libmscore/property.cpp b/libmscore/property.cpp index e1b5a584b1..78ab6a3eaa 100644 --- a/libmscore/property.cpp +++ b/libmscore/property.cpp @@ -111,7 +111,8 @@ static constexpr PropertyData propertyList[] = { { P_ID::TEXT, "text", false, 0, P_TYPE::STRING }, { P_ID::HTML_TEXT, "html_text", false, 0, P_TYPE::STRING }, { P_ID::USER_MODIFIED, "user_modified", false, 0, P_TYPE::BOOL }, - { P_ID::BEAM_POS, "beam_pos", false, 0, P_TYPE::POINT_SP }, +// { P_ID::BEAM_POS, "beam_pos", false, 0, P_TYPE::POINT_SP }, + { P_ID::BEAM_POS, "beam_pos", false, 0, P_TYPE::POINT }, { P_ID::BEAM_MODE, "beam_mode", true, "BeamMode", P_TYPE::BEAM_MODE }, { P_ID::BEAM_NO_SLOPE, "beam_no_slope", true, "noSlope", P_TYPE::BOOL }, { P_ID::USER_LEN, "user_len", false, "userLen", P_TYPE::REAL }, diff --git a/libmscore/read206.cpp b/libmscore/read206.cpp index af3da049fd..1a79eefd6f 100644 --- a/libmscore/read206.cpp +++ b/libmscore/read206.cpp @@ -45,6 +45,7 @@ #include "pedal.h" #include "hairpin.h" #include "ottava.h" +#include "trill.h" #ifdef OMR #include "omr/omr.h" @@ -1113,6 +1114,21 @@ static void readHairpin(XmlReader& e, Hairpin* h) } } +//--------------------------------------------------------- +// readTrill +//--------------------------------------------------------- + +static void readTrill(XmlReader& e, Trill* t) + { + while (e.readNextStartElement()) { + const QStringRef& tag(e.name()); + if (tag == "subtype") + t->setTrillType(e.readElementText()); + else if (!t->SLine::readProperties(e)) + e.unknown(); + } + } + //--------------------------------------------------------- // readTextLine //--------------------------------------------------------- @@ -1494,6 +1510,8 @@ static void readMeasure(Measure* m, int staffIdx, XmlReader& e) readOttava(e, toOttava(sp)); else if (tag == "HairPin") readHairpin(e, toHairpin(sp)); + else if (tag == "Trill") + readTrill(e, toTrill(sp)); else readTextLine(e, static_cast(sp)); score->addSpanner(sp); diff --git a/mscore/inspector/inspector_element.ui b/mscore/inspector/inspector_element.ui index 2c4647ea28..f1171ef25e 100644 --- a/mscore/inspector/inspector_element.ui +++ b/mscore/inspector/inspector_element.ui @@ -6,8 +6,8 @@ 0 0 - 197 - 157 + 227 + 216 @@ -89,16 +89,6 @@ - - - - Stacking order: - - - z - - - @@ -224,21 +214,59 @@ - - - - Stacking order - - - 1000000000 - - - 100 + + + + + 0 + 0 + - - + + + + + 0 + + + 0 + + + 0 + + + 0 + + + 0 + + + + + Stacking order: + + + z + + + + + + + Stacking order + + + 10000 + + + 100 + + + + + diff --git a/mscore/inspector/inspector_text.ui b/mscore/inspector/inspector_text.ui index e06f02e106..5d316b6d51 100644 --- a/mscore/inspector/inspector_text.ui +++ b/mscore/inspector/inspector_text.ui @@ -6,7 +6,7 @@ 0 0 - 399 + 324 357 @@ -106,34 +106,303 @@ - - - - Alignment: + + + + Reset to default - - align + + Reset 'Font size' value + + + + + + + :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - + + + + Reset to default + + + Reset 'Alignment' value + + + + + + + :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg + + + + + + + + 0 + + + 0 + + + 0 + + + 0 + + + 0 + + + + + + + + sp + + + 0.100000000000000 + + + style + + + + + + + Color: + + + QFrame::Box + + + + + + + Foreground: + + + 20 + + + frameColor + + + + + + + + 0 + 0 + + + + Color: + + + QFrame::Box + + + + + + + Border: + + + 20 + + + frameWidth + + + + + + + Reset to default + + + Reset 'Foreground color' value + + + + + + + :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg + + + + + + + sp + + + 0.200000000000000 + + + + + + + Background: + + + 20 + + + bgColor + + + + + + + Text margin: + + + 20 + + + paddingWidth + + + + + + + Border radius: + + + 20 + + + frameRound + + + + + + + + + + Reset to default + + + Reset 'Background color' value + + + + + + + :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg + + + + + + + Reset to default + + + Reset Border thickness' value + + + + + + + :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg + + + + + + + Reset to default + + + Reset Text margin' value + + + + + + + :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg + + + + + + + Reset to default + + + Reset 'Border radius' value + + + + + + + :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg + + + + + + + + + + Text Alignment + + + + + + Font Size + pt - - - - Font style: + + + + + 0 + 0 + + + + Font face - + + + Font style: Bold + Bold @@ -178,6 +447,9 @@ + + Font style: Italic + Italic @@ -228,6 +500,9 @@ 0 + + Font style: Underline + Underline @@ -257,92 +532,15 @@ - - - - Qt::Horizontal - - - - 0 - 0 - - - - - - - - Reset to default - - - Reset 'Font size' value - - - - - - - :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - - - - - - - Reset to default - - - Reset 'Alignment' value - - - - - - - :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - - - - - - - Font face: - - - fontFace - - - - - - - - 0 - 0 - - - - - - - - Font size: - - - fontSize - - - - - - - + + + Show frame + Frame: @@ -428,232 +626,6 @@ - - - - - 0 - - - 0 - - - 0 - - - 0 - - - 0 - - - - - - - - sp - - - 0.100000000000000 - - - style - - - - - - - Color: - - - QFrame::Box - - - - - - - Foreground color: - - - 30 - - - frameColor - - - - - - - - 0 - 0 - - - - Color: - - - QFrame::Box - - - - - - - Border thickness: - - - 30 - - - frameWidth - - - - - - - Reset to default - - - Reset 'Foreground color' value - - - - - - - :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - - - - - - - sp - - - 0.200000000000000 - - - - - - - Background color: - - - 30 - - - bgColor - - - - - - - Text margin: - - - 30 - - - paddingWidth - - - - - - - Border radius: - - - 30 - - - frameRound - - - - - - - - - - Reset to default - - - Reset 'Background color' value - - - - - - - :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - - - - - - - Reset to default - - - Reset Border thickness' value - - - - - - - :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - - - - - - - Reset to default - - - Reset Text margin' value - - - - - - - :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - - - - - - - Reset to default - - - Reset 'Border radius' value - - - - - - - :/data/icons/edit-reset.svg:/data/icons/edit-reset.svg - - - - - -