Commit graph

17610 commits

Author SHA1 Message Date
joshwd36
944d7d9515 Maintain instrument change transpositions when changing key signature 2020-03-18 18:26:07 +02:00
joshwd36
c5b3e14712 Automatically delete clef and key changes when instrument change is deleted 2020-03-18 18:21:27 +02:00
joshwd36
ab4a6d76cf Automatically change key signature on instrument change (WIP) 2020-03-18 18:21:27 +02:00
joshwd36
2aa4d75704 Change clef if necessary on instrument change 2020-03-18 18:21:27 +02:00
Dmitri Ovodok
58f6f99c91 Automatically change instrument change text to new instrument name
Co-authored-by: Josh Wood <joshwd36@gmail.com>
2020-03-18 18:21:27 +02:00
Josh Wood
26b5977a8a Show a dialog on adding instrument change, add instrument change only once for range selection 2020-03-18 18:21:26 +02:00
Joachim Schmitz
f0c3284ae3 fix some (translatable) texts 2020-03-18 14:32:06 +01:00
Dmitri Ovodok
81767df2f9
Merge pull request #5010 from IsaacWeiss/289006-instrument-change-inspector
Fix #289006: Expose "Select Instrument" in Inspector for Instrument Change text
2020-03-18 14:45:47 +02:00
Dmitri Ovodok
78db47d685
Merge pull request #4879 from Jojo-Schmitz/BravuraText
Update Bravura and BravuraText to latest Steinberg version 1.32
2020-03-18 14:36:49 +02:00
Joachim Schmitz
891841fd89 follow up for fix #288495: prevent wrong debug message 2020-03-18 13:35:49 +01:00
Igor Korsukov
065ac3d361 fixed crash on call Seq::stopNotes 2020-03-18 13:26:59 +02:00
anatoly-os
475de86b84
Merge pull request #5692 from igorkorsukov/audiveris_import
Audiveris import
2020-03-18 13:24:33 +02:00
Igor Korsukov
87919f58d2 added audiveris import 2020-03-18 11:23:46 +02:00
Howard-C
24535fd334 fix #288962: score display does not respond to unchecking of "Begin/Continue/End text" boxes
This will most probably be automatically fixed when the redesign is implemented, but if the redesign cannot be in 3.5, at least this particular issue can be fixed.

This fix adds three new slots, each connected to a checkbox, which removes the corresponding text and resets all relevant text styles if the checkbox is unticked.
2020-03-18 12:20:53 +08:00
Unknown
82f4334dc0 Fix #289006: Expose "Select Instrument" in Inspector for Instrument Change text 2020-03-17 14:04:49 -04:00
Niek van den Berg
51dc62e133 Fix #302388 - Changing the order of the instruments (staves)
Implementation is using another QTreeWidgetItem constructor which accepts the preceding
item. This makes the Implementation straight forward.
2020-03-17 18:31:49 +01:00
Dmitri Ovodok
f0cd7e9516
Merge pull request #5479 from Howard-C/fingering-placement-s-button
fix #288372: hide S button for fingeringPlacement
2020-03-17 17:03:17 +02:00
Dmitri Ovodok
1ba354e5a9
Merge pull request #5665 from jthistle/297176-scroll-prevent-inspector
fix #297176: prevent scrolling on non-focussed spinboxes and comboboxes
2020-03-17 17:01:11 +02:00
Dmitri Ovodok
6fb9106bf5
Merge pull request #5586 from Howard-C/segment-ambitus
[Inspector] fix #284344: ambitus not redrawn on Update Range
2020-03-17 17:00:42 +02:00
Dmitri Ovodok
d3b08bdb30
Merge pull request #5615 from Howard-C/tuplet-inspector
Fix margin and spacing of tuplet inspector
2020-03-17 16:59:51 +02:00
Dmitri Ovodok
37521f4af9
Merge pull request #5803 from Jojo-Schmitz/compiler-warnings
fix some MSVC compiler warnings
2020-03-17 11:45:38 +02:00
Dmitri Ovodok
36146744e8
Merge pull request #5821 from lvinken/more-musicxml-fixes
More musicxml fixes
2020-03-17 10:44:30 +02:00
Dmitri Ovodok
72ef2a5722
Merge pull request #5822 from njvdberg/issue-297482-layout-shifts
Fix #297482 - Score layout shifts when saved with fingering on acciaccatura
2020-03-17 10:38:44 +02:00
Dmitri Ovodok
2c98993793
Merge pull request #5823 from shoogle/qml-palette-navigation
fix #302372: Palette Search filters palettes but not items
2020-03-17 10:37:01 +02:00
Dmitri Ovodok
7012eb7254
Merge pull request #5500 from Howard-C/prefer-sharp-flat
fix #288495: allow user to select flats or sharps for enharmonic key signatures
2020-03-17 10:26:55 +02:00
Peter Jonas
0bb127b441 fix #302372: Palette Search filters palettes but not items
Replace Qt::DisplayRole with Qt::ToolTipRole when accessing data for palette
cells. Necessitated by changes to palettemodel.cpp in PR #5729.
2020-03-17 02:49:22 +00:00
Niek van den Berg
2498950a2c Fix #297482 - Score layout shifts when saved with fingering on acciaccatura
Solves the shift of the fingering on the grace note, and therefor the shift of the line above the fingering.

The root cause was StemSlash. Shapes for the StemSlash are created during the layout of the
beams of the grace notes and the layout of these beams is with the layout of the complete Chord
to which the grace notes belong. As a result, the shapes of StemSlash are added to the skyline
after the layout of the Fingering so the layout of the Fingering was based of the layout of the
Stem only.
After a re-layout the StemSlash is included in the skyline so the re-layout will move
the Fingering and, in this case, also the line.
The solution was a extra layout of the StemSlash in Score::layoutChords3() so it StemSlash is
included in the skyline in time.

Although this issue is vert similar as #302316 and fix #297501, the root cause is
different.
2020-03-16 12:08:24 +01:00
Leon Vinken
b3b15141d2 fix #298855: [MusicXML export] - trill on rest not exported 2020-03-14 19:17:23 +01:00
Leon Vinken
2f2e72efdb fix #290764: MuseScore saves out invalid MUSICXMl file
fix #301320: [MusicXML import/export] incorrect handling of small notes, grace notes and cue notes

Fix the following issues with small notes, grace notes and cue notes:
- cue notes are not imported as silent (non-playing)
- all small note are exported as cue notes instead of only silent small notes
- small grace notes are exported with both grace and cue elements, which MusicXML does not allow
2020-03-14 19:17:23 +01:00
Matt McClinch
3ebfc32ae3 fix #302282: Note entry does not begin on first chord or rest in selected range
Resolves: https://musescore.org/en/node/302282.

When beginning note entry on a range selection, ignore the selection's active ChordRest and just begin on the first ChordRest in the selection.
2020-03-12 18:41:07 -04:00
Niels Erik Gjødsbøl Nielsen
001c34c1b0 Fix #275659: Redundant undo entries 2020-03-12 15:32:11 +02:00
Dmitri Ovodok
42da9ca6d2
Merge pull request #5523 from MarcSabatella/298273-divider-spacer
fix #298273: divider not displayed in some cases
2020-03-12 15:25:47 +02:00
Joachim Schmitz
9e150b0c4f fix some MSVC compiler warnings 2020-03-12 14:15:32 +01:00
Dmitri Ovodok
f1369d3a5a Plugins: fix a crash on getting element's parent if parent is null 2020-03-12 15:07:55 +02:00
Dmitri Ovodok
c2b52e66d7
Merge pull request #5608 from Howard-C/flippable
Improve error message from flip command
2020-03-12 14:53:43 +02:00
Dmitri Ovodok
f3ce93bc5f Fix a typo in Makefile from 0b37675892 2020-03-12 14:41:31 +02:00
Dmitri Ovodok
3ae776cb86
Merge pull request #5000 from Jojo-Schmitz/size_t
fix some compiler warnings differently/cleaner
2020-03-12 11:33:53 +02:00
Joachim Schmitz
03090947cc Update Bravura and BravuraText to latest Steinberg version 1.32
Plus the newly added LICENSE.txt and README.md
2020-03-12 10:17:46 +01:00
Dmitri Ovodok
5804b001ab Revert "fix #279859 reallow drop break elements on vbox"
This reverts commit 1416aa8557.
Tests on MusicXML export are failing with this commit.
2020-03-12 10:34:16 +02:00
Joachim Schmitz
979615972f fix #271445: allow MusicXML export with .xml extension
See also https://musescore.org/en/node/14391#comment-876568 ff.
2020-03-12 10:30:12 +02:00
Dmitri Ovodok
6bbe3ed79a
Merge pull request #4468 from ericfont/279859-dont-set-linebreak-flag-vbox
fix #279859 reallow drop break elements on vbox
2020-03-12 09:48:55 +02:00
Dmitri Ovodok
dafff7c7c0 Correct a typo in Makefile from 0b37675892 2020-03-11 15:37:14 +02:00
Dmitri Ovodok
86b545fa31
Merge pull request #4399 from eridal/add-missing-build-vars
Add missing build variables
2020-03-11 15:33:11 +02:00
Dmitri Ovodok
10bf8b56ee Fix build after dd735c95c9 2020-03-11 15:26:49 +02:00
Dmitri Ovodok
14de329db2
Merge pull request #4303 from Jojo-Schmitz/file_settings
fix #278712: mscore/file.cpp and QSettings variables
2020-03-11 15:19:36 +02:00
Dmitri Ovodok
dd735c95c9
Merge pull request #4147 from mattmcclinch/278080-empty-page
fix #278080: Request to show empty page rather than no page for score with no content
2020-03-11 15:03:01 +02:00
Dmitri Ovodok
8f9ca37019
Merge pull request #3877 from BrunoVernay/patch-1
Removing " Look in: styles"  when not appropriate
2020-03-11 12:26:34 +02:00
Dmitri Ovodok
ab4883cb2d
Merge pull request #5717 from Howard-C/straight
fix #301103: "Straight" text does not work
2020-03-11 09:11:56 +02:00
Howard-C
0f9c5e2d89 fix #301103: "Straight" text does not work
+ rename "SwingOff" to "swingOff" for consistency
2020-03-11 11:52:20 +08:00
Dmitri Ovodok
41860ce02b
Merge pull request #5655 from MarcSabatella/inspector-accessible-names
add accessible names & labels
2020-03-10 21:08:12 +02:00