Commit graph

175 commits

Author SHA1 Message Date
pereverzev_v
9f70fbee53 Fixed a lot of compilation warnings fro GCC 2020-06-02 19:22:29 +02:00
Igor Korsukov
b6dabf5e0b fixed ctor colon 2020-05-29 21:15:25 +02:00
Igor Korsukov
45b9887603 changed code style 2020-05-28 09:50:45 +02:00
Unknown
52b7c8456e Fix #65241: add property and style for position of multimeasure rest numbers 2020-04-28 12:58:42 -04:00
anatoly-os
e9864d1e83
Merge pull request #5371 from mattmcclinch/294085-has-voices
fix #294085: all elements set to normal position if all rests in voices other than voice 1 are deleted
2020-04-20 15:51:47 +03:00
anatoly-os
96c03195e3
Merge pull request #5745 from dmitrio95/layout-opt
Layout optimizations
2020-04-09 17:39:23 +03:00
Matt McClinch
472cb6bfb5 fix #294085: all elements set to normal position if all rests in voices other than voice 1 are deleted
This factors out the inner workings of Measure::checkMultiVoices() into a variant of Measure::hasVoices() that takes a start tick and a length in addition to a staff index.

Co-authored-by: Howard-C <howardc@pku.edu.cn>
2020-04-08 08:22:07 -04:00
Igor Korsukov
68b3415c47 fixed some issues from PVS-Studio report (step1) 2020-03-20 12:18:07 +02:00
Dmitri Ovodok
3d98ba9ab2 Optimize getting segment tick / staff type in local magnitude and spatium calculations 2020-02-21 22:27:47 +02:00
Dmitri Ovodok
dc4c3040a0 Optimize segment tick calculation when searching for staff type 2020-02-21 22:27:43 +02:00
Dmitri Ovodok
99c7b0d746 Add more information to setLayout() 2019-10-25 16:18:41 +02:00
Marc Sabatella
af1fa43758 fix #293300: optimize screenreader feedback for notes and rests
Added code to track the staff & bar number when constructing accessibility text.
If we detect that a navigation has not changed either, we skip reading it,
by constructing a separation "optimized" version of the appropriate text.
Also skip reading voice for measures that have only a single voice,
by suppressing the buiding of that string in screenReaderInfo() for both Note and Rest.
2019-09-17 13:33:35 +02:00
Matt McClinch
d14f5e8eb2 fix #284481: Automatic placement of single rests in multiple voice areas 2019-06-14 01:21:17 -04:00
anatoly-os
217a06a9fd
Merge pull request #5030 from MarcSabatella/scale-offset
Scale offsets with staff
2019-05-21 11:19:38 +02:00
anatoly-os
73bb933da3
Merge pull request #4980 from mattmcclinch/119101-undo-visibility
fix #119101: Wrong undo visibility change for dotted note, where note and dot have different visibilities
2019-05-20 16:26:13 +03:00
Marc Sabatella
510b60ce45 fix #289312: offsets on elements of chords and rests not scaling with staff 2019-05-18 09:32:39 -06:00
Matt McClinch
3af081c0ae fix #119101: Wrong undo visibility change for dotted note, where note and dot have different visibilities 2019-05-02 00:17:05 -04:00
Marc Sabatella
6b7f33ec64 fix #278999, fix #288474: autoplace customization 2019-05-01 07:52:11 -06:00
anatoly-os
73a0a3c874 fix #280657 trig layout when set meas rest offset
manually merged changes from #4493
2019-04-10 10:59:45 +02:00
Dmitri Ovodok
c789322faa Allow copy-pasting hairpins and hairpin+dynamics combinations 2019-03-27 10:24:08 +02:00
anatoly-os
437d993a2f
Merge pull request #4688 from MarcSabatella/284282-rest-offset-layout
fix 284282: layout rest on change of offset
2019-02-18 20:19:14 +02:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
Marc Sabatella
67c2453294 fix 284282: layout rest on change of offset 2019-02-16 14:16:44 -07:00
Eric Fontaine
bedde9f74f fix #280666 disable mouse drag for measure rests
A very minor but noticeable slightly annoying glitch would occur while dragging Measure Rests: their x position would be relative to the initial tick even though their position is relative to their parent measure center.

This occurs because Measure Rests are supposed to be laid out in the center of their measure...but unfortunately it is not easy to lay them out because their x position is dependent on layout of their parent measure. So to make things simple, to avoid this glitch I'm disabling this ability. I doubt anyone will complain. Users may still adjust position of measure rests by using inspector x/y offset or pressing up/down on keyboard.
2018-12-26 04:42:58 -05:00
MarcSabatella
aece90d578 fix #280160: images don't respect autoplace setting 2018-12-16 16:10:35 -07:00
Dmitri Ovodok
4eb78bab62 fix #279080: update beam info for rests, tweak rest beams parameters 2018-12-13 09:32:48 +02:00
ws
d2e452040b fix #278099 Crash when inserting a symbol from master palette 2018-11-13 13:32:33 +01:00
ws
1edd676aa7 fix #277699 Staff properties corrupted on MusicXML import after Master Palette opened
The problem is deep in the initialization of staff types in Staff.
This commit also tries to make handling of StaffType more "const correct" and adds some
assertions which may lead to crashes (and helps detecting bad code).
2018-11-08 15:50:00 +01:00
Dmitri Ovodok
c95dfd5a40 Make it possible to record elements written to MSCX 2018-10-29 16:30:19 +02:00
ws
96af32eee7 fix regressions: layout of misc. elements 2018-10-25 15:44:21 +02:00
ws
d77183b3bb refactoring of Element::userOff and TextBase::offset 2018-10-18 11:56:23 +02:00
anatoly-os
87d175aae8 fix #275901: Changing the visibility of a rest
Changing the visibility of a rest in voice 2 will not move the position of a corresponding rest in voice 1. Manually applied f31bebc4e6
2018-09-21 10:22:15 +02:00
Joachim Schmitz
b27817fe19 fix more MSVC warnings
* The one C4100
* The one C4189
* The two C4457
* The two C4701
* The 475 C4267, changing to size_t were easily possible, casting to
int elsewhere
* Fix GCC warnings reg. wrong printf format for a size_t, reg. unused
variables and reg. ambigous else branch, seen on Travis CI
2018-09-11 16:56:50 +02:00
ws
a64d5d81d3 add preparations for 'skyline' algorithm to calculate system distance 2018-09-03 09:54:20 +02:00
Dmitri Ovodok
d0a24894d2 Read/write beams without using IDs 2018-08-16 19:10:28 +03:00
anatoly-os
c07d825a42
Merge pull request #3775 from mattmcclinch/89016-dotted-rests
fix #89016: Disappearing dots (using NoteDot)
2018-08-14 11:45:05 +02:00
ws
175d5aadb3 cleanup ElementFlags interface, use more Placement properties on mxml import/export 2018-07-04 12:41:14 +02:00
Matt McClinch
daa4802f33 fix #89016: Disappearing dots
Use NoteDot for the dots after rests, instead of the rest drawing its own dots, which were drawn outside of the rest's bbox.
2018-06-29 17:22:24 -04:00
wschweer
903817537c remove code duplication: LinkedStaves 2018-04-27 13:29:39 +02:00
ws
a747b2be7e fix #122001 Staff text automatic placement doesnt work, neither in score nor in parts 2018-04-12 13:22:57 +02:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
luz.paz
dab3b5f056 Misc. typos follow up
Follow up to previous typo commit a8ac55c180
2018-02-19 19:30:12 -05:00
ws
54991c474a updates for articulations and fermata 2018-01-23 14:09:18 +01:00
ws
9d9cd890d6 remove articulations from rest element 2018-01-17 13:25:23 +01:00
ws
35265cd358 implement new fermata element 2018-01-16 13:38:28 +01:00
Werner Schweer
1943bd1ff1 replace most static_cast in libmscore 2017-12-20 16:49:58 +01:00
Nicolas Froment
9a123facc6
Merge pull request #3313 from Jojo-Schmitz/duplicates
Several Duplicate headers and conditions
2017-11-16 17:37:02 +01:00
Werner Schweer
6c735b8798 another multi measure rest layout fix 2017-10-18 13:09:35 +02:00
Werner Schweer
7724169f97 fix for multi measure rest layout 2017-10-17 14:28:03 +02:00
Joachim Schmitz
3a4b88081c Fix #258121: duplicate condition in libmscore/rest.cpp 2017-10-13 15:18:45 +02:00