LoweBowe/MuseScore
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
17849 commits 102 branches 68 tags 1.1 GiB
Commit graph

8333 commits

Author SHA1 Message Date
DangWang
bf15d88c89 fix #295156: select-all now highlights text without the need to release ctrl 2020-04-14 01:09:43 +03:00
AntonioBL
78d9a2978c fix #285434 : Certain 2.x frame texts imported with no style 2020-04-13 22:57:19 +02:00
Joachim Schmitz
f8a0429c50 fix #303712: Crash when extending note into "let ring" and "Palm Mute" 2020-04-12 14:36:37 +02:00
DangWang
b140feb71e fix #302822: breaks are now accessible via keyboard 2020-04-09 23:00:20 +03:00
AntonioBL
bda740ff66 fix #294298 : Diagonal line: End hook can disappear or elongate when Begin hook is set to None 2020-04-09 16:59:54 +02:00
anatoly-os
96c03195e3
Merge pull request #5745 from dmitrio95/layout-opt 
Layout optimizations
 2020-04-09 17:39:23 +03:00
anatoly-os
409aa87dad
Merge pull request #5893 from Jojo-Schmitz/stemles-crash 
fix #303189: Staff/Part properties > Advanced Style Properties > Stemless crashes MuseScore
 2020-04-09 17:37:29 +03:00
anatoly-os
13a302f1af
Merge pull request #5877 from igorkorsukov/pvs_fixes_step6 
Fixed some issues from PVS-Studio report (step6)
 2020-04-09 13:15:02 +03:00
Howard-C
ea3e44f6f6 fix #295701: able to open backup files as an import 
Resolves: https://musescore.org/node/295701.

A few improvements are made along the way to make sure the backup file ".name.mscz,/mscx," is saved (saved as/saved as copy) correctly as "name.mscz/mscx".
 2020-04-09 10:06:27 +08:00
anatoly-os
8537770c35
Merge pull request #5380 from Howard-C/backup-folder 
[Backup File] fix #125656: put the backup file in a separate folder
 2020-04-07 14:50:24 +02:00
anatoly-os
38f73a7c59
Merge pull request #5851 from mattmcclinch/302603-turned-accidentals 
fix #302603: Changing "Direction" has no effect on bowing symbols
 2020-04-07 14:28:57 +02:00
anatoly-os
c43b54c184
Merge pull request #5852 from Jojo-Schmitz/texts 
fix #302711: chord symbol playback channel in Mixer is shown as "harmony"
 2020-04-07 14:14:49 +02:00
Joachim Schmitz
152796e1d7 closing file once no longer needed 2020-04-07 11:54:40 +02:00
anatoly-os
c13dba11c4
Merge pull request #5879 from igorkorsukov/sentry/N4K_text_endedit 
Try fix crash on TextBase::endEdit (from CrashReporter)
 2020-04-07 10:47:30 +02:00
anatoly-os
7710ce7510
Merge pull request #5818 from emfomy/patch-1 
Fix #302281: Wrong default beaming of 32nd notes in 9/8 and 12/8
 2020-04-07 10:11:13 +02:00
anatoly-os
dc654503fa
Merge pull request #5878 from igorkorsukov/tracker_299788_localtimesig 
fix #299788 Crash when deleting a local Time Signature (removed assert)
 2020-04-07 09:52:38 +02:00
anatoly-os
9916086f6b
Merge pull request #5874 from igorkorsukov/tracker_292631_glissandos 
fix #292631 fixed crash on spanners (glissandos) layout
 2020-04-07 09:50:53 +02:00
anatoly-os
d57183493e
Merge pull request #5866 from igorkorsukov/sentry_corrupt_editdata 
fixed collision between drag and cmds next*, prev*
 2020-04-07 09:50:07 +02:00
Igor Korsukov
4a41f16082 fixed crash on text endedit 2020-04-07 09:36:50 +02:00
Dmitri Ovodok
91431b7c5b Draw anchors at staff bottom if element is placed below 2020-04-04 01:05:58 +03:00
Dmitri Ovodok
4a55e85b53 Avoid duplication of dragAnchorLines() code for most elements 2020-04-04 01:05:58 +03:00
Dmitri Ovodok
4c5e9ed273 Fix anchor lines on non-first pages 2020-04-04 01:05:58 +03:00
pereverzev_v
ad2cad22b5 Now single grip of an element (usually the middle one) can have a few anchor lines 2020-04-04 01:05:58 +03:00
pereverzev_v
6b16656704 Dragging elements could work with few anchor lines 2020-04-04 01:03:43 +03:00
Joachim Schmitz
263d5d91d7 fix #303189: Staff/Part properties > Advanced Style Properties > Stemless crashes MuseScore 
The problem is that a stem's `lineWidthMag()` was asked for even if
there is no stem (anymore).

Apparently caused by the changes in #5669 / 57d8a1841 for fixing
[#291699](https://musescore.org/en/node/291699)
 2020-04-03 14:13:24 +02:00
Mu Yang
56ee821f16 Fix #302281: Wrong default beaming of 32nd notes in 9/8 and 12/8 2020-03-31 14:59:02 +08:00
Joachim Schmitz
efcf14ae94 fix #302711: chord symbol playback channel in Mixer is shown as "harmony" 
fixing the harmony channel name, make channel names translatable,
some text changes, using ellipsis, deleting/untranslating some,
adding tooltips about what "Realize Chord Symbols" means
and adjusting mtests.
Also compacting the voicing dialog
 2020-03-29 22:05:16 +02:00
anatoly-os
1163513290
Merge pull request #5315 from tcannon686/master 
fix #282246: "other" appearance in time signature properties does not work
 2020-03-29 20:14:45 +02:00
Dmitri Ovodok
9f7a9c1775 Move all handling of empty text elements removal to TextBase::endEdit() 2020-03-28 05:54:20 +02:00
Dmitri Ovodok
1edcf0d2d3 fix #302643: crash on advancing to next chord symbol with no text entered 
Ensures that text elements are deleted after the entire text editing
process is finished. Previously elements were deleted on next
Score::update() call which is dangerous since it may happen to be
called several times on finishing text editing.

Also take care to remove the deleted element from selection to
prevent potential crashes on undo/redo operations (e.g. with lyrics)
 2020-03-28 05:48:32 +02:00
Igor Korsukov
49deefa6b9 fixed indent 2020-03-27 13:31:41 +02:00
Igor Korsukov
2a5af1c527 fixed virtual methods 2020-03-27 13:07:27 +02:00
Igor Korsukov
0aecb0a173 fixed virtual methods 2020-03-27 10:01:06 +02:00
Igor Korsukov
a2bfb02954 fix #292631 fixed spanners (glissandos) layout 2020-03-26 16:41:36 +02:00
Igor Korsukov
4c6a56cfff fix #299788 removed assert 2020-03-26 11:18:40 +02:00
anatoly-os
1f0ec33327
Merge pull request #5860 from igorkorsukov/pvs_fixes_step3 
Fixed some issues from PVS-Studio report (step3)
 2020-03-24 23:08:57 +02:00
Igor Korsukov
9d9d06b3c2 fixed virtual methods 2020-03-24 15:49:16 +02:00
anatoly-os
9e456031cf
Merge pull request #5850 from igorkorsukov/pvs_fizeds_step2 
Fixed some issues from PVS-Studio report (step2)
 2020-03-24 13:12:03 +02:00
Igor Korsukov
69df3f9656 fixed collision between drag and cmds next*, prev* 2020-03-24 12:56:07 +02:00
anatoly-os
aaf3cf9de8
Merge pull request #5857 from igorkorsukov/sentry_9E9_Note_drag 
Try fix crash on Note::drag (from CrashReporter)
 2020-03-24 12:50:40 +02:00
anatoly-os
27c7c850a8
Merge pull request #5856 from igorkorsukov/sentry_JP4_SlurTieSegment_startEditDrag 
Try fix crash on SlurTieSegment::startEditDrag (from CrashReporter)
 2020-03-24 12:26:06 +02:00
MarcSabatella
b50a5543c1 fix #302690: crash after copying chord symbol 
Resolves: https://musescore.org/en/node/302690

Currently, a crash can occur after copying a chord symbol.
The Harmony object contains a RealizedHarmony object,
which contains a pointer back to the Harmony object,
but the copy constructor for Harmony does not set the pointer.
This ends up yielding an invalid pointer by the time the copy completes.
This fix makes sure to set the pointer correctly.
It also copies the "_play" property,
otherwise copied chord symbols would not play by default.
 2020-03-22 11:07:51 -06:00
Igor Korsukov
366b0f151d fixed virtual methods 2020-03-21 16:03:04 +02:00
Igor Korsukov
33675a8fa6 try fix crash on Note::drag 2020-03-21 12:49:14 +02:00
Igor Korsukov
9119661781 try fix crash on SlurTieSegment::startEditDrag 2020-03-21 12:15:57 +02:00
Matt McClinch
834404d9da fix #302603: Changing "Direction" has no effect on bowing symbols 
Resolves: https://musescore.org/en/node/302603.

Many articulations have names like "fermataAbove" and "fermataBelow". The flipping mechanism currently only supports articulations with names in this form. But some articulations have names like "stringsUpBow" and "stringsUpBowTurned". This commit adds the ability to flip articulations with names in this form also.
 2020-03-20 12:46:51 -04:00
Igor Korsukov
11f7060e2d fixed issues from PVS-Studio report (step2) 2020-03-20 16:52:52 +02:00
anatoly-os
a1dc1371c2
Merge pull request #5810 from igorkorsukov/5129_chord-symbol-playback_corrections 
[GSoC 2019] Basic chord symbol realization
 2020-03-20 16:03:28 +02:00
Dmitri Ovodok
26fda43407
Merge pull request #5561 from mattmcclinch/298959-change-accidental 
fix #298959: Note changes pitch, but accidental is not changed
 2020-03-20 15:23:37 +02:00
Dmitri Ovodok
2ce0f5e2a9
Merge pull request #5445 from mattmcclinch/292606-layout-image 
fix #292606: image attached to a measure doesn't show
 2020-03-20 15:01:43 +02:00
Dmitri Ovodok
ecf63e4777
Merge pull request #5372 from Howard-C/generate-backup 
[Backup File] fix #295310: add advanced preference option of disabling backup
 2020-03-20 14:43:50 +02:00
Dmitri Ovodok
5f975282f2
Merge pull request #5838 from igorkorsukov/pvs_fixeds_step1 
Fixed some issues from PVS-Studio report (step1)
 2020-03-20 14:10:12 +02:00
Dmitri Ovodok
84581c60ca
Merge pull request #5847 from igorkorsukov/sentry_9G3_note_enddrag 
Try fix crash on Note::endDrag (from CrashReporter)
 2020-03-20 14:01:34 +02:00
Dmitri Ovodok
9b5c42b76e
Merge pull request #5836 from igorkorsukov/sentry_g0h_measure_write 
Fixed crash on Measure write (from CrashReporter)
 2020-03-20 14:00:46 +02:00
Igor Korsukov
68b3415c47 fixed some issues from PVS-Studio report (step1) 2020-03-20 12:18:07 +02:00
Igor Korsukov
cf73e02022 try fixed crash on Note::endDrag 2020-03-20 11:48:52 +02:00
Joachim Schmitz
1a339849ae fix compiler warnings 2020-03-19 19:48:12 +01:00
Igor Korsukov
f9b1e499c5 Some fixes basic chord symbol realization 2020-03-19 14:03:47 +02:00
Peter Hieu Vu
86a4e7b105 Added basic chord symbol realization 2020-03-19 13:52:39 +02:00
Joachim Schmitz
52baed5fcb fix #302304: prevent potential crash when adding instruments 
esp. to score with parts imported from MuseScore 1.x
 2020-03-19 12:46:38 +01:00
anatoly-os
1137e606ff
Merge pull request #5782 from dmitrio95/joshwd36-instrument-change-improvements 
[GSoC 2019] Instrument change improvements
 2020-03-19 13:44:15 +02:00
Dmitri Ovodok
2adc65ba5c
Merge pull request #5617 from Jojo-Schmitz/transpose 
fix #299727: Change Transpose "By Key" to "To Key"
 2020-03-19 13:00:00 +02:00
Dmitri Ovodok
9087e3a6e1
Merge pull request #5831 from Jojo-Schmitz/debug 
follow up for fix #288495: prevent wrong debug message
 2020-03-19 12:14:04 +02:00
Dmitri Ovodok
809f416459 Fix extending hairpin to multiple systems with Shift+arrow with middle grip selected 2020-03-19 12:10:44 +02:00
Igor Korsukov
482bd502c4 fixed crash on Measure write 2020-03-19 11:51:00 +02:00
joshwd36
3130bcd26d Change structure of warnings, key signatures, and clefs to remove pointers between them and instrument changes 2020-03-18 18:26:09 +02:00
joshwd36
944d7d9515 Maintain instrument change transpositions when changing key signature 2020-03-18 18:26:07 +02:00
joshwd36
c5b3e14712 Automatically delete clef and key changes when instrument change is deleted 2020-03-18 18:21:27 +02:00
Dmitri Ovodok
58f6f99c91 Automatically change instrument change text to new instrument name 
Co-authored-by: Josh Wood <joshwd36@gmail.com>
 2020-03-18 18:21:27 +02:00
Josh Wood
26b5977a8a Show a dialog on adding instrument change, add instrument change only once for range selection 2020-03-18 18:21:26 +02:00
Joachim Schmitz
891841fd89 follow up for fix #288495: prevent wrong debug message 2020-03-18 13:35:49 +01:00
Igor Korsukov
87919f58d2 added audiveris import 2020-03-18 11:23:46 +02:00
Dmitri Ovodok
37521f4af9
Merge pull request #5803 from Jojo-Schmitz/compiler-warnings 
fix some MSVC compiler warnings
 2020-03-17 11:45:38 +02:00
Dmitri Ovodok
72ef2a5722
Merge pull request #5822 from njvdberg/issue-297482-layout-shifts 
Fix #297482 - Score layout shifts when saved with fingering on acciaccatura
 2020-03-17 10:38:44 +02:00
Dmitri Ovodok
7012eb7254
Merge pull request #5500 from Howard-C/prefer-sharp-flat 
fix #288495: allow user to select flats or sharps for enharmonic key signatures
 2020-03-17 10:26:55 +02:00
Niek van den Berg
2498950a2c Fix #297482 - Score layout shifts when saved with fingering on acciaccatura 
Solves the shift of the fingering on the grace note, and therefor the shift of the line above the fingering.

The root cause was StemSlash. Shapes for the StemSlash are created during the layout of the
beams of the grace notes and the layout of these beams is with the layout of the complete Chord
to which the grace notes belong. As a result, the shapes of StemSlash are added to the skyline
after the layout of the Fingering so the layout of the Fingering was based of the layout of the
Stem only.
After a re-layout the StemSlash is included in the skyline so the re-layout will move
the Fingering and, in this case, also the line.
The solution was a extra layout of the StemSlash in Score::layoutChords3() so it StemSlash is
included in the skyline in time.

Although this issue is vert similar as #302316 and fix #297501, the root cause is
different.
 2020-03-16 12:08:24 +01:00
Dmitri Ovodok
42da9ca6d2
Merge pull request #5523 from MarcSabatella/298273-divider-spacer 
fix #298273: divider not displayed in some cases
 2020-03-12 15:25:47 +02:00
Joachim Schmitz
9e150b0c4f fix some MSVC compiler warnings 2020-03-12 14:15:32 +01:00
Dmitri Ovodok
c2b52e66d7
Merge pull request #5608 from Howard-C/flippable 
Improve error message from flip command
 2020-03-12 14:53:43 +02:00
Dmitri Ovodok
3ae776cb86
Merge pull request #5000 from Jojo-Schmitz/size_t 
fix some compiler warnings differently/cleaner
 2020-03-12 11:33:53 +02:00
Dmitri Ovodok
5804b001ab Revert "fix #279859 reallow drop break elements on vbox" 
This reverts commit 1416aa8557.
Tests on MusicXML export are failing with this commit.
 2020-03-12 10:34:16 +02:00
Dmitri Ovodok
6bbe3ed79a
Merge pull request #4468 from ericfont/279859-dont-set-linebreak-flag-vbox 
fix #279859 reallow drop break elements on vbox
 2020-03-12 09:48:55 +02:00
Dmitri Ovodok
10bf8b56ee Fix build after dd735c95c9 2020-03-11 15:26:49 +02:00
Dmitri Ovodok
dd735c95c9
Merge pull request #4147 from mattmcclinch/278080-empty-page 
fix #278080: Request to show empty page rather than no page for score with no content
 2020-03-11 15:03:01 +02:00
Dmitri Ovodok
ab4883cb2d
Merge pull request #5717 from Howard-C/straight 
fix #301103: "Straight" text does not work
 2020-03-11 09:11:56 +02:00
Howard-C
0f9c5e2d89 fix #301103: "Straight" text does not work 
+ rename "SwingOff" to "swingOff" for consistency
 2020-03-11 11:52:20 +08:00
Dmitri Ovodok
7569ebb7b4
Merge pull request #5704 from Jojo-Schmitz/multimap 
copy `#include <QMultiMap>` to all.h
 2020-03-10 15:19:37 +02:00
Dmitri Ovodok
dc8bd44011
Merge pull request #5743 from mattmcclinch/299768-paste-hairpin 
fix #299768: Hairpin: when copied, all custom settings are lost and the element resets to default
 2020-03-10 14:28:38 +02:00
Dmitri Ovodok
93b96c3c23
Merge pull request #5757 from Howard-C/arpeggio-glissandi 
fix #301555: invisible arpeggios and glissandi occupy space
 2020-03-10 14:02:23 +02:00
Dmitri Ovodok
85999e75cf
Merge pull request #5771 from flynndcs/301753-figuredbassrests 
fix #301753: Figures under rests
 2020-03-10 12:27:49 +02:00
Dmitri Ovodok
df11d4b8e3
Merge pull request #5786 from Kartikay26/290034-repeats-in-newly-opened-score 
fix #290034: play repeats button not respected  in new score
 2020-03-10 12:06:58 +02:00
Dmitri Ovodok
b03960e386
Merge pull request #5787 from MarcSabatella/300693-fb-cont 
fix #300693: fb continuation not drawn when ending in voice 2
 2020-03-10 11:58:11 +02:00
Dmitri Ovodok
72378dad3d
Merge pull request #5672 from dmitrio95/289643-volta-anchor-read 
fix #289643: fix crashes if volta anchor is set incorrectly in MSCZ file
 2020-03-10 10:39:57 +02:00
Dmitri Ovodok
f97cfd1f1a fix #289643: fix crashes if volta anchor is set incorrectly in MSCZ file 2020-03-10 10:39:33 +02:00
Dmitri Ovodok
78e0f092f1
Merge pull request #5671 from dmitrio95/autosave-performance 
Improve autosave performance
 2020-03-10 10:34:21 +02:00
Dmitri Ovodok
ba9ebc83aa Score comparison tool: avoid crash on inability to merge text diffs 
Calling merge() on non-adjacent text diffs should probably not happen
and reveals a potential bug in score diff code, but it is not a fatal
error and should not lead to MuseScore crash. This commit avoids
terminating MuseScore in this case. Score comparison still produces
sensible results in case of such error.
 2020-03-09 15:59:23 +02:00
Howard-C
3bc26748ea fix #301555 part 2: invisible glissandi occupy space 2020-03-07 18:07:48 +08:00
Matt McClinch
008814b2f0 fix #302011: Grace note tie crash 
Resolves: https://musescore.org/en/node/302011.

When creating a tie from a grace note to its main note, make sure not to overwrite the main note's chord, thus destroying the grace note and creating a tie from a note to itself.
 2020-03-07 01:50:38 -05:00
MarcSabatella
8f6934f1e6 fix #300693: fb continuation not drawn when ending in voice 2 
Resolves: https://musescore.org/en/node/300693

Continuation lines are drawn to the right edge of the last note
that starts before the end of the figure's duration.
The code that finds this note was only looking in voice 1.
That resulted in continuation lines ending short, or disappearing,
if the last note was in another voice.

Fix is to be sure to check all voices when searchiing for the end CR.
 2020-03-06 15:11:56 -07:00
Agus Terol
ea046a2305 fix #153656: Added advanced preference key io/midi/pedalEventsMinTicks 
This preference key represents the minimal amount of ticks that can occur
between a pedal off event and a pedal on event. Currently, its default
value is 1, thus there is no difference with the previous implementation.
When increasing its value, the pedal off event will be moving backwards by
the specified amount of ticks (i.e. it will happen earlier), so that the
distance with the next pedal on (if any) event will grow.
 2020-03-06 22:42:18 +01:00