Commit graph

16388 commits

Author SHA1 Message Date
anatoly-os
30003577fd Make AppVeyor config use Qt from S3
To avoid dependency from AppVeyor's images Qt version
2019-08-29 15:32:33 +02:00
anatoly-os
002416819f
Merge pull request #5277 from mattmcclinch/291932-paste-breath
fix #291932: Copy-paste breaths & pauses causes bad layout of the first note/rest in following measures
2019-08-29 13:06:53 +02:00
anatoly-os
2a1fc1f5d7
Merge pull request #5261 from mattmcclinch/290011-tab-duration
fix #290011: [Tablature] Note value repeat section: "At new system" renders the same as "At new measure"
2019-08-29 12:23:42 +02:00
Matt McClinch
a4a5173e03 fix #291932: Copy-paste breaths & pauses causes bad layout of the first note/rest in following measures
Copying and pasting a breath mark on the last tick of a measure resulted in an empty Breath segment being created in the next measure. This is because the last tick of one measure is equal to the first tick of the next measure, and Score::tick2measure() always returns the second measure in this case. When the Breath mark actually gets added to the score in Score::undoAddElement(), a new segment for it is created in the previous measure. This is the measure in which we should be adding the segment in the first place.
2019-08-29 06:22:16 -04:00
anatoly-os
f0cdc489cd
Merge pull request #5279 from lvinken/292461-musicxml-export-measure-nrs
292461 musicxml export measure nrs
2019-08-29 12:09:41 +02:00
anatoly-os
12adde5052
Merge pull request #5175 from Jojo-Schmitz/qt-creator-warnings
fix some 'red underline' warnings in/for QtCreator
2019-08-29 11:33:58 +02:00
anatoly-os
ad1852ca0a
Merge pull request #5242 from mattmcclinch/291038-fixup-midi
fix #282165: Mute voice produces note that doesn't stop when overlap present
2019-08-29 11:29:04 +02:00
anatoly-os
5465207960
Merge pull request #5284 from Howard-C/vs2019-spacer
fix #293877: adding or dragging spacers causes a full re-layout
2019-08-29 11:11:03 +02:00
anatoly-os
d7c3b701d3
Merge pull request #5250 from Jojo-Schmitz/warnings
fix compiler warnings reg. comparing signed and unsigned and some unused parameters
2019-08-29 10:39:06 +02:00
Howard-C
73ad2b4e13 fix #293877: adding or dragging spacers causes a full re-layout
Comes from https://musescore.org/en/node/290398#comment-940605. This can cause a serious delay on big scores.

The idea of fixing is changing the score()->setLayoutAll() to triggerLayout() in the functions of dropping and editing spacers. triggerLayout() will only do neccessary partial layout.
2019-08-29 11:41:20 +08:00
anatoly-os
1841aa8826
Merge pull request #5116 from Jojo-Schmitz/ottava-text
fix #290493: Ottava begin and continue text cannot be saved as independent style settings
2019-08-28 18:06:01 +02:00
Joachim Schmitz
842109d4dd fix #290493: Ottava begin and continue text cannot be saved as independent style setting
and use "8va" for ottava bassa if not just number to match the handbook
https://musescore.org/en/handbook/3/octave-lines
and also the 2nd preference from Elain Gould's "Behind Bars":

1. 8
2. 8va
3. 8va bassa
4. 8ba

Note: 8vb is not amongst those...
2019-08-28 17:11:22 +02:00
Dmitri Ovodok
0d924d4ca8
Merge pull request #5282 from jthistle/292960-hairpin-last-bar
fix #292960: hairpin with dynamics at the end is too short
2019-08-28 16:00:46 +03:00
James Thistlewood
922e514e49 fix #292960: hairpin with dynamics at the end is too short 2019-08-28 13:58:06 +01:00
anatoly-os
b089ea0057
Merge pull request #5280 from mattmcclinch/293733-grace-note-tie
fix #293733: If note is tied to preceding grace note of equal pitch, only the grace note is played back
2019-08-28 14:31:17 +02:00
Matt McClinch
e98b0edd1d fix #293733: If note is tied to preceding grace note of equal pitch, only the grace note is played back
Why this is happening

In collectNote() in rendermidi.cpp, grace notes are currently not treated as notes that could potentially have forward ties; in fact, it is assumed that they will not. When a note is encountered that ties back to a previous note, it is assumed that the length of the note has already been added to the previous note, when in fact this is not the case if the previous note is a grace note.

Why this commit fixes the issue

The code for computing the entire length of the tie chain is now executed whether the current note is a grace note or not.
2019-08-28 08:17:51 -04:00
anatoly-os
3d4488323c
Merge pull request #4974 from Jojo-Schmitz/zh_HK
Add "Chinese (Hong Kong)"
2019-08-28 13:50:48 +02:00
Dmitri Ovodok
2c82d0db4a
Merge pull request #5258 from DLLarson/plugin-expose-note-ties
Fix #293008: Plugin: Provide Note.tieBack & Note.tieForward properties in QML.
2019-08-28 14:37:51 +03:00
Dmitri Ovodok
0a24d95a85 Fix initialization of LyricsLineSegment members
Fixes random hanging on PNG export of some scores, see
https://musescore.org/en/node/293523#comment-940874
2019-08-28 14:17:40 +03:00
Dmitri Ovodok
5ac905905d fix #293599: expose list of measure elements to plugins
Makes it possible to find repeats (Coda, Segno etc.) and layout
breaks from a plugin
2019-08-28 14:17:40 +03:00
anatoly-os
6c2df0cec5
Merge pull request #3461 from Jojo-Schmitz/chord-symbols
allow unicode flat and sharp as input for chord symbols
2019-08-28 12:33:27 +02:00
anatoly-os
6546b0ee1f
Merge pull request #5271 from Jojo-Schmitz/staff-type-change
Fix #293464: Slash style for staff type change: Inspector label and function are not the same
2019-08-28 12:21:27 +02:00
Joachim Schmitz
2cbc1bbd54 make use of the existing accordion palette
in the master palette and rermove bagpipe embelishments from the
Advanced workspace (so it is available only in the master palette too)
2019-08-28 12:09:20 +02:00
anatoly-os
56c557b3c8
Merge pull request #5251 from jthistle/vscode-settings
add musescore-specific vscode editor settings for linux
2019-08-28 11:34:18 +02:00
anatoly-os
920cd1be40
Merge pull request #5150 from Jojo-Schmitz/Qt-5.12.4-SSL-update
fix #291079: "Save online" fails as of Qt 5.12.4 on Windows
2019-08-28 09:03:30 +02:00
Dale Larson
b60fea52cf Fix #293008: Plugin: Provide Note.tieBack & Note.tieForward properties in QML.
Provide Note.tieBack & Note.tieForward properties and their
associated Tie objects in QML. Also provides Note.firstTiedNote
and lastTiedNote methods to locate a tie range.
2019-08-27 17:28:53 -05:00
Joachim Schmitz
3012c827dd fix compiler warning reg. comparing signed and unsigned and unused parameters
for some strange reason `QList::size()` returns `int` rather than
`size_t`, IMHO a bug in Qt, as even a `QList` can't have a negative
number of members.
And fix another warning reg. shadowing a local variable as well as reg.
some unused parameters
2019-08-27 12:10:27 +02:00
Dmitri Ovodok
0b55077b2e
Merge pull request #5278 from MarcSabatella/293531-gen-clef-key
fix #293531: clef&key appear on second system with gen clef&key disabled
2019-08-27 10:25:40 +03:00
anatoly-os
0312b14d71
Merge pull request #5272 from lvinken/musicxml-fixes
Assorted Musicxml fixes
2019-08-26 09:41:17 +02:00
anatoly-os
b6d30457a9
Merge pull request #4950 from lvinken/tuplet-calc-fractions-004
fix #279828 - MusicXML import - attempting to fix badly read triplets…
2019-08-26 09:38:59 +02:00
Leon Vinken
1967dab530 fix #293751 - [MusicXML export] missing print new-system after section break 2019-08-25 22:12:00 +02:00
Leon Vinken
75cf11029f fix #292461 - [Musicxml Export] - Measure numbering not correct (after section break) 2019-08-25 21:54:23 +02:00
Matt McClinch
711b7ab72c fix #282165: Mute voice produces note that doesn't stop when overlap present 2019-08-24 01:27:07 -04:00
Marc Sabatella
ccb8fe0e02 fix #293531: clef&key appear on second system after layout with gen clef&key disabled
In https://github.com/musescore/MuseScore/pull/4866 I added code
to better handle the detection of the end of the layout range.
Part of this was to re-establish the header in the first measure after the end of the range.
But my code mistakenly passed in lc.firstSystem as the firstSystem parameter.
Thus it treated the *second* system as if it was the first,
since lc.firstSystem was set based on the system we just completed,
not the system we are about to consider.
Fix is to calculate when this new system is actually the first system of a section or not.
I calculate this the same way lc.firstMeasure itself is calculated.
2019-08-23 14:06:07 -04:00
Dmitri Ovodok
b2dffcde4b
Merge pull request #5274 from jthistle/293311-patch-change-expr
fix #293311: changing Part Properties changes violin patch in the mixer
2019-08-22 10:51:20 +03:00
Dmitri Ovodok
5f5d0903de
Merge pull request #5273 from Jojo-Schmitz/orphaned-segment
Fix #293460: Crash when loading file with orphan Segment tags
2019-08-22 10:48:06 +03:00
Joachim Schmitz
32cbcfe034 Fix #293460: Crash when loading file with orphan Segment tags
correct broken files on the fly and don't create them anymore.
2019-08-21 15:58:09 +02:00
James Thistlewood
298870492a fix #293311: changing Part Properties changes violin patch in the mixer 2019-08-20 16:40:57 +01:00
Joachim Schmitz
1fe86fde19 force Qt 5.12.4 + collect_artifacts 2019-08-20 14:11:25 +02:00
Joachim Schmitz
e869ec1d61 fix #291079: "Save online" fails as of Qt 5.12.4 on Windows
As of Qt 5.12.4 OpenSSL version 1.1.1 is needed.
Detect/copy old/new SSL DLLs depending on Qt version to save space in
the resulting package.
For Qt >= 5.12.4 dependencies.7z needs to get updated to include those
new DLLs, attached to the issue,
https://musescore.org/en/node/291079#comment-940153
2019-08-20 14:10:15 +02:00
anatoly-os
b101167b80
Merge pull request #5210 from MarcSabatella/290047-adjust-segment
fix #290047: require Shift to adjust segment with cursor keys in edit…
2019-08-19 17:35:15 +02:00
anatoly-os
937fac34da
Merge pull request #5166 from Jojo-Schmitz/3/2
fix #291292: Add 3/2 time signature to advanced workspace and master palette
2019-08-19 15:58:43 +02:00
Joachim Schmitz
a53bac4711 replace slashStyle with stemless
and all related things along with it, including a compatibility layer
2019-08-19 15:07:30 +02:00
Joachim Schmitz
aa5faa5764 Fix #293464: Slash style for staff type change: Inspector label and function are not the same 2019-08-19 14:16:34 +02:00
anatoly-os
f8285a023e
Merge pull request #5188 from Obliquely/obq-play-panel-vertical-stretch
fix #290700: improve appearance of play panel when very tall
2019-08-19 12:47:38 +02:00
anatoly-os
3326b02ab6
Merge pull request #5195 from ericfont/291646-inspector-tour-on-mousepress
fix #291646 initiate inspector tour on mouse press
2019-08-19 12:29:40 +02:00
anatoly-os
e220f883f6
Merge pull request #5203 from ericfont/291756-signed-char-fluid-pitchadj
fix #291756 explicitly-signed char fluid pitchadj
2019-08-19 11:22:46 +02:00
anatoly-os
223d900f6e
Merge pull request #5206 from dmitrio95/291698-connect-tremolo-on-read
fix #291698: ensure consistent state of two-notes tremolo after file reading
2019-08-19 11:20:51 +02:00
anatoly-os
fb34dda4a0
Merge pull request #5263 from mattmcclinch/147031-tab-preview
fix #147031: Note symbols are truncated in Tab Preview
2019-08-19 11:05:09 +02:00
anatoly-os
58b6615fd8
Merge pull request #5268 from Jojo-Schmitz/tremolos
Fix #293242: Make Tremolo string translatable and plural
2019-08-19 10:50:11 +02:00