Commit graph

14 commits

Author SHA1 Message Date
Marc Sabatella
a780a36dea fix #301259
Resolves: https://musescore.org/en/node/301259

See also https://github.com/musescore/MuseScore/pull/5728/

The problem occurs in several different overrides to
getPropertyStyle() for various different text classes.
The function is supposed to determine
which Sid to use for Pid::OFFSET, based on placement above/below.
But that calculation should only be relevant
if the element is using the default text style for its type.
Otherwise it should use the offset in the current text style.

This code removes the overrides for getPropertyStyle() in each class,
instead modifying TextBase::getPropertyStyle() to check
if the element is using its default text style or not,
and then only if so does it use the placement to select a Sid.
Otherwise it uses the offset of the current text style.
2020-04-15 18:07:27 -06:00
Igor Korsukov
2a5af1c527 fixed virtual methods 2020-03-27 13:07:27 +02:00
ws
d77183b3bb refactoring of Element::userOff and TextBase::offset 2018-10-18 11:56:23 +02:00
ws
10ebbb9080 update text style implementation 2018-08-01 11:46:35 +02:00
ws
2934f93142 new style value frameType replacing hasFrame, circle, square 2018-07-26 13:14:06 +02:00
ws
6f6e86a03c fix #272366 There are no System Text properties 2018-05-28 14:20:53 +02:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
ws
6969419cfc update subStyle implementation 2018-03-21 14:05:43 +01:00
Werner Schweer
c68c9455d7 fix #268065: System text crashes the program when opening a file 2018-01-03 16:16:12 +01:00
Werner Schweer
e6175c5dda rearrange class hierarchy 2017-12-27 11:51:09 +01:00
Werner Schweer
0e4211e2d0 update let ring, palm mute 2017-11-27 16:55:52 +01:00
Werner Schweer
90b1991912 replace Q_OBJECT with Q_GADGET for all Element based classes 2017-02-17 15:48:28 +01:00
Werner Schweer
251c298821 more complete SystemText impl. 2017-01-23 10:54:57 +01:00
Werner Schweer
f8417ca046 add SystemText element 2017-01-20 11:05:52 +01:00