Commit graph

494 commits

Author SHA1 Message Date
Igor Korsukov
68b3415c47 fixed some issues from PVS-Studio report (step1) 2020-03-20 12:18:07 +02:00
Howard-C
3bc26748ea fix #301555 part 2: invisible glissandi occupy space 2020-03-07 18:07:48 +08:00
Howard-C
cda31c3382 fix #301555 part 1: invisible arpeggios occupy space 2020-02-25 20:49:57 +08:00
Howard-C
00faebef8c fix #301115: invisible articulations affect layout of other articulations
If the articulation is not visible, don't increase top/bottom distance from chord/staff for the next one.
2020-02-14 16:53:33 +08:00
luz.paz
f31624d746 fix various typos
* Found via `codespell -q 3 -S ./share/locale,./thirdparty -L ba,cann,clas,dur,foto,iff,nd,ois,ot,pres,possibile,snaped,strack,tage,te,uint,thru,valu`  
* Some revisions made per feedback given during review.
* Follow-up typos for review  
* Add revisions per feedback
2019-12-19 06:13:30 -05:00
Dmitri Ovodok
e3e498ce8e
Merge pull request #5383 from AntonioBL/tremolofixes
fix #288576 : strange results when changing time signature with tremo…
2019-12-05 14:58:13 +02:00
Dmitri Ovodok
2d140a341d Sort notes in a chord taking into account unison index of tied notes
Fixup to f6998a40e3: needed to avoid
a possibility to tie two different notes to one.
See https://github.com/musescore/MuseScore/pull/5506#issuecomment-560370517
2019-12-03 10:38:42 +02:00
AntonioBL
fb55f7e856 fix #288576 : strange results when changing time signature with tremolo between two notes 2019-11-25 16:05:23 +01:00
Dmitri Ovodok
6638eaf980
Merge pull request #5275 from mattmcclinch/293459-tied-unisons
fix #293459: Tie command does not properly handle chords with unisons
2019-11-18 11:48:19 +02:00
Matt McClinch
682e5b7742 fix #293459: Tie command does not properly handle chords with unisons 2019-09-11 14:04:37 -04:00
Matt McClinch
f94c4ca2e1 fix #294082: TAB - Mixing mensural value symbols and beaming in historic tablatures is broken.
TabDurationSymbol::layout2() is responsible for setting the _beamLength for the tab duration symbol, which is used to determine the length of the line to draw. Problem is, TabDurationSymbol::layout2() is only ever called from Chord::layoutStem(), and Chord::layoutStem() is not being called at all, except from ChordRest::removeDeleteBeam(). Therefore, _beamLength is always equal to 0, which results in zero-length lines being drawn.

This adds a call to TabDurationSymbol::layout2() from Chord::layout2(), so that _beamLength can be set to the correct value.
2019-09-06 10:24:30 -04:00
Matt McClinch
e53bd2725d fix #293897: [Tablature] Note value repeat section: setting "Never" broken
This followup to 3cd5154 makes sure not to create tablature duration symbols when "Repeat" is set to "Never".
2019-09-04 07:18:07 -04:00
anatoly-os
2a1fc1f5d7
Merge pull request #5261 from mattmcclinch/290011-tab-duration
fix #290011: [Tablature] Note value repeat section: "At new system" renders the same as "At new measure"
2019-08-29 12:23:42 +02:00
anatoly-os
d7c3b701d3
Merge pull request #5250 from Jojo-Schmitz/warnings
fix compiler warnings reg. comparing signed and unsigned and some unused parameters
2019-08-29 10:39:06 +02:00
Joachim Schmitz
3012c827dd fix compiler warning reg. comparing signed and unsigned and unused parameters
for some strange reason `QList::size()` returns `int` rather than
`size_t`, IMHO a bug in Qt, as even a `QList` can't have a negative
number of members.
And fix another warning reg. shadowing a local variable as well as reg.
some unused parameters
2019-08-27 12:10:27 +02:00
Joachim Schmitz
a53bac4711 replace slashStyle with stemless
and all related things along with it, including a compatibility layer
2019-08-19 15:07:30 +02:00
Marc Sabatella
320c1081e4 fix #281448, fix #283463: accessibility for articulations and lyrics
Articulations needed to be added to Chord::accessibleExtraInfo.
Also, refactoring was needed to move code around as a result of
articulations and fermatas being moved between Chord and ChordRest.
2019-08-17 10:44:58 +02:00
Matt McClinch
3cd5154f37 fix #290011: [Tablature] Note value repeat section: "At new system" renders the same as "At new measure" 2019-08-13 02:45:34 -04:00
Matt McClinch
cc885c15ae fix #292851: Note still played after having been deleted. 2019-08-03 09:54:24 -04:00
Dale Larson
b05c823912 Fix #291708: Expose PlayEvent's via QML Plugin Note interface.
Adds capablity to examine and modify PlayEvent's and a Note's
playEvents list. Adds access to Chord.playEventType. Also
supports UNDO for these operations.
2019-07-29 13:27:29 -05:00
Marc Sabatella
3b66ed7d34 fix #21131, fix #22882: bad ledger line size with small notes 2019-06-19 09:53:23 -06:00
Dmitri Ovodok
27989611ca
Merge pull request #5117 from dmitrio95/mdl_tremolo_fixes
Make it possible to place tremolo at stem center
2019-06-15 13:56:37 +02:00
Dmitri Ovodok
333ca7dc97 Implement tremolo placement at stem center
The following changes are included:
 - Corrected bounding box for buzzroll tremolo.
 - Added a possibility to place tremolo at stem center.
 - Reworked one-note tremolo layout to make it possible
   to know its dimensions before performing its layout
   on a stem.
 - Implemented padding around one-note tremolo to make it
   clearly separated from beams and noteheads.
2019-06-10 14:19:44 +02:00
Marc Sabatella
326fa22359 fix #289877: fingering affects layout with autoplace off 2019-05-31 20:25:15 -06:00
Marc Sabatella
30a5afe64a fix articulation layout for tablature 2019-05-23 00:51:00 -06:00
Marc Sabatella
ec96bdb7d1 fix #289548: incorrect initial layout of added articulations 2019-05-23 00:31:01 -06:00
anatoly-os
217a06a9fd
Merge pull request #5030 from MarcSabatella/scale-offset
Scale offsets with staff
2019-05-21 11:19:38 +02:00
Marc Sabatella
510b60ce45 fix #289312: offsets on elements of chords and rests not scaling with staff 2019-05-18 09:32:39 -06:00
Marc Sabatella
ddbb5c1266 fix #286882: apply layout range to continuous view + collect_artifacts 2019-05-15 16:57:06 -06:00
anatoly-os
66b30c3a81
Merge pull request #4982 from MarcSabatella/278999-customize-autoplace
allow autoplaced elements to cross into skyline
2019-05-13 12:13:23 +03:00
anatoly-os
b8f21788e8
Merge pull request #5006 from MarcSabatella/288976-stem-line-distance
fix #288976: stems too long on staves with scaled line distance
2019-05-11 10:45:34 +02:00
Marc Sabatella
ec644982ae fix #288993: bad skyline for cross staff articulations and stems 2019-05-10 11:33:14 -06:00
Marc Sabatella
4298b0a0b3 flip fretboard diagrams 2019-05-10 09:48:28 -06:00
Marc Sabatella
83793794c7 fingering fixes + collect_artifacts 2019-05-09 22:46:59 -06:00
Marc Sabatella
c7a85c05e2 fix #285811: don't make chord-based fingerings part of note shape 2019-05-09 22:46:58 -06:00
Marc Sabatella
3550ff9f06 fix #288976: stems to long on pitched/percussion staves with scaled line distance 2019-05-09 22:39:09 -06:00
Marc Sabatella
6b7f33ec64 fix #278999, fix #288474: autoplace customization 2019-05-01 07:52:11 -06:00
Marc Sabatella
77c8f3de05 fix #283473: grace note after collides with accidental 2019-04-19 12:44:17 -06:00
Marc Sabatella
286a5285bb fix #282026: scale stem displacement 2019-04-11 06:36:32 -06:00
James Thistlewood
9b6bdd7a7f fix #282698: undoing timesig change with tremolo causes crash 2019-03-05 11:52:59 +00:00
Marc Sabatella
bda0dd2345 fix #280428: tab beams added to skyline 2019-02-19 15:48:14 -07:00
anatoly-os
9202c93aa8
Merge pull request #4658 from MarcSabatella/283732-grace-articulation
fix #283732: articulations not laid out on grace notes
2019-02-18 20:09:56 +02:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
Marc Sabatella
558bfe0b4d fix #283732: articulations not laid out on grace notes 2019-02-15 13:25:38 -07:00
Marc Sabatella
300cfac6ed fix #283157, fix #283180, fix #283323: fingering layout glitches 2019-02-06 21:56:18 -07:00
MarcSabatella
8942ed8a7b fix #280807: improve fingering layout (for piano & guitar) 2019-01-27 08:44:42 -07:00
Marc Sabatella
bbbe1f68e8 fix #280677, fix #279643: semantics of disable autoplace on stems et al 2019-01-11 18:26:22 -07:00
anatoly-os
806e4d94dc
Merge pull request #4444 from dmitrio95/tremolo-crash-and-copypaste
fix #278964: rework duration types handling with tremolo
2018-12-21 16:03:34 +02:00
ws
483740b42e fix #280095 Crash on part generation in the presence of tremolos 2018-12-19 14:53:07 +01:00
Dmitri Ovodok
62f5d132bf fix #280095, fix #278964: rework duration types hanling with tremolo 2018-12-19 15:42:47 +02:00