Commit graph

24915 commits

Author SHA1 Message Date
Casper Jeukendrup
4a8e53a23e
Repaint PaletteWidget when adding element
Also, quite unrelated, use new style signal/slot connect in DrumsetPalette.
2022-04-01 21:35:45 +02:00
RomanPudashkin
1baa77dd3e
Merge pull request #11043 from cbjeukendrup/recent_files_with_comma
Fix storing list of recent files if a filename contains commas
2022-04-01 10:49:40 +02:00
RomanPudashkin
ed83f5ebb4
Merge pull request #11045 from cbjeukendrup/fix_pitch_names_with_negative_octave
Fix MIDI Pitch Names
2022-04-01 10:47:25 +02:00
RomanPudashkin
43245f9be7
Merge pull request #11046 from cbjeukendrup/optimize_styled_text_label
StyledTextLabel: only create MouseArea if really necessary
2022-04-01 10:45:41 +02:00
RomanPudashkin
c7f3002eca
Merge pull request #11025 from mike-spa/correctContinuousViewSpacing
Fix spacing in continuous view
2022-04-01 10:34:58 +02:00
Casper Jeukendrup
9394f6361e
StyledTextLabel: only create MouseArea if really necessary
Only needed when a link is hovered
2022-03-31 23:54:59 +02:00
Casper Jeukendrup
12c88d386f
Fix MIDI Pitch Names
Seen in Preferences > MIDI device mapping > Assign.
2022-03-31 23:43:49 +02:00
Casper Jeukendrup
f17e9ea16f
Fix storing list of recent files if a filename contains commas
Store them as JSON, not as comma-separated list of unencoded paths.
2022-03-31 23:14:25 +02:00
RomanPudashkin
59feb1e1d5
Merge pull request #11030 from RomanPudashkin/empty_inspector
[MU4] Empty inspector
2022-03-31 22:54:05 +02:00
RomanPudashkin
f39baea731
Merge pull request #11028 from cbjeukendrup/fix_hit_grip
Fix hitting grip if grip overlaps with other elements
2022-03-31 19:14:30 +02:00
RomanPudashkin
7e268f5a29
Merge pull request #11032 from RomanPudashkin/main_toolbar
[MU4] Fix #10859: Score tab should indicate if it has an opened score when switching to other tabs
2022-03-31 18:26:53 +02:00
Roman Pudashkin
525d4247b3 fix #10859: the Score tab will now indicate whether the project is open 2022-03-31 17:50:31 +02:00
Roman Pudashkin
099de027c5 removed the redundant "Toggle piano roll" item from the app menu 2022-03-31 17:06:21 +02:00
Roman Pudashkin
5b5ac90367 fixed the empty inspector after opening the Score page 2022-03-31 17:02:38 +02:00
RomanPudashkin
064eb06ab7
Merge pull request #10926 from cbjeukendrup/onscreen_piano
Implemented On-screen Piano Keyboard
2022-03-31 16:28:27 +02:00
RomanPudashkin
ee9e416695
Merge pull request #11001 from cbjeukendrup/fix_windows_full_screen_shortcut
Fix keyboard shortcut for full screen
2022-03-31 16:26:02 +02:00
Casper Jeukendrup
c7397bb00f
Fix hitting grip if grip overlaps with other elements 2022-03-31 16:15:57 +02:00
Michele Spagnolo
3887697903 fix spacing in continuous view 2022-03-31 14:12:49 +02:00
RomanPudashkin
7fa89d396f
Merge pull request #10980 from RomanPudashkin/measures_width
[MU4] Fix #10973: Score becomes total empty in continuous view
2022-03-31 12:37:36 +02:00
Casper Jeukendrup
0920c510c7
PianoKeyboard: minor improvements and code review fixes
- no more magic numbers
- follow Figma more precisely
- push down octave labels if they would otherwise (nearly) overlap the black keys
- small code quality improvements
2022-03-31 12:10:35 +02:00
Casper Jeukendrup
1cb02191cc
PianoKeyboard: minor improvements for rendering
Fix corner radius and exact size and position of black keys
2022-03-31 12:10:35 +02:00
Casper Jeukendrup
8b9bcec895
PianoKeyboard: let C4 be the middle C 2022-03-31 12:10:35 +02:00
Casper Jeukendrup
ebecf05787
PianoKeyboard: highlight notes that are selected on the score 2022-03-31 12:10:35 +02:00
Casper Jeukendrup
a90a1e3d4e
PianoKeyboard: implemented playing notes to input them 2022-03-31 12:10:34 +02:00
Casper Jeukendrup
4870596a90
PianoKeyboard: add scroll bar 2022-03-31 12:10:34 +02:00
Casper Jeukendrup
a88314eb65
PianoKeyboard: implemented setting scaling from context menu 2022-03-31 12:10:34 +02:00
Casper Jeukendrup
6cc9f46788
PianoKeyboard: draw black keys with corner radius 2022-03-31 12:10:34 +02:00
Casper Jeukendrup
c76582331c
PianoKeyboard: make scrolling more advanced
And make PinchToZoom work on Windows
2022-03-31 12:10:34 +02:00
Casper Jeukendrup
782e64829a
PianoKeyboard: implemented basic zooming and scrolling 2022-03-31 12:10:33 +02:00
Casper Jeukendrup
172cd9d32b
Added PianoKeyboardPanelContextMenuModel to set number of keys 2022-03-31 12:10:33 +02:00
Casper Jeukendrup
035be893d8
PianoKeyboard: Implemented basic drawing of piano keys 2022-03-31 12:10:33 +02:00
Casper Jeukendrup
0394f3b7f6
Add a panel for the Piano Keyboard 2022-03-31 12:10:33 +02:00
Casper Jeukendrup
cb0a3b3f94
Fix compiler warnings reg. uninitialized variables 2022-03-31 12:10:32 +02:00
Joachim Schmitz
40e1ccc6e9 Improve log/assert messages 2022-03-31 14:18:20 +06:00
Joachim Schmitz
24ef2b96e9 Fix/deal with warnings reg unreachable code
seen when building in VS/MSVC in Debug mode
2022-03-31 14:18:20 +06:00
Joachim Schmitz
a883e29eb2 Fix compiler warnings
reg. size_t, some other comparisons between signed and unsigned and some
unhandled cases. Also some unused variables and paremeters, a possibly
unintilalized variable and a possible return without value.
2022-03-31 14:18:20 +06:00
Casper Jeukendrup
9c9c4ec037 Simplify creating Promises
Less typing, less reading

We can now make this `auto` simplification because we give the compiler information about the expected type of the promise body.
2022-03-31 14:17:22 +06:00
Casper Jeukendrup
112d29d931 Enforce that Promise body resolves OR rejects exactly once
We now enforce that the body of a promise returns a "Result" struct. Such a struct can only be obtained by calling "resolve" or "reject".
Additionally, if you call "resolve" or "reject" without using its result, `Q_REQUIRED_RESULT` will kick in and give you a compiler warning. So you either have to return it (which you should do), or you use it in another way, which is impossible to do unconsciously.

The only disadvantage is that you now have to write `return resolve` etc. instead of just `resolve`, but the advantages are bigger.
2022-03-31 14:17:22 +06:00
Casper Jeukendrup
f57078bca1 Simplify getting single arg from NotifyData 2022-03-31 14:17:22 +06:00
RomanPudashkin
81e70ebc62
Merge pull request #10978 from cbjeukendrup/fix_more_tie_crashes
Fix more tie crashes
2022-03-31 10:07:30 +02:00
RomanPudashkin
ffcb7857f4
Merge pull request #10996 from cbjeukendrup/fix_error_messages
Fix some debug/error messages that were printed to the console
2022-03-31 10:04:36 +02:00
RomanPudashkin
2b93e8afca
Merge pull request #10988 from cbjeukendrup/select_nothing_on_start
Nothing should be selected on the score when a new score is created, or an existing score opened
2022-03-31 10:00:40 +02:00
RomanPudashkin
67639703a9
Merge pull request #11000 from cbjeukendrup/editstyle_fix_pages_order
Fixes for Edit Style dialog
2022-03-31 09:58:17 +02:00
Casper Jeukendrup
d78c6f9227
Fix keyboard shortcut for full screen
- Remove "Meta+Ctrl+F" for non-macOS platforms, where it is not common
- Make it the primary shortcut on macOS, where it is standard
2022-03-31 00:13:20 +02:00
Casper Jeukendrup
b1790a06e7
Fix drawing checked flat QPushButtons 2022-03-30 23:57:58 +02:00
Casper Jeukendrup
47f6b05774
Remove the ability to change the order of the pages in the Edit Style dialog
This feature is only confusing, and did not work reliably.

Fixes https://github.com/musescore/MuseScore/issues/10755
2022-03-30 22:56:02 +02:00
Casper Jeukendrup
91af9ebb76
Fix warnings like "QPainter::font: Painter not active" 2022-03-30 22:38:28 +02:00
Casper Jeukendrup
999bb0d38f
Fix error messages about invalid property of Dynamic 2022-03-30 22:03:06 +02:00
Casper Jeukendrup
74cdd015b5
Fix error messages about mismatching property types 2022-03-30 22:03:06 +02:00
Casper Jeukendrup
5c47b2c380
Fixed navigation focus border in NotationSwitchButton.qml 2022-03-30 20:00:35 +02:00