Commit graph

232 commits

Author SHA1 Message Date
Dmitri Ovodok
2f443cf898 Fix inability to horizontally move hairpin with its middle or left handle with mouse 2019-12-24 14:16:06 +02:00
Dmitri Ovodok
5c3b407dae Move setting up grips out of Element::startEdit() 2019-12-24 14:16:06 +02:00
Marc Sabatella
b995287630 fix #294728: min distance not saved for lines unless offset changed too
If you move a line into the skyline (e.g, overlapping other elements),
we reduce the min distance automatically and save the result correctly.
But if you reduce the min distance manually via the Inspector
but don't change the offset, then save, the min distance is not written.
That is because we check if the line has been modified before writing these properties.
But we were only checking offset and offset2, not min distance.
This change adds that check.
2019-09-24 08:32:19 -06:00
Marc Sabatella
d2278d6742 fix #287871: volta line not drawn before start repeat 2019-07-13 22:14:07 -06:00
Matt McClinch
f05914f316 fix #288508: Bad layout of lines (text line, trill line...) before start repeat 2019-06-16 16:30:29 -04:00
Dmitri Ovodok
a5a5255b0e
Merge pull request #5023 from mattmcclinch/75626-change-voice
fix #75626, fix #287520, restructure ChangeSpannerElements
2019-06-14 11:22:24 +02:00
Marc Sabatella
168d240898 fix #290040: line min distance not saved, so won't stay within skyline 2019-05-31 12:19:14 -06:00
Marc Sabatella
41987edbdd fix glissando regression 2019-05-22 12:30:44 -06:00
Marc Sabatella
edb15d9b0f fix #289423: correct origin for note anchored lines 2019-05-20 13:04:34 -06:00
Matt McClinch
619c6d7b33 fix #287520: Glissando with anchor change via Shift+Down lost on save/reload 2019-05-17 14:33:22 -04:00
Marc Sabatella
ffc17b4f3a fix #287445, fix #287484, fix #284074: line style issues 2019-05-14 20:57:47 -06:00
Marc Sabatella
ef300d1cea implement minDistance per element 2019-05-09 22:46:58 -06:00
Marc Sabatella
fafa6cadcc working version 2019-05-09 22:46:58 -06:00
Marc Sabatella
cf52824b67 remove ABS_OFFSET property + collect_artifacts 2019-05-09 22:46:58 -06:00
Marc Sabatella
77f908bc58 allow autoplaced elements to cross into skyline 2019-05-09 22:46:58 -06:00
Matt McClinch
07451700d2 fix #288508: Bad layout of lines (text line, trill line...) before start repeat 2019-05-01 00:14:15 -04:00
Marc Sabatella
17c3bfaeeb fix #285602: note line does not appear until reload 2019-04-24 15:51:26 -06:00
Marc Sabatella
812a2811b9 fix #283312: adjusted hairpins on small staves shift on save/reload 2019-04-11 06:36:32 -06:00
anatoly-os
9cc6c01633
Merge pull request #4779 from peterhieuvu/285383-line-saving
fix #285383, fix #282191 save line properties, set propery default properties for let ring and palm mute, fix hook line drawing
2019-04-10 11:08:14 +02:00
Dmitri Ovodok
c789322faa Allow copy-pasting hairpins and hairpin+dynamics combinations 2019-03-27 10:24:08 +02:00
Peter Hieu Vu
e1d0ccefa8 fix #285383, fix #282191 save line properties, but only properties needed, set propery default properties for let ring and palm mute 2019-03-08 00:52:39 -08:00
anatoly-os
efdf43d96f
Merge pull request #4697 from jthistle/282404-line-color-save
fix #282404: line colour not saved
2019-02-18 15:35:39 +02:00
James Thistlewood
43b1d5f050 fix #282404: line colour not saved 2019-02-18 12:08:42 +00:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
MarcSabatella
0a5e55ebdf fix #280366: voltas should ignore disabled header segments 2018-12-20 14:10:20 -07:00
Joachim Schmitz
88d37365a6 fix compiler warnings, seen in MinGW and MSVC 2018-12-12 14:03:43 +01:00
mirabilos
77983234c8
some spelling fixes
most from the spell checker built into Debian’s automated
package checking tool lintian, two from me during applying
those lintian-suggested fixes
2018-11-27 22:49:18 +01:00
Dmitri Ovodok
f42943e90b fix #278722: do not delete spanner segments but reuse them 2018-11-26 01:59:02 +02:00
Dmitri Ovodok
239c57194b fix #277693: Fix melisma intersecting with lyrics syllables
This patch:
1) Makes melisma be spanned not less that to the right edge of the
first note.
2) Adds a value to a width of "temporary" short melisma equal to the
lyrics syllable's width (which was done so in MuseScore 2).
2018-11-15 17:03:44 +02:00
ws
5f4482d7c8 fix: save manual editing of slurs 2018-11-07 10:46:28 +01:00
Dmitri Ovodok
c95dfd5a40 Make it possible to record elements written to MSCX 2018-10-29 16:30:19 +02:00
ws
6dbff17ca7 fix compat114 issues 2018-10-26 10:41:30 +02:00
ws
96af32eee7 fix regressions: layout of misc. elements 2018-10-25 15:44:21 +02:00
ws
edeabec275 do not disable autoplace when dragging element 2018-10-24 11:32:11 +02:00
ws
d77183b3bb refactoring of Element::userOff and TextBase::offset 2018-10-18 11:56:23 +02:00
Joachim Schmitz
b8810ed9e5 fix #275218: fix MSVC C4065 and C4701 warnings
ref. a `switch` without any `case` and the use of a
possibly uninitialized variable.
Also fix yet another few C4456.
Also disable one warning less for portmidi as it doesn't happen anyway
(anymore?)
2018-09-27 17:47:23 +02:00
ws
92d8c616e0 fix #268119 Ottava line lenght wrong 2018-09-26 18:44:40 +02:00
ws
74eda99423 update layout of LyricsLine 2018-09-25 10:36:01 +02:00
Dmitri Ovodok
c354eb24c3 Remove read300 functions 2018-09-19 01:57:37 +03:00
Dmitri Ovodok
104898195b Read and write spanners using the connectors framework
Remove IDs for spanners
2018-08-16 19:10:28 +03:00
ws
10d1ae0529 add method propertyDelegate() to Element 2018-07-24 15:48:24 +02:00
ws
e1845b8682 fix: volta line length too short in some situations 2018-07-20 10:53:13 +02:00
ws
cb43b90e5a more updates for lyrics 2018-07-02 10:24:58 +02:00
ws
04de06e2e1 update for lyrics layout 2018-06-29 13:33:59 +02:00
ws
94eaac8c67 fix #272058 Backward compatibility of previous versions files (1.2 and 1.3) 2018-05-14 10:07:56 +02:00
ws
d31cfd9885 add Stem to inspector 2018-05-07 19:05:49 +02:00
anatoly-os
4facafc468 fix #271529: incorrect stem position for some noteheads in layout
Implemented correct notehead bbox width and origin calculations. Fixed
note and chord stems, ledger lines, beams, dots, articulation, slur and chord positions.
2018-05-05 10:34:45 +02:00
ws
d0117b1459 fix #272022 Backward compatibility of previous versions files 2018-05-04 14:39:14 +02:00
ws
af29311ec4 remove Element->_readPos 2018-04-30 16:08:25 +02:00
ws
47dd40114b fix #271145: Changing Dynamic Range for hairpins lead to crash 2018-04-13 18:07:58 +02:00