Commit graph

17130 commits

Author SHA1 Message Date
Matt McClinch
f18b6f7418 fix #291957: Mixer causes piano to disappear off screen.
Resolves: https://musescore.org/en/node/291957.

The mixer needs to be able to shrink in order to accomodate the piano keyboard if it is made visible. Decreasing the minimum height for the QScrollArea that contains the mixer sliders allows this to happen.
2019-12-06 09:41:44 -05:00
Dmitri Ovodok
eb667940a9
Merge pull request #5455 from MarcSabatella/293301-read-location
fix #293301: add get-location command to read current location
2019-12-06 09:46:16 +02:00
Dmitri Ovodok
ebf2b5565e
Merge pull request #5517 from MarcSabatella/sectionbreak-build
fix Linux build (remove sectionbreak.ui)
2019-12-06 09:45:43 +02:00
Dmitri Ovodok
8d75b32e75
Merge pull request #5516 from mattmcclinch/298115-start-note-entry
fix #298115: Replacing a note with an accidental leaves accidental on new note
2019-12-06 09:45:28 +02:00
Marc Sabatella
ea02b2e10a fix #293301: add get-location command to read current location
We have optimized the screenreader feedback when navigating
to only mention measure and staff if it has changed.
Blind users can easily lose track of where they are, however,
so this adds a new command "Get Location" that forces a full read.
It also re-establishes a lost selection (the last-selected note or rest),
which can also be useful for sighted users,
although Alt+Left/Right already re-established the location before beginning navigation.

Eventually I would like the new "Get Location" command
to read the current key and time signature.
Right now, though, it is is not straightforward to force the screenreader to do this,
I left it as a TODO in the code.
2019-12-05 11:39:47 -07:00
MarcSabatella
c60c19c53c fix Linux build (remove sectionbreak.ui) 2019-12-05 11:03:39 -07:00
Matt McClinch
05ed180bc6 fix #298115: Replacing a note with an accidental leaves accidental on new note
Resolves: https://musescore.org/en/node/298115.

This makes sure that ScoreView::startNoteEntry() clears the accidental state. Since this function already properly sets the duration and rest states, none of this needs to happen directly from within ScoreView::cmd().
2019-12-05 11:37:41 -05:00
Joachim Schmitz
cf211fd3b2 fix a compiler warning
about reaching end of non-void function
2019-12-05 16:08:55 +01:00
Dmitri Ovodok
a6c04d4949 Ask user for a name of the newly created custom palette 2019-12-05 15:10:09 +02:00
Dmitri Ovodok
5afaf8f12a Enable pushing new strings to Transifex 2019-12-05 15:06:41 +02:00
Dmitri Ovodok
f8de0812b6
Merge pull request #5482 from Jojo-Schmitz/straight
fix #297329: add Straight (tempo) text to master palette
2019-12-05 15:02:46 +02:00
Dmitri Ovodok
e3e498ce8e
Merge pull request #5383 from AntonioBL/tremolofixes
fix #288576 : strange results when changing time signature with tremo…
2019-12-05 14:58:13 +02:00
Dmitri Ovodok
5a0ad44cfb
Merge pull request #5443 from mattmcclinch/296329-instrument-change-mmrest
fix #296329: Instrument change should be able to apply to multimeasure rest
2019-12-05 14:57:26 +02:00
Joachim Schmitz
0e92f97c3d fix #297329: add Straight (tempo) text to master palette 2019-12-05 13:47:57 +01:00
Dmitri Ovodok
ee9b44f069
Merge pull request #5405 from Howard-C/sort-size
fix #295895: language list in Resource Manager sorted by size is sorted in the style of string rather than that of number
2019-12-05 14:42:11 +02:00
Dmitri Ovodok
2228f94822
Merge pull request #5462 from Howard-C/section-break-properties
move Section Break Properties into Inspector
2019-12-05 14:40:51 +02:00
Dmitri Ovodok
ed0d4cd0d2
Merge pull request #5425 from shoogle/rnib-hairpin-speech
Accessibility: Improve speech for chordrests with spanners
2019-12-05 14:36:26 +02:00
Dmitri Ovodok
8f107f34dc
Merge pull request #5451 from dmitrio95/296426-mmrest-barline-text-links
fix #296426: fix not linking multiple elements at the same tick in MM rests on score loading
2019-12-05 14:34:25 +02:00
Dmitri Ovodok
ee52c21d10
Merge pull request #5461 from mirabilos/native-dialogues-by-default
Default to native file dialogues (needed to fix directory bookmarks) also on Linux
2019-12-05 14:25:57 +02:00
Dmitri Ovodok
d243bcea83
Merge pull request #5477 from MarcSabatella/281253-spacer-down-system
fix #281253: staff spacer down ignored on bottom of page
2019-12-05 14:15:22 +02:00
Dmitri Ovodok
90be292944
Merge pull request #5458 from MarcSabatella/295892-barline-before-frame
fix #295892: barline not displayed before horizontal frame / start repeat
2019-12-05 14:06:22 +02:00
Matt McClinch
573280f1ca fix #298121: Adding Intervals (above/below) should take into consideration the accidental toggle state
Resolves: https://musescore.org/en/node/298121.

In addition to making the "Add Interval" commands apply the highlighted accidental when in note input mode, I have corrected a few cases where I had chosen the wrong tpc to use to calculate the AccidentalType for a user accidental, given the current value of styleB(Sid::concertPitch).
2019-12-04 23:07:55 -05:00
Dmitri Ovodok
e8b9f9c038 Add mtest for workspaces editing 2019-12-04 11:12:11 +02:00
Dmitri Ovodok
c194377dc7 Improve testing infrastructure
- Improve ability to test mscoreapp in mtest framework
 - Expand testutils
2019-12-04 11:11:58 +02:00
Dmitri Ovodok
917ce4059e Update and rework certain mtests
- Update and re-enable tests for QML-based plugins
 - Remove mtest-specific #define's in plugins API code
 - Make midimapping test compile
 - Convert mtest/test.mscx to MuseScore 3 file format
 - Remove unused files in mtest/
2019-12-04 11:11:45 +02:00
Dmitri Ovodok
c06f096c5b Make it possible to link mtests with mscoreapp 2019-12-04 11:11:31 +02:00
Dmitri Ovodok
e519e518f5 Move main() function out of mscore directory 2019-12-04 11:11:14 +02:00
Dmitri Ovodok
9b481e48c0 Splitting mscore/CMakeLists.txt: restore CMakeLists.txt 2019-12-04 11:05:22 +02:00
Dmitri Ovodok
354546e2ff Merge branch 'create_main_cmakelists_txt2' into mtest 2019-12-04 11:03:41 +02:00
Dmitri Ovodok
80fd2f5b91 Splitting mscore/CMakeLists.txt: temporarily rename CMakeLists.txt 2019-12-04 11:02:29 +02:00
Dmitri Ovodok
d359d4ffcb Splitting mscore/CMakeLists.txt: create main/CMakeLists.txt 2019-12-04 11:01:23 +02:00
Dmitri Ovodok
deaa3f3481 Split main() function
- Extract parseCommandLineArguments()
 - Extract initApplication()
 - Extract MuseScore::init()
2019-12-04 10:58:42 +02:00
anatoly-os
c7ab61ec08
Merge pull request #5510 from dmitrio95/298061-set-as-style-viewport-crash
fix #298061: fix a crash on "set as style" if score ends with a frame
2019-12-04 10:10:58 +02:00
Dmitri Ovodok
a96b72c2fe fix #298061: fix a crash on "set as style" if score ends with a frame
- Don't pass staff number to adjustCanvasPosition if trying to
   adjust viewport to a frame. This avoids a crash itself.
 - Implement a more robust approach to determine a measure relevant
   to the current edit operation in CmdState. This avoids trying to
   unnecessarily jump to the frame at the end of a score.
2019-12-04 02:22:55 +02:00
anatoly-os
541d86dd82 grab strings from 3.4 resources
Switch resource manager to 3.4 directories on S3
2019-12-03 15:21:54 +02:00
anatoly-os
912b65c03f update master to version 3.4.0 2019-12-03 15:16:37 +02:00
Dmitri Ovodok
431961b436
Merge pull request #5507 from Howard-C/courtesy-accidental
fix #292648: make courtesy accidentals stay if notes are changed using Ctrl+Up/Down
2019-12-03 12:35:28 +02:00
Dmitri Ovodok
2d140a341d Sort notes in a chord taking into account unison index of tied notes
Fixup to f6998a40e3: needed to avoid
a possibility to tie two different notes to one.
See https://github.com/musescore/MuseScore/pull/5506#issuecomment-560370517
2019-12-03 10:38:42 +02:00
Dmitri Ovodok
116f3eb8a9
Merge pull request #5506 from mattmcclinch/297957-search-tie-note
fix #297957: Ties extended in region after time signature change
2019-12-03 10:37:51 +02:00
Dmitri Ovodok
aedc6cf416
Merge pull request #5509 from lvinken/musicxml-fixes
Fix MusicXML header handling as requested by OpenScore Lieder Corpus project
2019-12-03 09:33:54 +02:00
Dmitri Ovodok
acd6f78608
Merge pull request #5480 from MarcSabatella/297287-palette-scale
fix #297287: scale palettes with monitor resolution +collect_artifacts
2019-12-03 09:33:34 +02:00
Howard-C
b258c85c58 fix #292648: make courtesy accidentals stay if notes are changed using Ctrl+Up/Down 2019-12-03 09:39:43 +08:00
MarcSabatella
543bd66e4e let default palette scale float between 0.75 and 1.0 2019-12-02 15:46:14 -07:00
MarcSabatella
9ac56a76e0 change default palette scale to 0.8 2019-12-02 10:52:56 -07:00
MarcSabatella
2438f34327 cleanup +collect_artifacts
The reimplementation of scaling for the old palettes works
by scalingreferences to extraMag and grid size.
I do this on the fly, when drawing the palette, working with position,
and when calculating absolute sizes.
But the main data structure continues to store the mag & grid
is in "logical" units, so no additional scaling needs to be done
on read/write.
This is more along the lines of how the QML palettes are handled,
except that code is much simpler because it all gets funneled
through a single function.
2019-12-02 06:59:07 -07:00
MarcSabatella
add7905b29 reimplement scaling of old palettes dynamically +collect_artifacts 2019-12-02 06:59:07 -07:00
MarcSabatella
66765c6c2a fix #297287: scale palettes with monitor resolution +collect_artifacts
MuseScore 2 used to scale the palettes according to screen resolution,
so they were the same physical size on all systems.
This was broken in MuseScore 3 development, so palettes are too small
on high DPI systems and too large on low DPI systems.
This fixes the issue by reinstating the code in palette.cpp
that scales the grid and mag by the global guiScaling setting
(same setting used to scale the score view itself).
That only affects places int he code where the "old" palettes
are still used - keysig and timedig dialogs, etc.
Similar but much code accomploishes the same in palettemodel.cpp
for the "new" palettes.

In addition, because users may *prefer* larger or smaller palettes,
I added an advanced preference to specify global palette scaling
(applied on top of the automatic DPI scaling).
This value is factored in to the main palette scaling.
2019-12-02 06:59:07 -07:00
Dmitri Ovodok
3d9c900d32
Merge pull request #5481 from Jojo-Schmitz/segment-violation
fix #297326: Crash on opening Musescore 2.x file that uses leading space setting on the initial clef
2019-12-02 13:52:04 +02:00
Dmitri Ovodok
c8a27535c2 fix #297468: fix a crash on reading a corrupted score with linear layout mode in part
In a corrupted score tick values may sometimes be not synchronized
between master score and parts. This may lead to incorrect setting
of layoutAll flag as ticks from different scores are compared.
Ensuring that only master score ticks are compared fixes layoutAll
flag for scores corrupted that way and prevents a crash due to not
making a full layout on score loading. This change makes no
difference for correctly saved scores.
2019-12-02 12:24:41 +02:00
Dmitri Ovodok
cf80fd34df fix #297614: fix moving viewport to irrelevant position when editing spanner segment 2019-12-02 12:23:47 +02:00