Commit graph

16873 commits

Author SHA1 Message Date
Dmitri Ovodok
ec5576a0a6 Fix welcome tour
- Implement shadow overlay for QML palettes
 - Fix showing menu bar in welcome tour
2019-11-23 13:19:54 +02:00
Dmitri Ovodok
a25d975e99 Change "Tie" button icon 2019-11-23 13:19:54 +02:00
Dmitri Ovodok
966ddc23a0 Rework tie button logic when out of note input mode
Now "Tie" button:
 - is highlighted when all selected notes have ties;
 - if any ties can be added, adds ties;
 - if no ties can be added, removes existing ties.
2019-11-23 13:19:54 +02:00
Dmitri Ovodok
d34f1b838d Enable changing notes duration if selecting note stem, hook or a range 2019-11-23 13:19:54 +02:00
Dmitri Ovodok
85eb26a5eb Warn for note being out of instrument range if note is selected 2019-11-23 13:19:54 +02:00
Dmitri Ovodok
8507224ccd fix #294613: disable overshooting boundaries when scrolling palettes 2019-11-23 13:19:54 +02:00
Dmitri Ovodok
fd822a5ef6 Remove "Choose your workspace" page from Startup Wizard 2019-11-23 13:19:54 +02:00
Dmitri Ovodok
09570742b7 Always show palette cell when dragging it to a score 2019-11-23 13:19:53 +02:00
Dmitri Ovodok
2d3b4d6e8c Visual changes for palettes
- Show three dots button in palettes only when palette is hovered or expanded
 - Move "Create custom palette" button to the top of "Add palettes" popup
 - Change default width for palettes
 - Change default grid size for custom palettes
 - Change arrow and ellipsis icons
 - Highlight buttons and palette cells on hovering
 - Change highlight color for selected palettes
 - Stretch last cell in a row in palettes
2019-11-23 13:19:53 +02:00
Joachim Schmitz
2343c00a9e Fix MinGW and MSVC compiler warnings 2019-11-22 15:44:50 +01:00
Dmitri Ovodok
49fedc47c4 fix #297428: crash on copying measure with slur and pasting it to TAB staff
1) Fix incorrect track2 assignment to spanners on pasting in some
situations due to not handling the case of track2 == -1.
2) Fix staff index checks in ScoreView code to avoid a crash if
incorrect staff index gets recorded to CmdState.
3) Add an assertion to catch invalid negative staff indices recorded
to CmdState.
2019-11-22 16:17:51 +02:00
Dmitri Ovodok
ba07089407 fix #296915: honor slur properties when adding slur from a palette 2019-11-22 16:16:59 +02:00
Dmitri Ovodok
bd7fde69c5 fix #295465: ensure that elements added from plugins belong to a correct score 2019-11-22 16:15:32 +02:00
Dmitri Ovodok
dc804994c9
Merge pull request #5397 from eduardomourar/feature/292474-ambitus-crash-plugin
fix #292474: Ambitus crash in plugins
2019-11-22 16:14:52 +02:00
Dmitri Ovodok
145ffc0309 Adjust double-click value for mixer sliders
Fixup for 8bac1fddde

Also remove connection to a PlayPanel's gainChange signal which
doesn't exist anymore.
2019-11-22 15:04:32 +02:00
Dmitri Ovodok
a71839a071
Merge pull request #5213 from Obliquely/obq-playpanel-double-click
Fix #291901 & Fix #291453 Double-click resets Master Volume
2019-11-22 15:04:09 +02:00
Dmitri Ovodok
96cc395f87
Merge pull request #5402 from MarcSabatella/palette-search-shortcut
add palette search shortcut
2019-11-22 09:56:16 +02:00
Dmitri Ovodok
505c0bcfb0
Merge pull request #5453 from MarcSabatella/296416-accessible-popup
partial fix #296416: accessibility of popup menu
2019-11-22 09:54:27 +02:00
Dmitri Ovodok
460c6c90ec
Merge pull request #5346 from lvinken/19244-musicxml-import-reversed-wedge
fix #19244 - [MusicXML import] reversed wedge not imported
2019-11-22 09:52:59 +02:00
Leon Vinken
c4bde89b15 fix #19244 - [MusicXML import] reversed wedge not imported 2019-11-21 21:26:00 +01:00
Marc Sabatella
c67620f9d9 partial fix #296416: accessibility of popup menu
Windows defines a menu key allow context menus to be operated by keyboard.
We are triggering the popup menu in this case, but getting the wrong element:
we should be using the selection, not the element near the mouse.
This changes ScoreView::contextMenuEvent() to check for keybaord as reason,
and set the element appropriately if so.

Currently screenreader support for the context menu is still limited,
so I will update this if/when I figure that out.
2019-11-21 09:51:38 -07:00
Dmitri Ovodok
336e1e59b0
Merge pull request #5469 from vpereverzev/master
fix #297008 : note_input_mode_selection
2019-11-21 13:31:36 +02:00
Dmitri Ovodok
5f079ced2c fix #52906, fix #279990, fix #288019: relax restrictions on pasting to tuplets
1) Pasting symbol lists (lyrics, dynamics, chord symbols etc.) to
tuplets work correctly so we don't need to impose any restrictions
here.

2) Pasting a staff range to the first chord/rest of a tuplet correctly
replaces the tuplet with the clipboard content. We need to restrict
pasting a range only if trying to paste to the middle of a tuplet.
2019-11-21 12:29:33 +02:00
Dmitri Ovodok
5903bbcae7
Merge pull request #5452 from Howard-C/copy-crash
fix #296591: pasting two voices on multimeasure rests leads to crash
2019-11-21 10:20:54 +02:00
Dmitri Ovodok
75c7759276
Merge pull request #5476 from MarcSabatella/297152-clone-pixmap-crash
fix #297152: crash on Ctrl+Shift+drag on Linux (under ChromeOS)
2019-11-21 10:20:10 +02:00
pereverzev_v
8562cdae63 fix #297008 Repeated behavior of transition to note input mode accordingly to cases when no items selected
Turn on note input mode by toggling pad even if user selection is on the text element for example
2019-11-21 10:08:25 +02:00
mirabilos
d4daf7e7fe
fix appstream validator warning (no URLs allowed inside text)
also, fix a space before colon to look consistent
2019-11-20 22:05:46 +01:00
Marc Sabatella
4395d0f26e add palette search and missing accessibility shortcuts 2019-11-19 15:18:41 -07:00
Dmitri Ovodok
63445133b5
Merge pull request #5415 from Jojo-Schmitz/page-end-crash
fix #296034: Crash when multi-measure rests are enabled and press End
2019-11-19 13:09:39 +02:00
Joachim Schmitz
d9abdeb0ea fix #297326: Crash on opening Musescore 2.x file that uses leading space setting on the initial clef
which seems to not belong to any segment, so dereferences a NULL pointer
leading to a segment violation (pun intended).
The fix simply ignores this, and this avoids the crash, but also looses
the 'visible' property of that clef for some yet unknown but unrelated reason.
2019-11-19 10:27:51 +01:00
Dmitri Ovodok
d5b7ad708c
Merge pull request #4263 from JoshuaBonn1/279024-mixer-slider-default
Fix #279024: double click on mixer's dial and sliders should reset th…
2019-11-19 10:35:27 +02:00
Dmitri Ovodok
556a744edb
Merge pull request #5447 from Howard-C/inspector-grey-out
fix #296415: settings in the inspector that are supposed to be greyed out don't appear as such upon the next click on the element
2019-11-19 10:33:47 +02:00
Dmitri Ovodok
81c3cd3a88
Merge pull request #5404 from MarcSabatella/shortcut-update
add missing shortcuts of Mac and AZERTY keyboards
2019-11-19 10:01:05 +02:00
Dmitri Ovodok
e5d93481e0
Merge pull request #5049 from mattmcclinch/166116-slur-end
fix #166116: Slurs terminate in wrong spot in voices other than 1
2019-11-18 16:56:53 +02:00
Dmitri Ovodok
74d17fc1df
Merge pull request #5156 from mattmcclinch/289254-change-state
fix #289254: Beam in edit mode always switches to right grab handle
2019-11-18 16:55:47 +02:00
Matt McClinch
4c5e7459ce fix #289254: Beam in edit mode always switches to right grab handle 2019-11-18 08:54:23 -05:00
Matt McClinch
d173093c40 fix #166116: Slurs terminate in wrong spot in voices other than 1 2019-11-18 08:09:43 -05:00
Dmitri Ovodok
34d7d320c9
Merge pull request #5444 from mattmcclinch/296363-repitch-accidental
fix #296363: Accidental shortcuts do not work in Re-Pitch mode
2019-11-18 14:28:14 +02:00
Dmitri Ovodok
20fe03cf18
Merge pull request #5398 from mattmcclinch/276511-upside-down
fix #276511: Entering notes with mouse fails in Italian TAB
2019-11-18 14:05:17 +02:00
Dmitri Ovodok
6638eaf980
Merge pull request #5275 from mattmcclinch/293459-tied-unisons
fix #293459: Tie command does not properly handle chords with unisons
2019-11-18 11:48:19 +02:00
Dmitri Ovodok
e6e1f209fd
Merge pull request #5147 from mattmcclinch/291053-keysig-mmrests
fix #291053: Bad key change after undoing the enabling of multimeasure rests
2019-11-18 11:37:19 +02:00
Dmitri Ovodok
38bc292156
Merge pull request #5329 from peterhieuvu/play-articulation
fix #288618: play property now controls playback for articulations
2019-11-18 11:21:30 +02:00
Howard-C
a7f0a16cf8 rename inspector labels to be more sensible 2019-11-17 23:08:22 +08:00
Eduardo Rodrigues
99d3dd9ec9
fix #292474 ambitus crash in plugins
Resolves: https://musescore.org/en/node/292474

This also resolves this issue reported in the forum: https://musescore.org/en/node/294734

It was achieved by extending plugin functionalities from commit c77d904eaa. By adding:
* Support for elements that were causing application to crash such as: symbol, fingering, bend, notehead (note level), and clef and ambitus.
* You can now add and remove elements from notes using `Note::add()` and `Note::remove()`.
2019-11-17 13:36:50 +01:00
MarcSabatella
484cd7e81e fix #297152: crash on Ctrl+Shift+drag on Linux (under ChromeOS)
Resolves: https://musescore.org/en/node/297152

This might be unique to Linux apps on ChromeOS,
or it might apply to other Debian "stretch systems",
but apparently passing in a null or 1x1 pixmap to a QDrag
causes it to crash on exec().
This PR fixes the problem by making the pixmap 2x2.
It also allocates it statically to be sure there is no issue
with it coming off the stack.
I also replaced the deprecated QDrag::start() call with QDrag::exec(),
which we already do when dragging *from* the palette.
This is recommended as per Qt guidelines.
2019-11-15 14:01:55 -07:00
anatoly-os
d86b76d166 update version on master to 3.3.3 2019-11-15 17:15:10 +02:00
Dmitri Ovodok
c746cd19a5
Merge pull request #5436 from Jojo-Schmitz/dynamic-pf
fix #296203: add "pf" dynamic
2019-11-15 16:00:41 +02:00
Joachim Schmitz
3e5d9da940 fix #296203: add "pf" dynamic
basically as the opposite of the "fp" dynamic
2019-11-15 13:20:07 +01:00
Dmitri Ovodok
5f73d262ab
Merge pull request #5454 from mgavioli/fix_296610_FigBass_user_text_style
Fix #296610 : import from 2.x may create useless "Fig. bass" user text style
2019-11-15 14:11:15 +02:00
Dmitri Ovodok
89f9b5deb8
Merge pull request #5459 from MarcSabatella/296362-rna-screenreader
fix #296362: screenreader support for RNA
2019-11-15 13:59:19 +02:00