Commit graph

26 commits

Author SHA1 Message Date
Joachim Schmitz
e18b6b2bd3 improve texts of fretboard diagram inspector
and fix a compiler warning
2019-05-05 16:37:06 +02:00
James Thistlewood
40cef95299 Refactor fret diagrams
fix #284966
fix #283759
fix #283678
fix #283676
fix #283674
fix #283452
fix #275658
fix #265324
fix #285616
fix #285613
fix #280575
fix #283762
fix #283679
2019-05-02 19:05:01 +01:00
mirabilos
77983234c8
some spelling fixes
most from the spell checker built into Debian’s automated
package checking tool lintian, two from me during applying
those lintian-suggested fixes
2018-11-27 22:49:18 +01:00
mirabilos
65cd276439
remove RCS IDs from (almost) all files
they do not make any sense, nor do they get updated, if the
source code is kept in git
2018-11-02 23:53:21 +01:00
Joachim Schmitz
474e8152cd fix #275218: fix MSVC C4456 warnings
reg. a declaration shadowing a previously declared local
variable,
"Warning C4456: declaration of 'XXX' hides previous local
declaration"
2018-09-27 17:38:19 +02:00
ws
0c4e596e58 move fret diagram editor into inspector 2018-07-16 11:01:05 +02:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
luz.paz
443be63167 Misc. typos
Found via `codespell -i 3 -w --skip="./thirdparty,./share/locale,./fonts" -I ../musescore-whitelist.txt`
Whitelist:
```
clas
nd
ot
pres
strack
tage
te
```
2018-02-13 12:06:05 -05:00
Dag Henning Liodden Sørbø
2b6cb8b432 Change to new preferences model
The old Preferences struct holding all preferences are removed in favor of a
new Preferences class which acts as a proxy for QSettings. The settings stored
in QSettings are accessed directly through access methods like getBool(key),
getInt(key), etc. and changed with setPreference(key, value).

Since we are using QSettings directly the preferences are stored automatically
without the need for a custom write() and read() method like before.

The preferences.cpp/.h and prefdialog.cpp/h are refactored to have fewer
responsibilities than before. The Preferences class are all about storing and
retrieving preferences - it should not contain any code to handle any other
aspect of MuseScore.

Testing:
The Preferences class can be used in tests. All preferences are initialized with
default values in mtest. If a test requires that a preference has a specific
value it can be changed using setPreference() for that single test. In the tests
the preferences are stored in memory only.

The Preference class is supposed to be used as a singleton. In preferences.h an
'extern Preferences preferences' is set and it is defined in preferences.cpp. All
files which includes preferences.h have access to the 'preferences' singleton
and should use this to get and set preferences.
2018-02-08 16:59:10 +01:00
jeetee
109fb7d270 fix #120096 dialogs should remember their previous size 2016-11-10 23:26:12 +01:00
ws
e6b8fb2808 fix #44436: barré on fretboard diagram extends to the far right 2015-01-16 14:51:09 +01:00
ws
65656416b5 implement barre for fret diagrams 2015-01-15 12:50:03 +01:00
ws
70e228aad1 fix #29391 2014-08-12 12:55:38 +02:00
lasconic
7a62520b89 fix #29346: Fret diagrams without 'x' and 'o' 2014-08-11 10:46:21 +02:00
Joachim Schmitz
0b43247956 convert enum StyleIdx into enum class 2014-05-26 15:31:36 +02:00
Joachim Schmitz
db0a2cb6b7 fix #24349: fret offset text left/right, as style 2014-02-03 09:17:39 +01:00
Joachim Schmitz
8018564b6b fix #24349: fret offset text size as style 2014-02-03 09:15:27 +01:00
Joachim Schmitz
f0f000d89c fix fret offset font size in properties dialog
also simplify libmscore/fret.cpp and sync with mscore/fretporperties.cpp
2014-01-31 10:49:37 +01:00
Maurizio M. Gavioli
2acd24ba1c Finish renaming of Tablature class to StringData
Renames also the files hoding the class itself:
- libmscore/tablature.cpp => stringdata.cpp
- libmscore/tablature.h => stringdata.h

No actual change in the code, only updated references to stringdata.h in #include's.
2013-12-05 21:37:28 +01:00
ws
9ebabcc2e5 add namespace Ms 2013-05-13 19:43:59 +02:00
lasconic
d1ee365ce3 fix #20677: playing position is not displayed in fret diagram 2013-04-05 14:33:19 +02:00
lasconic
f80dfa796c remove contextual help button on Windows 2013-02-07 13:10:46 +01:00
Werner Schweer
32794e2c15 fix fret editing (uninitialized variable) 2013-02-06 17:39:05 +01:00
Werner Schweer
d0f4ee00a2 layout fixes for edit styled text 2013-02-06 16:23:27 +01:00
lasconic
3bd76e4caf fix multiple bugs in fret diagram handling 2013-02-05 16:13:57 +01:00
Werner Schweer
412ca45401 Initial commit 2012-05-26 14:49:10 +02:00