Commit graph

30362 commits

Author SHA1 Message Date
Elnur Ismailzada
63e6d474ce
Merge pull request #17437 from mike-spa/dynamicsSizeCorrection
dynamics correction
2023-05-03 13:21:26 +02:00
Igor Korsukov
aed9b5bd7f fixed firebass global fonts 2023-05-02 22:08:09 +03:00
Igor Korsukov
2c94fedab0 [engraving] moved layout GradualTempoChangeSegment 2023-05-02 22:08:09 +03:00
Igor Korsukov
2076df4a5a [engraving] moved layout Glissando 2023-05-02 22:08:09 +03:00
Igor Korsukov
9d7b836187 [engraving] moved layout FretCircle 2023-05-02 22:08:09 +03:00
Igor Korsukov
8223d7900a [engraving] moved layout FretDiagram 2023-05-02 22:08:09 +03:00
Igor Korsukov
31b2692d2a [engraving] moved layout Fingering 2023-05-02 22:08:09 +03:00
Igor Korsukov
346765d24e [engraving] moved layout FiguredBassItem 2023-05-02 22:08:09 +03:00
Igor Korsukov
f6c0a43426 [engraving] moved layout Fermata 2023-05-02 22:08:09 +03:00
Igor Korsukov
617b5005b3 [engraving] moved layout Expression 2023-05-02 22:08:09 +03:00
Igor Korsukov
9c3a1fe296 [engraving] moved layout Dynamic 2023-05-02 22:08:09 +03:00
Igor Korsukov
882f58cdbf [engraving] moved layout DeadSlapped 2023-05-02 22:08:09 +03:00
Igor Korsukov
6871b361ca [engraving] moved layout Clef 2023-05-02 22:08:09 +03:00
Igor Korsukov
f825a2fb29 [engraving] moved layout ChordLine 2023-05-02 22:08:09 +03:00
Igor Korsukov
f4e852cc5f [engraving] added v0 version to layout 2023-05-02 22:08:09 +03:00
Igor Korsukov
503f775705 [engraving] moved layout GraceNotesGroup 2023-05-02 22:08:09 +03:00
DmitryArefiev
ec84dd030d
Merge pull request #13807 from MarcSabatella/zoom-to-width
Reimplement "zoom to page width" command
2023-05-02 21:16:21 +03:00
mikekirin
3d57c590b2
Merge pull request #17443 from mikekirin/stretched-bends-fix
Bends text rendering fix
2023-05-02 18:21:37 +02:00
mikekirin
749335f5f0 Bends text rendering fix 2023-05-02 17:24:30 +02:00
DmitryArefiev
245d25c8b4
Merge pull request #17410 from tmr232/reorder-tab-notes
Fix #10403: Moving same-beat notes between strings
2023-05-02 17:21:04 +03:00
DmitryArefiev
1eceaa26fe
Merge pull request #17422 from cbjeukendrup/17003_bad_measure_numbers_due_to_bad_sigmap
Fix bad measure numbers due to sigmap being messed up by reading part scores
2023-05-02 16:46:08 +03:00
Michele Spagnolo
71b1394755 dynamics correction 2023-05-02 10:52:24 +02:00
RomanPudashkin
a76d6d3641
Merge pull request #17237 from mike-spa/clefsAndKeySigPositioning
Clefs and key signatures positioning improvement
2023-05-01 18:15:43 +03:00
Casper Jeukendrup
df53ac827c
Fix compiler warnings reg. missing parentheses in logical expression 2023-05-01 00:46:27 +02:00
Casper Jeukendrup
febbbb4445
While reading a score, don't use the (Master)Score's real sigmap
Adding data to the score's sigmap is useless, since it is rebuilt after reading anyway. However, for reading MS2 and MS1 scores, we seem to rely on a sigmap; so let's use a per-score compatibility sigmap for this, rather than abusing the MasterScore's sigmap (and potentially messing it up, see previous commit).
2023-05-01 00:46:27 +02:00
Casper Jeukendrup
ca11ff3a72
Fix bad measure numbers due to bad sigmap
While reading measures in part scores, among which MMRests, we would modify the master score's time sig map, and put the lengths of the MMRests as time signature changes into the sigmap. This only happens for >= 400 scores: for older scores, the part scores were read "recursively", so the `setUpTempoMap` for the master score would be last anyway, to undo the damage from reading the part scores.
2023-04-30 17:35:17 +02:00
Tamir Bahar
7bf571e978 Fix #10403: Moving notes between strings
Sort the notes by string, so that moved notes don't block each other.
2023-04-29 22:42:33 +03:00
Casper Jeukendrup
cf86789e2a
Merge pull request #16172 from Jojo-Schmitz/note_names
Fix #341149: Note Names plugin not translated
2023-04-29 12:47:08 +02:00
Michele Spagnolo
e011fd215d Fix unit tests (all diffs are due to writing "isHeader" property) 2023-04-29 12:06:31 +02:00
RomanPudashkin
ebe0372429
Merge pull request #17001 from mike-spa/unjankifyDynamics
A deep overhaul of dynamics and expression
2023-04-28 21:55:43 +03:00
Igor Korsukov
7f50280484 [engraving] moved layout Chord 2023-04-28 21:39:06 +03:00
Igor Korsukov
b1baed4592 [engraving] moved layout Breath 2023-04-28 21:39:06 +03:00
Igor Korsukov
2b8ba13f14 [engraving] moved layout Bracket 2023-04-28 21:39:06 +03:00
Igor Korsukov
5adbfab216 [engraving] moved layout Box 2023-04-28 21:39:06 +03:00
Igor Korsukov
c1770fc434 [engraving] moved layout Bend 2023-04-28 21:39:06 +03:00
Igor Korsukov
d58dfe5a81 [engraving] moved layout Beam 2023-04-28 21:39:06 +03:00
Igor Korsukov
bfbee737f6 [engraving] moved layout BarLine 2023-04-28 21:39:06 +03:00
Igor Korsukov
cb70f6860f [engraving] moved layout BagpipeEmbellishment 2023-04-28 21:39:06 +03:00
Alexander Pavlov
4adf79f33e
Merge pull request #17321 from HemantAntony/17312-empty_midi_file 2023-04-28 20:26:20 +03:00
Michele Spagnolo
6901e6e270 Added unit test for new dynamics properties 2023-04-28 16:27:43 +02:00
Michele Spagnolo
7d8b49c32a Added unit tests for new Expression items 2023-04-28 16:27:43 +02:00
Michele Spagnolo
fc35897e0d Fixed unit tests 2023-04-28 16:27:43 +02:00
Michele Spagnolo
4ce7551df5 added vtests
added vtest
2023-04-28 16:27:43 +02:00
Michele Spagnolo
efeae2957c A deep overhaul of dynamics and expression
1. Don't automatically flag as "other" dynamic with text. As long as the string contains the substring identifying the dynamic type, we should retain the type. NOTE: this also resolves the issue that dynamics with text don't have playback.

2. Keep dynamics aligned properly (i.e. dynamic under the notehead) when custom text is added. This is now the defaul, with an option to revert to old behaviour.

3. Offset dynamis laterally to avoide collision with barlines (with toggle/untoggle option).

In general, dynamics must be detached from text settings. Specifically:

4. Dynamics symbols now have the possibility to override the score music font (independently of text font)

5. Dynamics symbols can have custom size (independent from text size) expressed as a percentage of the default.

6. Dynamics text (i.e. text typed into a dynamic) must be treated as expression text, and it now takes all its defaults from there. The Style -> Text Styles -> Dynamics page has been removed.

7. Expressions have a new dedicated class of their own. "Old" expressions, i.e. staff text with an "expression" style, are mapped into the new expression item preserving the old layout.

8. Expressions entered on the same chord as a dynamic mark will automatically align to the dynamic (with toggle/untoggle option).

9. An expression + dynamics snapped pair is dragged together.

10. Long awaited quality-of-life improvement: when dropping (or clicking and entering) a new dynamic onto an existing one, it will replace the old one with the new one (instead of having to delete and re-enter to change a dynamic).

11. A new inspector panel for Dynamics, containing all the relevant applicable settings. Some of these settings are moved here from the Text inspector panel, mainly the Above - Below and the Frame Settings.

12. The Text inspector panel is not shown when a "pure" dynamic is selected. It is only shown when a dynamic+custom text is selected, and the options only refer to the text part.

13. New options in the Style -> Dynamics submenu.

14. A new inspector panel for Expressions, containing (for now) only the "Snap to dynamics" option.
2023-04-28 16:27:43 +02:00
mikekirin
6b193674e6
Merge pull request #17386 from mikekirin/stretched-bends-fix
src position fix when deleting bend segment
2023-04-28 16:27:41 +02:00
mikekirin
d0ac241209 X position fix when deleting bend segment 2023-04-28 15:41:43 +02:00
Michele Spagnolo
0ebbb3d308 added vtest 2023-04-28 11:40:03 +02:00
Michele Spagnolo
8aba8f6819 New engraving features for Clefs
- Introduce Auto/Before/After barline option for clefs
- Tag clefs as "header" when needed, instead of trying to guess from context.
- Changes and corrections to the courtesy VS main clef interaction, especially when changing options from inspector.
2023-04-28 11:37:58 +02:00
Michele Spagnolo
7103e0f917 Fix trailing time signature bug 2023-04-28 10:27:14 +02:00
Michele Spagnolo
5b5182b141 KeySig positioning correction 2023-04-28 10:27:14 +02:00