Commit graph

5271 commits

Author SHA1 Message Date
RomanPudashkin
b4f86bdc2b
Merge pull request #11579 from alexpavlov96/fix_frets_not_changing
fix #11568: updating tab notation correctly
2022-05-11 12:23:23 +02:00
Elnur Ismailzada
0a43de4da4
Merge pull request #11314 from the-next-ceo/forkmain
Dynamic behaviour of clear text button when text is present in the Search Field
2022-05-11 12:14:55 +03:00
RomanPudashkin
f125321e9b
Merge pull request #11555 from Eism/nsw_instruments_fix
[MU4] Fixed instruments view in New Score Wizard
2022-05-11 10:56:46 +02:00
HemantAntony
2e2fe2ec8f Fix #11594: PNGs don't have transparent background 2022-05-11 14:07:28 +05:30
Joachim Schmitz
45e26509c0 Turn enum : char into enum : signed char if it contains negative values 2022-05-11 11:00:13 +03:00
HemantAntony
81b139b279 Added Actual Privacy Policy Link 2022-05-11 08:04:07 +05:30
RomanPudashkin
59e9c6dfa3
Merge pull request #11558 from HemantAntony/11502-change_instrument_always_applied
Fix #11502: Change instrument always applied
2022-05-10 15:05:14 +02:00
Casper Jeukendrup
c18f176132
Fix the horizontal scrollbar in the Mixer
It was overlapping with the content.
2022-05-10 13:31:58 +02:00
HemantAntony
15c579784a Fix #11502: Change instrument always applied 2022-05-10 12:12:54 +05:30
Alexander Pavlov
18cb833e9b fix #11568: updating tab notation correctly 2022-05-09 21:02:44 +03:00
Elnur Ismailzada
719d29322b
Merge pull request #11551 from Eism/backend_logging_fix_mu4
[MU4] Backend logging fix
2022-05-09 12:19:02 +03:00
Igor Korsukov
3a4d44b9c9 added new methods read/write file to ifilesystem 2022-05-09 10:58:20 +03:00
Igor Korsukov
507f171d7c added unit tests for file 2022-05-09 10:29:21 +03:00
Joachim Schmitz
9e49e26511 Avoid division by zero
and return from creating an invalid tuplet early, this should fix https://musescore.org/en/node/331840, "Creating a 4-or-higher tuplet on a 512th or an 8-or-higher tuplet on a 256th crashes Musescore", it at least prevents the crash.
It does not bring up the "Tuplet too short" dialog though, for that see #11561.
2022-05-09 10:07:30 +03:00
Joachim Schmitz
ea173f916b Use std::gcd() 2022-05-09 10:07:30 +03:00
Casper Jeukendrup
cfce3e57c2
Merge pull request #11462 from Jojo-Schmitz/palettes-double-click
[MU4] Fix #313977: avoid adding a palette element twice on double-click
2022-05-08 00:18:17 +02:00
the-next-ceo
dc5c3efdf6 implemented the proposed changes
Tooltip assigned in TextInputField.qml and fixed #10879

Assigned tool tip text to clear text button

Re: text tooltip assigned to clear text button

Update PalettesPanelHeader.qml

added clearTextButton, tooltip and assignment of null operator to verify the text is null or not is added in SearchField.qml

shifting of the toolTipTitle
2022-05-07 18:16:37 +05:30
ltrel
9184dff13f Improve consistency of UI string capitalization
This commit fixes some inconsistencies in the capitalization of various
strings in the UI. For example, 'Page view' now uses a lower case 'v' as
was already the case in 'Continuous view'. This commit also capitalizes
the word 'Roman' in 'Add Roman numeral analysis' as it is a proper noun.
2022-05-07 19:40:38 +10:00
Elnur Ismailzada
8c96584a50
Merge pull request #11513 from mike-spa/correctLayoutAtScoreLoading
Correct layout at score loading
2022-05-07 01:30:58 +03:00
Eism
488356e70b qFatal -> ASSERT_FAILED_X 2022-05-06 22:10:03 +03:00
Eism
8f09a079bd fixed #11552: fixed dropdown 2022-05-06 21:21:45 +03:00
Casper Jeukendrup
0dc0d1fe22
Merge pull request #11470 from sammik/custom_keysig_disappear_bug 2022-05-06 18:04:44 +02:00
HemantAntony
d82442d5d7 Fix #11527: Tweaks to palette layout properties 2022-05-06 17:21:09 +02:00
Eism
c14d6f0c33 qDebug -> LOGD 2022-05-06 17:19:51 +03:00
Eism
5630d4ebda qWarning -> LOGW 2022-05-06 17:04:42 +03:00
Eism
429f1d518e Implemented logging formatted string 2022-05-06 16:55:56 +03:00
Igor Korsukov
beee42f867 added io buffer 2022-05-06 15:51:37 +03:00
Elnur Ismailzada
5f13f02428
Merge pull request #10759 from iamjithinjohn/ConcertPitchCheckbox
Check Concert pitch when opening a concert pitch score
2022-05-06 15:16:21 +03:00
Igor Korsukov
9baa423451 disabled unity build for engraving module 2022-05-06 15:12:43 +03:00
Alexander Pavlov
269f001b10
Merge pull request #11391 from alexpavlov96/gp_remove_strings_recalculation
fix #10311: fixing the calculation of harmonic frets
2022-05-06 15:05:36 +03:00
Elnur Ismailzada
80561dfaeb
Merge pull request #11366 from Eism/dropdown_redesign
[MU4] Dropdown redesign
2022-05-06 14:28:44 +03:00
Igor Korsukov
6dad233375 added bytearray tests 2022-05-06 11:21:32 +03:00
Igor Korsukov
b6b673cf99 added iodevice and file 2022-05-06 11:21:32 +03:00
Igor Korsukov
1eed177957 added io bytearray 2022-05-06 11:21:32 +03:00
Igor Korsukov
cc36976e3e removed Q_OBJECT and Q_GADGET 2022-05-06 11:12:06 +03:00
donarturo
ff34831468 Prevent of division by zero 2022-05-06 09:24:42 +03:00
Alexander Pavlov
fe98545ad9 fix #10311: fixing the calculation of harmonic frets 2022-05-06 01:24:42 +03:00
Aaron Sattely
84951c220c Fix ties for tab staves
Both inside and outside ties had to be modified--when the original tie rewrite was done the tab staves were not in a state as to be testable.
2022-05-05 18:17:55 -04:00
donarturo
38aa8192e1 Fix #11488 Crash when undoing a split measure 2022-05-05 18:35:54 +02:00
Michele Spagnolo
280d68448e correct segment ticks calculation 2022-05-05 09:08:01 +02:00
Michele Spagnolo
95cef74842 avoid collisions with stems at score loading 2022-05-05 09:08:01 +02:00
quinnouyang
d0945f6f83 Set default SoundFonts folder and path in Preferences 2022-05-04 16:10:12 -05:00
Eism
f7d42b6541 Enabled logging to console only for editor 2022-05-04 20:58:58 +03:00
Elnur Ismailzada
4606756761
Merge pull request #11512 from alexpavlov96/gp_fix_accents_amount
fix #10365: removed multiple accents on same chord
2022-05-04 18:29:03 +03:00
Aaron Sattely
0e333277bf Continuation of draft PR #10130 (by @Nick-Mazuk)
Cross staff beams and stem extensions, with accompanying test stuff
2022-05-04 16:47:56 +02:00
Alexander Pavlov
7a0483712a fix #11514: removed multiple accents on same chord 2022-05-04 17:19:27 +03:00
Elnur Ismailzada
4ba5a8c6ee
Merge pull request #10903 from cbjeukendrup/fix_default_zoom
Fix default zoom, and scaling in ExampleView
2022-05-04 16:19:32 +03:00
Igor Korsukov
58ec5acd6b Fixed conversion warnings. Step 7 2022-05-04 12:30:14 +03:00
Eism
17da9baaff Fixed warnings in qml 2022-05-04 11:39:13 +03:00
Eism
46d30444eb Fixed menu positioning in cascade mode 2022-05-04 11:39:01 +03:00
Eism
507b115bf6 Close dropdown by Escape 2022-05-04 10:49:50 +03:00
Eism
3b36cbecf6 Fixed navigation for dropdown 2022-05-04 10:49:50 +03:00
Eism
ba739eb5f6 Renamed Dropdown to StyledDropdown 2022-05-04 10:49:50 +03:00
Eism
a8165806b5 Implemented new positioning for dropdown 2022-05-04 10:49:50 +03:00
Eism
fd6a9db318 Moved popup content to separate component 2022-05-04 10:49:50 +03:00
Eism
3220b9ad34 Use our custom popup for dropdown 2022-05-04 10:49:50 +03:00
RomanPudashkin
044dc4b6d8
Merge pull request #11491 from quinnouyang/remove-snd-options
Remove SND options from Staff/Part Properties and hairpin playback popup
2022-05-03 23:54:58 +02:00
RomanPudashkin
0dd457673f
Merge pull request #11506 from Jojo-Schmitz/ellipsis
[MU4] Use ellipsis ('…') rather than 3 dots ("...")
2022-05-03 22:52:43 +02:00
quinnouyang
dfdb984ef2 Remove SND options from hairpin playback popup 2022-05-03 15:18:39 -05:00
Joachim Schmitz
f30a5a7588 Use ellipsis ('…') rather than 3 dots ("...") 2022-05-03 18:36:27 +02:00
RomanPudashkin
cd2d640577
Merge pull request #11487 from HemantAntony/11334-privacy_policy_link
Fix #11334: Added Link to Privacy Policy
2022-05-03 18:35:15 +02:00
RomanPudashkin
f746df5b8a
Merge pull request #10959 from wizofaus/fix-select-menu-issues
fix #10674 - ensure "select similar in range" and "select dialog" menu options work as expected
2022-05-03 18:17:57 +02:00
RomanPudashkin
0aceb6c531
Merge pull request #11397 from mike-spa/loadingTimeEfficiency
Update spacing settings when loading up new scores
2022-05-03 10:32:28 +02:00
wizofaus@hotmail.com
4a70940249 fix #10674 - ensure "select similar in range" and "select dialog" menu options work as expected 2022-05-03 09:41:04 +10:00
HemantAntony
f015b1fdc6 Fix #11336: Added Privacy Policy link to Preferences 2022-05-02 17:33:10 +05:30
RomanPudashkin
5cc7617665
Merge pull request #11465 from HemantAntony/11382-11383-palette_rearrangement
Fix #11382: Inconsistent text sizes
2022-05-02 12:10:34 +02:00
HemantAntony
50602942ac Fix #11334: Added Link to Privacy Policy
Added Link to Privacy Policy in the About Panel
2022-05-02 08:23:55 +05:30
Elnur Ismailzada
082db18194
Merge pull request #11459 from RomanPudashkin/note_input_bar_orientation
[MU4] Fix #11351: Workspace - New Workspace - UI Layout Issues
2022-05-01 21:44:59 +03:00
quinnouyang
4cfada2272 Remove SND options from Staff/Part Properties 2022-05-01 12:40:28 -05:00
RomanPudashkin
903c7ff3f3
Merge pull request #11484 from quinnouyang/line-text-offset
Fix and clarify vertical text offset for lines
2022-05-01 19:32:32 +02:00
quinnouyang
920f009354 Codestyle fix 2022-05-01 11:26:07 -05:00
RomanPudashkin
5264afad5c
Merge pull request #11479 from nikolaosginos/file-dialog-default-path
fix #11082: Changed file open/save dialog's default path
2022-05-01 17:04:06 +02:00
RomanPudashkin
f3676feb8d
Merge pull request #11486 from HemantAntony/11464-incorrect_size_for_pdf_export
Fix #11464: Exported PDFs don't have correct size and added open destination folder on export option
2022-05-01 14:56:11 +02:00
HemantAntony
8bdb43e2c1 Added option to open destination folder on export
This commit adds an option to open destination folder on export
2022-05-01 17:02:09 +05:30
HemantAntony
5f414e1270 Fix #11464: Exported PDFs don't have correct size
This commit makes sure that you can export PDFs in the size you specify in Page Settings
2022-05-01 17:01:56 +05:30
RomanPudashkin
e619c848ce
Merge pull request #11485 from lvinken/331007-musicxml-tie-import
fix #331007: [MusicXML import] support tie element
2022-05-01 12:43:27 +02:00
HemantAntony
eb67c7c9f1 Fix #7654: Hiding multiple instruments on toggle
Before this commit, you couldn't hide multiple instruments at once. You
would have to hide multiple instruments by hiding each instrument
2022-05-01 13:50:05 +05:30
Leon Vinken
133a2975fa fix #331007: [MusicXML import] support tie element 2022-05-01 08:15:29 +02:00
quinnouyang
0150f271b2 Clarified text offset title to "Vertical offset" 2022-04-30 21:36:18 -05:00
quinnouyang
7e74df0ad7 Set QPoint x-position of vertical text offsets for lines to 0
Clarified text offset title to "Vertical offset"
2022-04-30 21:36:18 -05:00
RomanPudashkin
a623af3beb
Merge pull request #11471 from RomanPudashkin/relevant_staff_types
[MU4] Fix #10780: Too many 'Stave Types' displayed in the Instruments Panel compared to MS 3.6
2022-04-30 23:48:30 +02:00
Nikolaos Ginos
7840f19b51 fix #11082: Changed file open/save dialog's default path
User projects path is empty by default

Open: Use path of last opened file
Save new file: Use user projects path if set; otherwise use path of last
saved file
Save existing file: Use last save path of this specific file

If no file has ever been opened or saved, use MuseScore's default path
2022-04-30 20:30:18 +02:00
Roman Pudashkin
c1c9139c88 fixed loading of the current staff type 2022-04-30 17:44:38 +02:00
Casper Jeukendrup
2eb1ce6562
Fix compiler warning 2022-04-30 16:18:01 +02:00
Casper Jeukendrup
960db6361d
Simplify Instrument::operator== 2022-04-30 16:17:50 +02:00
Casper Jeukendrup
f16c389251
Simplify by using const references instead of pointers - Part::instruments 2022-04-30 16:17:32 +02:00
Roman Pudashkin
362d87cec1 code-review fixes 2022-04-30 14:31:07 +02:00
HemantAntony
a948ae78fc Fix #10192: Fixed zoom in not working with Ctrl++
The problem was the shortcut was just Ctrl + +. This meant I had to use
shift + = to get the + similar to how you type in + (By holding shift +
=). So, I changed the shortcut sequence to Ctrl + =
2022-04-30 17:46:07 +05:30
wizofaus@hotmail.com
16ca368f2b Fix #10780 - irrelevant staff types shown for all instruments 2022-04-30 13:33:38 +02:00
sammik
d15474fd7b Don't remove custom key signatures from begining of the score. 2022-04-30 12:58:35 +02:00
HemantAntony
23feabe2cc Fix #11382: Inconsistent text sizes
This commit fixes the differences in the size of certain palette cells of the Tempo Palette by increasing magnification. This also fixes the differences in size of the note symbol and the text in Tempo Palette
2022-04-30 10:06:16 +05:30
Dmitri Ovodok
70b33dc5b7 Fix #313977: avoid adding a palette element twice on double-click 2022-04-29 18:10:44 +02:00
Casper Jeukendrup
eaf29a2e29
Fix default zoom and scaling in ExampleView
(the latter is used in the TimeSigProperties dialog and Staff/Part Properties > Advanced)
2022-04-29 14:30:40 +02:00
RomanPudashkin
bb068491ff
Merge pull request #11454 from cbjeukendrup/replace_instruments_fixes
Fix changing transposition and clef when replacing instrument using Instruments Panel
2022-04-29 13:31:12 +02:00
Roman Pudashkin
347b835ec2 no need to try to restore the orientation if this toolbar does not support changing the orientation 2022-04-29 12:42:55 +02:00
Roman Pudashkin
3b64d33e3c replaced the use of the "persistent" property by using the "closable" and "floatable" properties 2022-04-29 12:42:55 +02:00
Roman Pudashkin
aa1bf1d5e7 fix #11351: it is necessary to reset the current min size of toolbars when reloading the current page, because the orientation of toolbars might change 2022-04-29 12:42:55 +02:00
RomanPudashkin
f1522642c5
Merge pull request #11123 from miiizen/11120-chromatic-solfege
Fix #11120: Added chromatic solfege noteheads to both solfege head sc…
2022-04-29 12:02:35 +02:00
I Woithe
2f39f88ca4 [MU4] Fix #11441: Piano Keyboard - Add shortcut 2022-04-29 17:34:34 +09:30
Michele Spagnolo
c272692957 efficiency improvement
fix
2022-04-29 10:01:42 +02:00