Commit graph

11794 commits

Author SHA1 Message Date
lasconic
702a9f8a4b remove comments 2017-02-25 10:46:47 +01:00
Nicolas Froment
4fd002088a Merge pull request #3020 from ericfont/176601-InsertMultiByteChar
fix #176601 unicode insert Upper & Lower Surrogates simultaneously
2017-02-25 10:36:06 +01:00
Nicolas Froment
1fd82d9d9b Merge pull request #3024 from AntonioBL/previewscroll
Allow wheel scrolling of note group preview
2017-02-24 18:43:46 +01:00
lasconic
e2e19b99e1 fix #166651: Inability to select fingerings in different voices 2017-02-24 18:08:08 +01:00
AntonioBL
f0dea38417 allow scrolling of note group preview 2017-02-24 13:01:02 +01:00
lasconic
ea2cb6428d partially fix #151521: Undoing a multimeasure rest range selection in parts causes a crash 2017-02-23 19:27:11 +01:00
lasconic
a5800b9243 fix #177116: Inability to select ties in a range selection if the last measure is also selected 2017-02-23 18:47:30 +01:00
Eric Fontaine
2d6ce9c635 fix #176601 Supplemental Unicode select, insert, paste
Any operations dealing with Supplemental Unicode must operate on high & low surrogates simulatenously, since they belong together as a pair:
-Text::insert method has a new version of which takes two QChars as input (the high & low surrogates), and inserts them together before incrementing the cursor.
-TextBlock::fragment method now has return parameter ridx (relative QChar index) in addition to rcol (relative cursor position).  For Basic Unicode TextFragments, ridx will be same as rcol, since each Basic Unicode char is one QChar.  But for text that has Supplemental Unicode, ridx will be be different since each Supplemental Unicode char is two QChars.
-TextBlock::text method now includes any high surrogate QChars in the returned string.  Previously, this method simply skipped over QChars that were high surrogates.  When iterating over the TextFragment, only increments col when comming across a QChar that is not a high surrogate.
-Text::createLayout, Text::paste and Text::drop methods now uses the new Text::insert method to insert both high & low surrogates together.  Previously, the cursor position would get messed up when each QChar was added seperately.
-TextBlock::remove(int start, int n) will now add both QChars of the surrogate pair to the return string.

Also was issue with adding text after a SMUFL symbol if the cursor mode was already in SMUFL.  Fixed by making sure to append a new TextFragment regardless of state of cursor, and also making TextFragment::TextFragment(TextCursor* cursor, const QString& s) constructor set the type to CharFormatType::TEXT.
2017-02-23 11:51:38 -05:00
lasconic
6c36ccc9d7 fix #154591: Crash when loading palette with small width/height grid 2017-02-23 14:17:30 +01:00
lasconic
8381b3edc3 fix #105951: CRASH on close score after deleting all segment of a spanner 2017-02-23 11:56:06 +01:00
Werner Schweer
c4b477bab2 fixes for layout, align property 2017-02-23 11:42:03 +01:00
lasconic
d3e1c0bd24 fix #176631: Select -> more... selects wrong voice dots 2017-02-22 18:52:20 +01:00
Nicolas Froment
11ac035157 Merge pull request #3019 from ericfont/176151-MultiByteChar
fix #176151 MultiByte char TextBlock::remove()
2017-02-22 16:44:20 +01:00
Eric Fontaine
1b67e23194 fix #176151 MultiByte char TextBlock::remove()
Previously TextBlock::remove() did not delete Supplementary Multilingual Plane Unicode chars correctly.

Added tests using deletePreviousChar() for SMP Unicode as well as regular BMP Unicode as well as for text that has mixed BMP, SMP, and SMUFL symbols.
2017-02-22 08:33:39 -05:00
lasconic
c2ef50f646 fix #167416: cut a measure with tuplet causes crash. Trying to not reopen # #29796 2017-02-21 19:23:40 +01:00
lasconic
99c15fdccd fix #81451: [Capella Import] corrupt file when importing capx file with pickup measure 2017-02-21 12:23:38 +01:00
lasconic
7b6c0540b2 fix #165701, fix #165716: reposition scoreview when cursor moves 2017-02-20 20:24:12 +01:00
Nicolas Froment
d884878d3a Merge pull request #2991 from RaphaelCojocaru/72896-imagecapture
fix #72896: solved the blank name issue within Save as option in Imag…
2017-02-20 18:38:00 +01:00
Nicolas Froment
a1960dab0a Merge pull request #3005 from ericfont/84421-NoteGroupsUI-changeShorterNotesAlso
fix #84421 note_groups.ui "Change shorter notes also" checkbox
2017-02-20 18:04:49 +01:00
Nicolas Froment
f8c5e23dd1 Merge pull request #3015 from Jojo-Schmitz/navigator
Fix #137446: Navigator rectangle selection is lost
2017-02-20 17:39:24 +01:00
Raphael Cojocaru
316e09823b fix #72896: solved the blank name issue within Save as option in Image capture feature by setting a default name consisting of current score name; every score will use this default name for its first save
compute the default path only for the very first save

fixed the coding style issues

updated the solution in order to cover the native dialogs as well
2017-02-20 18:18:26 +02:00
lasconic
7a8ba0706d fix #175341: [GP6] Crash on a file involving arpeggios, ties and capo feature 2017-02-20 17:16:45 +01:00
Joachim Schmitz
4ff8227a14 Fix #137446: Navigator rectangle selection is lost 2017-02-20 16:54:01 +01:00
lasconic
d0c9e4f4a3 fix #175346: Cannot enter special characters into tempo change 2017-02-20 15:41:34 +01:00
lasconic
3340d623de fix #52841: No sound feedback in repitch mode when using MIDI or Piano Keyboard 2017-02-20 14:12:56 +01:00
Werner Schweer
2a5152a6a5 misc. fixes for time signatures 2017-02-20 11:44:03 +01:00
Eric Fontaine
354591506b fix #84421 note_groups.ui 'Also change shorter notes' checkbox
If enabled, then also update the beam properties for shorter duration notes at the same tick when dropping a beam property from palette or when clicking on a note.
2017-02-19 17:50:51 -05:00
lasconic
1725d1f845 fix #152506: Introduce a time signature in a measure which the Actual duration is exactly identical leads to corruption/crash 2017-02-19 22:13:04 +01:00
Nicolas Froment
20974d1ac9 Merge pull request #3008 from ericfont/174831-addednum-makeTimeSigInvisible
actually need time signature, but don't show it
2017-02-19 18:16:13 +01:00
Eric Fontaine
e59e29285e actually need time signature, but don't show it 2017-02-19 06:41:14 -05:00
lasconic
d93ac18985 fix warning regarding braces in initialization 2017-02-19 11:00:10 +01:00
Nicolas Froment
586a8e4c50 Merge pull request #3007 from ericfont/2288
modified PR #2288 scrolling with stricter rules and simpler code
2017-02-19 10:50:18 +01:00
Nicolas Froment
89bd22c7e0 Merge pull request #3004 from ericfont/174831-NoteGroupUI-simplifiedMiniScore
fix #174831 simplify note group UI's mini score
2017-02-19 09:28:48 +01:00
Nicolas Froment
420419d37b Merge pull request #3003 from ericfont/174836-NoteGroupsTightenBeamProperties
fix #174836 Tighten Beam Properties in note_groups.ui
2017-02-19 09:18:14 +01:00
Eric Fontaine
f208b8c235 Constrain scrolling with simplified code & stricter rules:
1. When moving right, ensure the left edge of system won't be right of frame's left edge margin.
2. Never move left if entire system already fits entirely within the frame.
3. When moving left, ensure the right edge of system won't be left of frame's right edge margin.

Also resets scrolling when time sig's numerator or denominator value changed.
2017-02-18 22:37:04 -05:00
lasconic
fcc51233e3 AppImages OSUOSL: fix filename 2017-02-18 19:00:38 +01:00
lasconic
fb46e5b329 AppImages OSUOSL: stop uploading to bintray 2017-02-18 16:39:01 +01:00
lasconic
041595c696 AppImages OSUOSL: use expect 2017-02-18 15:56:10 +01:00
Nicolas Froment
0351aec381 Merge pull request #3006 from lasconic/fix-travis-macos
Fix #152151: change paths in bottled dylib
2017-02-18 15:31:18 +01:00
AntonioBL
25a4bf58c7 Fix #84416 : Allow long note groups to scroll or pan in Create Time Signature dialog 2017-02-18 09:28:31 -05:00
lasconic
ad14e40f04 Fix #152151: change paths in bottled dylib 2017-02-18 14:55:58 +01:00
Eric Fontaine
2638ca79cd fix #174831 simplify note group UI's mini score
Previously included a clef, even though clef is irrelevant for this UI, and would not reflect the clef of the time sig's staff anyway, so I've removed.

Previously included an explicit time signature, but that time sig never reflected the designated symbol or custom text for num/denom, so I've removed that time sig for simplity from this UI.

Previously had 5-staff line, but since only dealing with beam properties, pitches are irrelevant, so 1-staff is sufficient.
2017-02-18 06:00:28 -05:00
Werner Schweer
94fe39f52e fix alignment of tuplet numbers 2017-02-18 11:24:00 +01:00
lasconic
31a744f8b6 AppImages OSUOSL: start ssh-agent 2017-02-18 10:18:44 +01:00
lasconic
7393462003 fix upload of AppImages to OSUOSL 2017-02-18 09:46:45 +01:00
Eric Fontaine
4121dbc1ae fix #174836 Tighten Beam Properties in note_groups.ui
1. The beam properties palette is no longer ever-expanding horizontally, but rather fixed at minimum required pixels (114) in order to display only the 4 beam property cells.  This prevents a noticeable artifact when resizing, and also makes the ui cleaner.
2. The Beam Properties palette in a QGroupBox named as such, that way it is clear what those 4 cells are.
3. The Reset button and the Beam Properties now share the same horizontal layout space.
2017-02-18 02:19:18 -05:00
Nicolas Froment
fade47128b Merge pull request #3002 from Jojo-Schmitz/audioexport
follow up for fix #50926: fix bitrates for MP3 (MPEG-1)
2017-02-17 22:55:04 +01:00
lasconic
fd8e05cca1 Try to upload AppImage on OSUOSL 2017-02-17 22:40:02 +01:00
Joachim Schmitz
8dc908f43a follow up for fix #50926: fix bitrates for MP3 (MPEG-1)
as documented in http://lame.cvs.sourceforge.net/viewvc/lame/lame/USAGE
Also fixed a 'brown paper bag' copy/paste error and a typo
2017-02-17 22:34:49 +01:00
Nicolas Froment
2c8c6db873 Merge pull request #2993 from Jojo-Schmitz/mp3-export
fix #50926: add setting and option for MP3 bitrate
2017-02-17 18:36:45 +01:00