Commit graph

21 commits

Author SHA1 Message Date
Matt McClinch
c07d2058bb Redesign note input workflow based on Tantacrul's suggestions.
See https://musescore.org/en/noteinput_redesign.

This implements most of the changes Tantacrul suggested in his document, except for the part on Tuplets.
2019-10-15 07:29:17 -04:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
lasconic
41b89aef71 remove debug artifact 2016-06-03 07:35:10 +02:00
lasconic
b3c74cd1d8 add dot and stem direction to shadow note 2016-06-03 00:39:58 +02:00
J.Hoffmann
1b718262de Show duration and notehead during note entry
During note entry shadow notes now also show duration of note
During drum note entry shadow notes show the distince noteheads
2016-05-27 12:49:51 +02:00
Maurizio M. Gavioli
8e0aeaa579 TAB: Support for input and display of bass string notations
Supports 'standard' configuration for bass string notations in historic tablatures (lutes and other plucked instruments, as well as viols), both of the French and of the Italian style. This should fill the last 'big hole' in historic TAB support.

Bass strings (or bourdons) are extra strings in addition to the 6 'standard' strings, which are not represented by tab lines and were indicated by other typograhic devices in historic sources. Among the innumerable variations shown in sources, this implementation supports the following styles, chosen to be general enough to suit the majority of cases, without requiring new parameters in the TAB style dialogue box:

- French: the first 4 bass courses are indicated by a fret mark in the 'seventh' TAB position (below bottom string) with 0, 1, 2 or 3 slashes prefixed; other bass courses are indicated, also in the 'seventh' TAB position, by the string number (from 4 on) and cannot contain a fret mark (as they didn't in historic sources).
- Italian: the first 2 bass courses are indicated by a fret mark in the 'seventh' TAB position (abover top string) with 1 or 2 'ledger lines' underneath; other bass courses are indicated, also in the 'seventh' TAB position, by the string number (from 9 on) and cannot contain a fret mark (as they didn't in historic sources). Rhythm marks above these indication are raised to leave room for them.

Both styles do not blindly assume that French style is top-to-bottom and Italian is 'upside-down' -- as historic sources are -- but adapt to the actual string order of the TAB. The choice between the two styles depends on the TAB using numbers or letters for the fret marks.

The implementation does not try to detect if the TAB is really of a historic style and applies either bass string notation whenever more strings are used than there are TAB lines. If this proves unsuitable to modern usage, some better heuristics can probably be found.

For a discussion and some screen shots, see: https://musescore.org/en/node/67261

**Note entry**

During TAB note entry, if the instruments has more strings than the TAB has lines, the string cursor can be moved outside of the TAB body, one position below for 'top-to-bottom' TAB's and one position above for 'upside-down' TAB's.

Further up or down movements add, to the 'blue cursor rectangle', markers indicating which is the actual target string (the cursor does not actually move), equal to the marks a note in that string will receive (slashes, ledger lines or string ordinal, according to the style and the string); during input the user will then receive the same info as when reading entered notes.

Other Notes:

- the `InputStatus::_string` variable, holding the current target TAB string in TAB note entry, changed meaning from the __visual__ string index to the __physical__ string index: this allows a better containment of the peculiarities of the individual TAB styles within the `StaffStyle` class, leaving other classes somehow freer of concern about TAB visual order and other peculiarities. As this variable is only used with TAB's, this change should not affect other functions.

- Some calculation for rhythm symbols have been moved from `TabDurationSymbol::draw()` to `TabDurationSymbol::layout()`, hopefully speeding up the drawing process.

- In fonts for historic styles, '10' has been replaced by 'X' both in fret numbers and in string ordinals, as this is more common in historic sources. Currently, this is not configurable; an additional style parameter could be added in future, if there will be enough request for it.
2015-08-17 10:52:05 +02:00
Mirek Mazel
9368c1d27c Brighter colors, as requested 2014-09-09 00:34:42 +02:00
Joachim Schmitz
843356beb7 disable unused local variables 2014-06-10 09:27:51 +02:00
Joachim Schmitz
0b43247956 convert enum StyleIdx into enum class 2014-05-26 15:31:36 +02:00
ws
e6e7abbd6d smufl integration: articulation 2 2013-11-12 09:29:13 +01:00
ws
733c1934db smufl integration, part I 2013-11-12 09:29:12 +01:00
ws
05d827a9ee rework of InputState 2013-10-24 12:09:00 +02:00
lasconic
7544355236 fix #22596, change color of page number in navigator, remove obsolete QColor.light calls 2013-09-08 18:27:45 +02:00
ws
aa8bba3ced fix #22051 2013-07-25 17:22:49 +02:00
ws
e9a3cd02e1 fix: importPdf, boundingRect of ShadowNote 2013-07-25 10:47:31 +02:00
lasconic
dd703d7de9 fix #21286 again 2013-06-05 20:20:19 +02:00
lasconic
4ab29a63b7 fix #21286: Ledger lines of small stave appear incorrectly on mouse cursor in Note Entry mode 2013-06-05 17:19:11 +02:00
ws
9ebabcc2e5 add namespace Ms 2013-05-13 19:43:59 +02:00
ws
220db94494 reorganize synthesizer; add zita1 reverb 2013-04-03 12:50:21 +02:00
lasconic
a5f70b2868 fix #17674: Ledger lines appear when hovering below and above stave with rest in Note Entry 2012-08-06 12:23:01 +02:00
Werner Schweer
1f9ccfcdce add libmscore
git-subtree-dir: libmscore
git-subtree-mainline: 412ca45401
git-subtree-split: 6047361bd0
2012-05-26 14:54:47 +02:00