Commit graph

127 commits

Author SHA1 Message Date
Igor Korsukov
b6dabf5e0b fixed ctor colon 2020-05-29 21:15:25 +02:00
Igor Korsukov
45b9887603 changed code style 2020-05-28 09:50:45 +02:00
AntonioBL
1e141fdfcc fix #151121 fix #286497 fix #298638 : fix courtesy clef visbility and add tests 2020-04-22 17:43:56 +02:00
AntonioBL
067814ad60 fix #280584 : changing clef with courtesy disabled does not change main clef 2020-04-22 17:32:50 +02:00
anatoly-os
96c03195e3
Merge pull request #5745 from dmitrio95/layout-opt
Layout optimizations
2020-04-09 17:39:23 +03:00
joshwd36
3130bcd26d Change structure of warnings, key signatures, and clefs to remove pointers between them and instrument changes 2020-03-18 18:26:09 +02:00
Dmitri Ovodok
dc4c3040a0 Optimize segment tick calculation when searching for staff type 2020-02-21 22:27:43 +02:00
Joachim Schmitz
f3627313a1 Fix #299518: Add "Soprano Clef (French, 20th/18th century)" 2020-01-11 12:20:23 +01:00
Marc Sabatella
55cb6c5b9a fix #285535, fix #284613: spacing of mid-measure clefs 2019-05-16 13:48:11 -06:00
Dmitri Ovodok
d7778ca6ef Fix Clef::symId field initialization and assignments
This helps to avoid crashes on SVG export of some scores.
Also remove redundant user-defined copy constructor for Clef
2019-04-27 02:01:00 +03:00
Joachim Schmitz
d5eaaefa84 make clefs translatable
they were suffering from the same proble as the error messages from
#286666, lupdate being to stupid for preprocessor marcos
2019-04-04 14:48:57 +02:00
Dmitri Ovodok
d26bd056de Assign PIDs and names for some properties 2019-03-14 15:13:43 +02:00
ws
ec3be9a99a Replacd integer midi tick values by fractions.
- tick names a position on the time axis
- tick is always a Fraction()
- only Measure() and Segment() (and Tuplet?) have a tick value
- tick() for an generic element return only a sensible value if isMeasure() or isSegment() or isSegment(parent())

- "ticks" names a duration stored in a Fraction()
- the tick value for an Segment is relative to its measure

- rename "duration" to "ticks"
- rename afrac() to tick()
- rename rfrac() to rtick()
- rename some variables, changing "fraction" into "tick"
  (example: actualFraction() into actualTicks())

- Lyrics ticks are written as Fraction, on read if xmlreader sees a "/" it reads a fraction
  else midi ticks for backwards compatibility
2019-02-18 11:46:05 +01:00
anatoly-os
bab29bf4e9
Merge pull request #3694 from mattmcclinch/272887-midmeasure-clef
fix #272887: Unable to add mid-measure clef on the first tick of a measure
2019-02-15 16:59:18 +02:00
Joachim Schmitz
a4c491bd2a fix #281028, fix #280842, fix #280470, fix #281369 and some more text fixes
* Change sharps, flats and naturals to their unicode counterparts
* Fix #281028: remove superfluos double spaces
* Add missing "the"
* Fix #280842: change [Tablature] to (Tablature) for instruments
* fix #280470: Inconsistent reference to menu entry navigation
* Translate MusicXML import error message prefix
see https://musescore.org/en/node/281133
* Improve message on importing pre-3.0 scores
and also enabling it for pre-2.0 scores
* Fix #281369: Ottava bassa shows as "8vb", while 15ma and 22ma is used
for alta and bassa
see also PR #4547
Clefs were having the same issue, so changed those too
* Improve one text in Preferences > I/O and remove another
as that is no longer true
* Yet another ellipsis
2019-01-11 15:15:25 +01:00
Dmitri Ovodok
b4622aa978 fix #280345: ensure that measure's system is reset on detaching from system 2018-12-20 17:53:14 +02:00
ws
5fadc466bd fix #276978 crash during open .gpx file 2018-11-29 11:50:45 +01:00
Matt McClinch
6df5c1c9aa Fix #272887: Unable to add mid-measure clef on the first tick of a measure 2018-11-14 12:06:16 -05:00
ws
d2e452040b fix #278099 Crash when inserting a symbol from master palette 2018-11-13 13:32:33 +01:00
ws
1edd676aa7 fix #277699 Staff properties corrupted on MusicXML import after Master Palette opened
The problem is deep in the initialization of staff types in Staff.
This commit also tries to make handling of StaffType more "const correct" and adds some
assertions which may lead to crashes (and helps detecting bad code).
2018-11-08 15:50:00 +01:00
Dmitri Ovodok
c95dfd5a40 Make it possible to record elements written to MSCX 2018-10-29 16:30:19 +02:00
alexandr
b259099300 fix #275552 fix#137501: Inability to show MM rests in Continuous View
1) The reason of crash is utilizing already deleted pointer. Each element are lying in tree.   The parent of VBox element is System element. When we change mode to continuous view MS deleted all system elements and create new one. Then populate new tree with new system which root. But VBox is not shown in continuous view and MS do not set new parent for VBox. Sow VBox have pointer to deleted SYstem element. I fixed it.
2) Add header file to libmscore/CMakeLists. It doesn't effect on building, But it is necessary to include header files to Visual Studio IDE

3) Fix inability to show multi-measure rests in Continuous View see https://musescore.org/en/node/137501
2018-08-29 12:04:48 +02:00
ws
175d5aadb3 cleanup ElementFlags interface, use more Placement properties on mxml import/export 2018-07-04 12:41:14 +02:00
Matt McClinch
6c2b78c0bc fix #273305: Courtesy clef hide/show issue 2018-06-12 13:27:44 -04:00
Matt McClinch
24ccd3e355 fix #108201: Untick 'Show courtesy' for clefs does not work. 2018-05-22 07:25:48 -04:00
ws
33d1cd7fb4 rename StyleIdx -> Sid and P_ID -> Pid 2018-03-27 15:36:00 +02:00
Werner Schweer
45c2d9136a guitar pro import update; add power tab import 2017-11-16 10:59:35 +01:00
divya-urs
28d4e39b05 accessibility: nextElement and prevElement 2017-07-13 23:52:00 +05:30
Werner Schweer
ac41fa396e update edit infrastructure 2017-03-31 13:03:30 +02:00
Werner Schweer
867f2582f6 move Segment::Type into SegmentType 2017-03-08 13:12:26 +01:00
Werner Schweer
88703a3259 interpret custom keys 2017-02-13 12:45:37 +01:00
Werner Schweer
1d4c6b2f21 move Element::type() to ScoreElement 2017-01-18 14:16:33 +01:00
Werner Schweer
337e885896 barline changes, part-1 2016-12-28 16:36:59 +01:00
Werner Schweer
6e7e05aaec impl. staff type changes 2016-12-18 14:31:34 +01:00
Werner Schweer
660b393b98 change StaffType interface 2016-12-14 15:44:24 +01:00
Werner Schweer
c5f46bb208 rename Xml() -> XmlWriter() 2016-11-19 11:51:21 +01:00
Werner Schweer
42b14fa114 fix performance regressions: slow loading files 2016-11-02 08:55:54 +01:00
Werner Schweer
f7d96502c3 update layout, change handling of clefs, system header and trailer 2016-10-25 17:35:55 +02:00
lasconic
f966b08d77 add more F and C clefs, refactor clef.cpp and use symId and line when possible 2016-09-29 01:14:03 +02:00
lasconic
88487955b9 add compatibility tests for clefs 2016-09-28 16:39:48 +02:00
Werner Schweer
27b0b767d1 fix #123601 Volta Hook height style setting not applied via double click 2016-09-28 16:06:38 +02:00
Werner Schweer
bf2f3774b3 fix #125566: all clefs in palette centered on top staff line 2016-09-21 15:49:02 +02:00
Werner Schweer
d6cad628d3 simplify clef implementation 2016-09-21 12:46:19 +02:00
lasconic
9ef2f130e2 fix #125126: add 4-string tablature clef. Also add serif version. Use a single glyphnames.json from smufl 2016-09-18 18:37:42 +02:00
werner
22d16c3615 inspector updates; misc. cleanups 2016-06-09 09:33:19 +02:00
ws
b448ab9c30 update continuous view 2016-05-18 15:44:03 +02:00
ws
474294a329 fix mtest 2016-04-21 12:20:29 +02:00
ws
553b0def9a fix clef creation for systems with one measure 2016-04-20 12:00:29 +02:00
ws
aa7fccd09f fix mtest clef_courtesy 2016-04-14 15:37:15 +02:00
ws
70e79135c6 add benchmark for incremental layout 2016-04-14 11:45:12 +02:00