__References__:
Issues: https://musescore.org/en/node/19155https://musescore.org/en/node/22861https://musescore.org/en/node/23100
__Description__:
Allows to change the start and end note to which a glissando is anchored after it has been entered. Either anchor can be changed independently.
The user interface follows the current working of other 'snappable' lines. Once either the start or end grip is selected:
- `[Shift]+[Left]` snaps the anchor to the previous chord, defaulting to its top note.
- `[Shift]+[Right]` snaps to the next chord, defaulting to its top note.
- `[Shift]+[Up]` snaps to the note above (possibly in a chord, voice or staff above the current one).
- `[Shift]+[Down]` snaps to the note below (possibly in a chord, voice or staff below the current one).
This permits to set the anchor points of a glissando to any note in the score, allowing several glissandi between the notes of the same two chords and other complex configurations (glissandi skipping intermediate chords, start and end notes in different voices or staves, and so on).
It is possible to move the anchor to a different staff of the same instrument, but not to a different instrument; also, it is not possible to 'cross' a change of instrument in the same staff.
__Known limitations__:
- The `[Shift]+[Up]` and `[Shift]+[Down]` use the same note-finding functions as the `[Alt]+[Up]` and `[Alt]+[Down]`actions which move the selection cursor to the above and below note, even across voices or staves. Occasionally, in particular if the note immediately above or below is not time-aligned, the algorithm has little expected results; however, the behaviour is already known to the user. Improving the algorithm would benefit both uses.
__Notes__:
- Most of the added infrastructure is not specific to glissando but to any spanner anchored to notes, then it should also add after-the-fact "snap to" note support to note-anchored text line.
- When moving an anchor, the algorithm usually prefers a note in the same voice/staff of the old note if it exists; if there is none, it tries other voices of the same staff.
- The change of anchor is undoable.
- The fix corrects the management of the `Chord::_endsGlissando` flag, taking into account that a chord can be the ending point of several glissandi and removing one of them not necessarily means the chord no longer ends a glissando (another glissando may still exists).
- The fix also improved the rendering of the glissando wavy line, with better alignment with anchor notes and, with glissando text, better text-line spacing.
__References__:
- issue https://musescore.org/en/node/71931#comment-341166
- forum thread https://musescore.org/en/node/71886
Adds an option to the TAB staff type config. dlg box controlling whether back-tied notes are shown or not.
Should maintain backward compatibility, as the value of this new staff type parameter is by default set to `~_slashStyle`, which was the original rule for this detail.
Should also support forward compatibility, as the new staff type tag in score files would be simply ignored by older versions.
Supports 'standard' configuration for bass string notations in historic tablatures (lutes and other plucked instruments, as well as viols), both of the French and of the Italian style. This should fill the last 'big hole' in historic TAB support.
Bass strings (or bourdons) are extra strings in addition to the 6 'standard' strings, which are not represented by tab lines and were indicated by other typograhic devices in historic sources. Among the innumerable variations shown in sources, this implementation supports the following styles, chosen to be general enough to suit the majority of cases, without requiring new parameters in the TAB style dialogue box:
- French: the first 4 bass courses are indicated by a fret mark in the 'seventh' TAB position (below bottom string) with 0, 1, 2 or 3 slashes prefixed; other bass courses are indicated, also in the 'seventh' TAB position, by the string number (from 4 on) and cannot contain a fret mark (as they didn't in historic sources).
- Italian: the first 2 bass courses are indicated by a fret mark in the 'seventh' TAB position (abover top string) with 1 or 2 'ledger lines' underneath; other bass courses are indicated, also in the 'seventh' TAB position, by the string number (from 9 on) and cannot contain a fret mark (as they didn't in historic sources). Rhythm marks above these indication are raised to leave room for them.
Both styles do not blindly assume that French style is top-to-bottom and Italian is 'upside-down' -- as historic sources are -- but adapt to the actual string order of the TAB. The choice between the two styles depends on the TAB using numbers or letters for the fret marks.
The implementation does not try to detect if the TAB is really of a historic style and applies either bass string notation whenever more strings are used than there are TAB lines. If this proves unsuitable to modern usage, some better heuristics can probably be found.
For a discussion and some screen shots, see: https://musescore.org/en/node/67261
**Note entry**
During TAB note entry, if the instruments has more strings than the TAB has lines, the string cursor can be moved outside of the TAB body, one position below for 'top-to-bottom' TAB's and one position above for 'upside-down' TAB's.
Further up or down movements add, to the 'blue cursor rectangle', markers indicating which is the actual target string (the cursor does not actually move), equal to the marks a note in that string will receive (slashes, ledger lines or string ordinal, according to the style and the string); during input the user will then receive the same info as when reading entered notes.
Other Notes:
- the `InputStatus::_string` variable, holding the current target TAB string in TAB note entry, changed meaning from the __visual__ string index to the __physical__ string index: this allows a better containment of the peculiarities of the individual TAB styles within the `StaffStyle` class, leaving other classes somehow freer of concern about TAB visual order and other peculiarities. As this variable is only used with TAB's, this change should not affect other functions.
- Some calculation for rhythm symbols have been moved from `TabDurationSymbol::draw()` to `TabDurationSymbol::layout()`, hopefully speeding up the drawing process.
- In fonts for historic styles, '10' has been replaced by 'X' both in fret numbers and in string ordinals, as this is more common in historic sources. Currently, this is not configurable; an additional style parameter could be added in future, if there will be enough request for it.
If selection containing a glissando is copied into a staff which has another staff linked to it, the glissando is copied into the first staff but not cloned into the linked staff.
Original issue: http://musescore.org/en/node/49856
Partial, cheap fix: if pasting a note-anchored spanner into a staff which has other linked staves, the spanner is ignored.
This at least ensures that the linked staves are consistent among themselves after the pasting; also, as correct cloning of manually added spanners across all the linked staves is properly supported, the un-copied spanner can be added later by the user without structural issues.
If a cross-staff spanner goes from a lower to a higher staff, the start point is saved **after** the end point.
When reading it back, the end point is ignored because a matching start point has not been met yet.
This applies for instance to glissandi from the bass to the treble staff of a grand staff.
Fixed by adding to the XML reader spanner map a temporary place-holder spanner with the end point data, to be looked for when meeting the start point.
This fix only deals with note-anchored spanners.
Entering edit mode on a glissando and trying to move the grips results in crash.
Fixed by disabling glissando editing altogether, as it does not make sense until proper support for grip nudging and anchor note selecting is added.
- Implemented as a sub-class of `SLine`.
- Anchor type changed from CHORD to NOTE: allows to attach glissando start and end points to individual notes, rather than generically to chords (with note within the chord chosen by the program).
- The Glissando element is now stored in the `Note::_spannerFor` list.
- `Chord::_glissando` has been removed and replaced by a `bool _endsGlissando`, recording whether the chord is at the end of glissando (as gliss.-end chords require more space if mid-measure or system-initial).
- Debugger UI for `Chord` updated accordingly.
- Glissando in now save into score file as a spanner, within the initial note, and with appropriate `<endSpanner>` tag in the Glissando ending note.
- Existing scores with the old Glissando file format are correctly read back.
Notes:
- MusicXML import/export of the new Glissando implementation NOT IMPLEMENTED.
- This version can read scores from older versions, but older versions **cannot read** scored from this version (they do not expect a <Glissando> tag within a Note). Does this require a NEW FILE VERSION NUMBER?
- This implementation would allow rather easily to move the start and end anchors around (as for slurs) to override the note/chord chosen by the program when the glissando is initially created; but the UI for this is not implemented yet.
Feature has been requested and discussed at length in the forum thread: http://musescore.org/en/node/31016
To implement this, the fret-to-pitch relation has been made dependent of the staff, as each staff may have an individual transposition value in addition to the string data. And -- in addition -- on tick, in preparation of dealing with ottavas and capos.
Also, improve physical-to-visual string conversion for physical strings without a visual tab line and vice versa, to return the nearest existing string or line.
fix translation of some accessibility infos:
* accidentals
* articulations
* clefs
* jumps (need to run thru Transifex first to be seen)
* keysigs
* marker (need to run thru Transifex first to be seen)
* noteheadnames (not shown anywhere currently)
* tremolo
* trills (need to run thru Transifex first to be seen)
fix some capitalization issues
In a TAB with the "Stem through staff" style, augmentation dots are not shown.
Fixed, by invoking the function which creates dots for standard staff (`setDotY()`); this function is in a work-flow which is not executed for TAB's (as a number of layout steps, like those for accidentals, are not needed for TAB's).
For details, including an analysis of the problem, see http://musescore.org/en/node/27201
This fix only covers `Q_INVOKABLE` methods in the `Note` class; there are probably more of them on other classes.
and change to a better sentinel for end of list.
Also move the Q_DECLARE_METATYPE(Ms::ValueType) nearer to its
definition.
This should conclude the work on the enums in libmsore/mscore.h.
convert qDebug();abort() to qFatal() and if(cond) abort() to
Q_ASSERT(!cond), esp. for the benefit of Windows, where it is impossible
to set a breakpoint on the abort()
Also modernizing mscoreMessageHandler() and making it more informative
by adding file, line and function to the output.
Renames also the files hoding the class itself:
- libmscore/tablature.cpp => stringdata.cpp
- libmscore/tablature.h => stringdata.h
No actual change in the code, only updated references to stringdata.h in #include's.
- all SMuFL 0.7 entities (as names or symbol id) are listed
- a few (15 in all) additional symbols are added to the end for
- SMuFL stylistic alternates MuseScore needs to access directly
- precomposed ornaments, SMuFL provides as sequences of glyphs
- glyphs SMuFL does not provides (yet?), but has been used as symbols
Updated mscore/glyphnames.json to match the above
Updated code points which were using SymId which have changed from SMuFL 0.6 to 0.7
Fixed note heads palette.
Note: The Dynamics palette is broken, as it accesses the mscore glyphs directly, but the palettes use Bravura. The usage of HTML texts in this palette is unclear: please advise.
It should re-enable all the note head functionality as per ver. 1.3, with most (all?) equal results.
- No new glyph added to font(s)
- Existing mscore glyphs have been matched to SMUFL note head symbols:
-- partly on similarity of shape
-- partly on similarity of semantics (in particular most of the noteDo..., noteRe..., ... heads)
- The dropped HEAD_BREVIS_ALT note head group have been re-instated (dropping it was a regression from 1.3)
- fonts/mscore/glyphnames.json has been updated
- fonts/mscore/metadata.json has NOT been updated (I have not understood its contents)
It may be improved incrementally, should the need arise.
In TAB's, when notes are dragged, for instance, above an already occupied string, other notes were not re-fretted.
See http://musescore.org/en/node/23402 for an example.
Refactoring the following names:
Classes:
Tablature => StringData
Member variables and methods:
Instrument::tablature() => stringData()
Instrument::setTablature() => setStringdata()
InstrumentTemplate::tablature => stringData
InstrumentData::_tablature => _stringData
InstrumentData::tablature() => stringData()
InstrumentData::setTablature() => setStringData()
There is no change in logic or program behaviour, only renaming.
