Howard-C
8e5b82db33
Move extendedStemLenWithTwoNoteTremolo() to layout.cpp to avoid calling it in a Chord member function
...
+ provide a commented-out part of adjusting stem lengths for cross-staff two-note tremolos that currently isn't working in some cases
2020-04-14 18:11:06 +08:00
Howard-C
bcad104d73
Improve layout of two-note tremolos of chords without stem
2020-04-14 18:04:00 +08:00
Howard-C
7450cbff16
Improve layout related to two-note tremolos
2020-04-14 18:03:59 +08:00
Howard-C
43ab590066
Improve layout related to single-note tremolos
...
fix #20390 : tremolo through stem collide with ledger lines
2020-04-14 18:03:58 +08:00
anatoly-os
db7c5560ce
Merge pull request #5612 from Howard-C/minim-tremolo
...
Support "all lines attached to stem" beam style of tremolo (partially fix #18897 )
2020-04-14 12:45:06 +03:00
Howard-C
70e41448a9
Address review
2020-04-14 16:54:21 +08:00
Howard-C
10ccdaa9ce
Fix not able to change layout of dotted minim tremolos
2020-04-14 16:54:21 +08:00
Howard-C
d3f9f6baa9
Restrict "all lines attached to stem" tremolo beam style to non-tab staves
2020-04-14 16:54:20 +08:00
Howard-C
9cde80bd56
Initial implementation of "all lines attached to stem" beam style of tremolo
2020-04-14 16:54:19 +08:00
anatoly-os
8659ae072e
Merge pull request #5456 from Howard-C/backup-import
...
[Backup File] fix #295701 : able to open backup files as an import
2020-04-14 11:02:24 +03:00
AntonioBL
78d9a2978c
fix #285434 : Certain 2.x frame texts imported with no style
2020-04-13 22:57:19 +02:00
Joachim Schmitz
f8a0429c50
fix #303712 : Crash when extending note into "let ring" and "Palm Mute"
2020-04-12 14:36:37 +02:00
AntonioBL
bda740ff66
fix #294298 : Diagonal line: End hook can disappear or elongate when Begin hook is set to None
2020-04-09 16:59:54 +02:00
anatoly-os
96c03195e3
Merge pull request #5745 from dmitrio95/layout-opt
...
Layout optimizations
2020-04-09 17:39:23 +03:00
anatoly-os
409aa87dad
Merge pull request #5893 from Jojo-Schmitz/stemles-crash
...
fix #303189 : Staff/Part properties > Advanced Style Properties > Stemless crashes MuseScore
2020-04-09 17:37:29 +03:00
anatoly-os
13a302f1af
Merge pull request #5877 from igorkorsukov/pvs_fixes_step6
...
Fixed some issues from PVS-Studio report (step6)
2020-04-09 13:15:02 +03:00
Howard-C
ea3e44f6f6
fix #295701 : able to open backup files as an import
...
Resolves: https://musescore.org/node/295701 .
A few improvements are made along the way to make sure the backup file ".name.mscz,/mscx," is saved (saved as/saved as copy) correctly as "name.mscz/mscx".
2020-04-09 10:06:27 +08:00
anatoly-os
8537770c35
Merge pull request #5380 from Howard-C/backup-folder
...
[Backup File] fix #125656 : put the backup file in a separate folder
2020-04-07 14:50:24 +02:00
anatoly-os
38f73a7c59
Merge pull request #5851 from mattmcclinch/302603-turned-accidentals
...
fix #302603 : Changing "Direction" has no effect on bowing symbols
2020-04-07 14:28:57 +02:00
anatoly-os
c43b54c184
Merge pull request #5852 from Jojo-Schmitz/texts
...
fix #302711 : chord symbol playback channel in Mixer is shown as "harmony"
2020-04-07 14:14:49 +02:00
Joachim Schmitz
152796e1d7
closing file once no longer needed
2020-04-07 11:54:40 +02:00
anatoly-os
c13dba11c4
Merge pull request #5879 from igorkorsukov/sentry/N4K_text_endedit
...
Try fix crash on TextBase::endEdit (from CrashReporter)
2020-04-07 10:47:30 +02:00
anatoly-os
7710ce7510
Merge pull request #5818 from emfomy/patch-1
...
Fix #302281 : Wrong default beaming of 32nd notes in 9/8 and 12/8
2020-04-07 10:11:13 +02:00
anatoly-os
dc654503fa
Merge pull request #5878 from igorkorsukov/tracker_299788_localtimesig
...
fix #299788 Crash when deleting a local Time Signature (removed assert)
2020-04-07 09:52:38 +02:00
anatoly-os
9916086f6b
Merge pull request #5874 from igorkorsukov/tracker_292631_glissandos
...
fix #292631 fixed crash on spanners (glissandos) layout
2020-04-07 09:50:53 +02:00
anatoly-os
d57183493e
Merge pull request #5866 from igorkorsukov/sentry_corrupt_editdata
...
fixed collision between drag and cmds next*, prev*
2020-04-07 09:50:07 +02:00
Igor Korsukov
4a41f16082
fixed crash on text endedit
2020-04-07 09:36:50 +02:00
Joachim Schmitz
263d5d91d7
fix #303189 : Staff/Part properties > Advanced Style Properties > Stemless crashes MuseScore
...
The problem is that a stem's `lineWidthMag()` was asked for even if
there is no stem (anymore).
Apparently caused by the changes in #5669 / 57d8a1841
for fixing
[#291699 ](https://musescore.org/en/node/291699 )
2020-04-03 14:13:24 +02:00
Mu Yang
56ee821f16
Fix #302281 : Wrong default beaming of 32nd notes in 9/8 and 12/8
2020-03-31 14:59:02 +08:00
Joachim Schmitz
efcf14ae94
fix #302711 : chord symbol playback channel in Mixer is shown as "harmony"
...
fixing the harmony channel name, make channel names translatable,
some text changes, using ellipsis, deleting/untranslating some,
adding tooltips about what "Realize Chord Symbols" means
and adjusting mtests.
Also compacting the voicing dialog
2020-03-29 22:05:16 +02:00
anatoly-os
1163513290
Merge pull request #5315 from tcannon686/master
...
fix #282246 : "other" appearance in time signature properties does not work
2020-03-29 20:14:45 +02:00
Dmitri Ovodok
9f7a9c1775
Move all handling of empty text elements removal to TextBase::endEdit()
2020-03-28 05:54:20 +02:00
Dmitri Ovodok
1edcf0d2d3
fix #302643 : crash on advancing to next chord symbol with no text entered
...
Ensures that text elements are deleted after the entire text editing
process is finished. Previously elements were deleted on next
Score::update() call which is dangerous since it may happen to be
called several times on finishing text editing.
Also take care to remove the deleted element from selection to
prevent potential crashes on undo/redo operations (e.g. with lyrics)
2020-03-28 05:48:32 +02:00
Igor Korsukov
49deefa6b9
fixed indent
2020-03-27 13:31:41 +02:00
Igor Korsukov
2a5af1c527
fixed virtual methods
2020-03-27 13:07:27 +02:00
Igor Korsukov
0aecb0a173
fixed virtual methods
2020-03-27 10:01:06 +02:00
Igor Korsukov
a2bfb02954
fix #292631 fixed spanners (glissandos) layout
2020-03-26 16:41:36 +02:00
Igor Korsukov
4c6a56cfff
fix #299788 removed assert
2020-03-26 11:18:40 +02:00
anatoly-os
1f0ec33327
Merge pull request #5860 from igorkorsukov/pvs_fixes_step3
...
Fixed some issues from PVS-Studio report (step3)
2020-03-24 23:08:57 +02:00
Igor Korsukov
9d9d06b3c2
fixed virtual methods
2020-03-24 15:49:16 +02:00
anatoly-os
9e456031cf
Merge pull request #5850 from igorkorsukov/pvs_fizeds_step2
...
Fixed some issues from PVS-Studio report (step2)
2020-03-24 13:12:03 +02:00
Igor Korsukov
69df3f9656
fixed collision between drag and cmds next*, prev*
2020-03-24 12:56:07 +02:00
anatoly-os
aaf3cf9de8
Merge pull request #5857 from igorkorsukov/sentry_9E9_Note_drag
...
Try fix crash on Note::drag (from CrashReporter)
2020-03-24 12:50:40 +02:00
anatoly-os
27c7c850a8
Merge pull request #5856 from igorkorsukov/sentry_JP4_SlurTieSegment_startEditDrag
...
Try fix crash on SlurTieSegment::startEditDrag (from CrashReporter)
2020-03-24 12:26:06 +02:00
MarcSabatella
b50a5543c1
fix #302690 : crash after copying chord symbol
...
Resolves: https://musescore.org/en/node/302690
Currently, a crash can occur after copying a chord symbol.
The Harmony object contains a RealizedHarmony object,
which contains a pointer back to the Harmony object,
but the copy constructor for Harmony does not set the pointer.
This ends up yielding an invalid pointer by the time the copy completes.
This fix makes sure to set the pointer correctly.
It also copies the "_play" property,
otherwise copied chord symbols would not play by default.
2020-03-22 11:07:51 -06:00
Igor Korsukov
366b0f151d
fixed virtual methods
2020-03-21 16:03:04 +02:00
Igor Korsukov
33675a8fa6
try fix crash on Note::drag
2020-03-21 12:49:14 +02:00
Igor Korsukov
9119661781
try fix crash on SlurTieSegment::startEditDrag
2020-03-21 12:15:57 +02:00
Matt McClinch
834404d9da
fix #302603 : Changing "Direction" has no effect on bowing symbols
...
Resolves: https://musescore.org/en/node/302603 .
Many articulations have names like "fermataAbove" and "fermataBelow". The flipping mechanism currently only supports articulations with names in this form. But some articulations have names like "stringsUpBow" and "stringsUpBowTurned". This commit adds the ability to flip articulations with names in this form also.
2020-03-20 12:46:51 -04:00
Igor Korsukov
11f7060e2d
fixed issues from PVS-Studio report (step2)
2020-03-20 16:52:52 +02:00